charleslemaux/Mirror
1
0
Fork 0
mirror of https://github.com/MirrorNetworking/Mirror.git synced 2024-11-18 11:00:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

ILPP hook: don't log weaving failed errors for consistency with old method, and so that tests still work

Browse Source
This commit is contained in:
vis2k 2021-08-28 18:14:57 +08:00
parent 523a6c944d
commit 0c7736cc2f
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Assets/Mirror/Editor/Weaver/EntryPointILPostProcessor/ILPostProcessorHook.cs
View File

@ -119,7 +119,10 @@ public override ILPostProcessResult Process(ICompiledAssembly compiledAssembly)
return new ILPostProcessResult(inMemory, Log.Logs); return new ILPostProcessResult(inMemory, Log.Logs);
} }
} }
else Log.Error($"Weaving failed for: {compiledAssembly.Name}"); // if anything during Weave() fails, we log an error.
// don't need to indicate 'weaving failed' again.
// in fact, this would break tests only expecting certain errors.
//else Log.Error($"Weaving failed for: {compiledAssembly.Name}");
} }
} }
} }