charleslemaux/Mirror
1
0
Fork 0
mirror of https://github.com/MirrorNetworking/Mirror.git synced 2024-11-18 02:50:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: #3308 scene change NetworkClient.owned null entry. NetworkIdentity.OnDestroy now removes from owned. (#3325)

Browse Source
This commit is contained in:
mischa 2022-12-30 18:02:34 +01:00 committed by GitHub
parent 17c5a6c956
commit 100847cc31
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
Assets/Mirror/Core/NetworkIdentity.cs
View File

@ -629,6 +629,20 @@ void OnDestroy()
if (NetworkClient.localPlayer == this)
NetworkClient.localPlayer = null;
}
if (isClient)
{
// ServerChangeScene doesn't send destroy messages.
// some identities may persist in DDOL.
// some are destroyed by scene change.
// if an identity is still in .owned, remove it.
// fixes: https://github.com/MirrorNetworking/Mirror/issues/3308
if (NetworkClient.connection != null &&
NetworkClient.connection.owned.Contains(this))
{
NetworkClient.connection.owned.Remove(this);
}
}
}
internal void OnStartServer()