From 181bab6bd0c87ca944ce26def906f834e464333a Mon Sep 17 00:00:00 2001
From: James Frowen <jamesfrowendev@gmail.com>
Date: Sat, 3 Oct 2020 01:45:40 +0100
Subject: [PATCH] fixing test names (#2309)

* fixing test names

* renaming test files
---
 .../Tests/Editor/Weaver/.WeaverTests.csproj   | 23 ++-----------------
 .../Weaver/WeaverSyncDictionaryTests.cs       |  2 +-
 ...r.cs => GenericSyncDictionaryCanBeUsed.cs} |  4 ++--
 .../Editor/Weaver/WeaverSyncListTests.cs      |  2 +-
 .../GenericSyncListCanBeUsed.cs               | 12 ++++++++++
 ...rWhenUsingGenericListInNetworkBehaviour.cs | 12 ----------
 6 files changed, 18 insertions(+), 37 deletions(-)
 rename Assets/Mirror/Tests/Editor/Weaver/WeaverSyncDictionaryTests~/{SyncDictionaryErrorWhenUsingGenericInNetworkBehaviour.cs => GenericSyncDictionaryCanBeUsed.cs} (51%)
 create mode 100644 Assets/Mirror/Tests/Editor/Weaver/WeaverSyncListTests~/GenericSyncListCanBeUsed.cs
 delete mode 100644 Assets/Mirror/Tests/Editor/Weaver/WeaverSyncListTests~/SyncListErrorWhenUsingGenericListInNetworkBehaviour.cs

diff --git a/Assets/Mirror/Tests/Editor/Weaver/.WeaverTests.csproj b/Assets/Mirror/Tests/Editor/Weaver/.WeaverTests.csproj
index b20868588..350552c2e 100644
--- a/Assets/Mirror/Tests/Editor/Weaver/.WeaverTests.csproj
+++ b/Assets/Mirror/Tests/Editor/Weaver/.WeaverTests.csproj
@@ -183,39 +183,25 @@
     <Compile Include="WeaverNetworkBehaviourTests~\NetworkBehaviourValid.cs" />
     <Compile Include="WeaverSyncDictionaryTests~\SyncDictionary.cs" />
     <Compile Include="WeaverSyncDictionaryTests~\SyncDictionaryErrorForGenericStructItem.cs" />
-    <Compile Include="WeaverSyncDictionaryTests~\SyncDictionaryErrorForGenericStructItemWithCustomDeserializeOnly.cs" />
-    <Compile Include="WeaverSyncDictionaryTests~\SyncDictionaryErrorForGenericStructItemWithCustomSerializeOnly.cs" />
     <Compile Include="WeaverSyncDictionaryTests~\SyncDictionaryErrorForGenericStructKey.cs" />
-    <Compile Include="WeaverSyncDictionaryTests~\SyncDictionaryErrorForGenericStructKeyWithCustomDeserializeOnly.cs" />
-    <Compile Include="WeaverSyncDictionaryTests~\SyncDictionaryErrorForGenericStructKeyWithCustomSerializeOnly.cs" />
-    <Compile Include="WeaverSyncDictionaryTests~\SyncDictionaryErrorWhenUsingGenericInNetworkBehaviour.cs" />
+    <Compile Include="WeaverSyncDictionaryTests~\GenericSyncDictionaryCanBeUsed.cs" />
     <Compile Include="WeaverSyncDictionaryTests~\SyncDictionaryGenericAbstractInheritance.cs" />
     <Compile Include="WeaverSyncDictionaryTests~\SyncDictionaryGenericInheritance.cs" />
     <Compile Include="WeaverSyncDictionaryTests~\SyncDictionaryGenericStructItemWithCustomMethods.cs" />
     <Compile Include="WeaverSyncDictionaryTests~\SyncDictionaryGenericStructKeyWithCustomMethods.cs" />
     <Compile Include="WeaverSyncDictionaryTests~\SyncDictionaryInheritance.cs" />
     <Compile Include="WeaverSyncDictionaryTests~\SyncDictionaryStructItem.cs" />
-    <Compile Include="WeaverSyncDictionaryTests~\SyncDictionaryStructItemWithCustomDeserializeOnly.cs" />
-    <Compile Include="WeaverSyncDictionaryTests~\SyncDictionaryStructItemWithCustomMethods.cs" />
-    <Compile Include="WeaverSyncDictionaryTests~\SyncDictionaryStructItemWithCustomSerializeOnly.cs" />
     <Compile Include="WeaverSyncDictionaryTests~\SyncDictionaryStructKey.cs" />
-    <Compile Include="WeaverSyncDictionaryTests~\SyncDictionaryStructKeyWithCustomDeserializeOnly.cs" />
-    <Compile Include="WeaverSyncDictionaryTests~\SyncDictionaryStructKeyWithCustomMethods.cs" />
-    <Compile Include="WeaverSyncDictionaryTests~\SyncDictionaryStructKeyWithCustomSerializeOnly.cs" />
-    <Compile Include="WeaverSyncEventTests~\MultipleSyncEvent.cs" />
     <Compile Include="WeaverSyncListTests~\SyncList.cs" />
     <Compile Include="WeaverSyncListTests~\SyncListByteValid.cs" />
     <Compile Include="WeaverSyncListTests~\SyncListErrorForGenericStruct.cs" />
-    <Compile Include="WeaverSyncListTests~\SyncListErrorForGenericStructWithCustomDeserializeOnly.cs" />
-    <Compile Include="WeaverSyncListTests~\SyncListErrorForGenericStructWithCustomSerializeOnly.cs" />
     <Compile Include="WeaverSyncListTests~\SyncListErrorForInterface.cs" />
-    <Compile Include="WeaverSyncListTests~\SyncListErrorWhenUsingGenericListInNetworkBehaviour.cs" />
+    <Compile Include="WeaverSyncListTests~\GenericSyncListCanBeUsed.cs" />
     <Compile Include="WeaverSyncListTests~\SyncListGenericAbstractInheritance.cs" />
     <Compile Include="WeaverSyncListTests~\SyncListGenericInheritance.cs" />
     <Compile Include="WeaverSyncListTests~\SyncListGenericInheritanceWithMultipleGeneric.cs" />
     <Compile Include="WeaverSyncListTests~\SyncListGenericStructWithCustomMethods.cs" />
     <Compile Include="WeaverSyncListTests~\SyncListInheritance.cs" />
-    <Compile Include="WeaverSyncListTests~\SyncListInheritanceWithOverrides.cs" />
     <Compile Include="WeaverSyncListTests~\SyncListInterfaceWithCustomMethods.cs" />
     <Compile Include="WeaverSyncListTests~\SyncListMissingParamlessCtor.cs" />
     <Compile Include="WeaverSyncListTests~\SyncListMissingParamlessCtorManuallyInitialized.cs" />
@@ -225,9 +211,6 @@
     <Compile Include="WeaverSyncListTests~\SyncListNestedInStructWithInvalid.cs" />
     <Compile Include="WeaverSyncListTests~\SyncListNestedStruct.cs" />
     <Compile Include="WeaverSyncListTests~\SyncListStruct.cs" />
-    <Compile Include="WeaverSyncListTests~\SyncListStructWithCustomDeserializeOnly.cs" />
-    <Compile Include="WeaverSyncListTests~\SyncListStructWithCustomMethods.cs" />
-    <Compile Include="WeaverSyncListTests~\SyncListStructWithCustomSerializeOnly.cs" />
     <Compile Include="WeaverSyncSetTests~\SyncSet.cs" />
     <Compile Include="WeaverSyncSetTests~\SyncSetByteValid.cs" />
     <Compile Include="WeaverSyncSetTests~\SyncSetGenericAbstractInheritance.cs" />
@@ -254,8 +237,6 @@
     <Compile Include="WeaverSyncVarTests~\SyncVarsStatic.cs" />
     <Compile Include="WeaverSyncVarTests~\SyncVarsSyncList.cs" />
     <Compile Include="WeaverSyncVarTests~\SyncVarsValid.cs" />
-    <Compile Include="WeaverSyncEventTests~\ErrorWhenSyncEventUsesGenericParameter.cs" />
-    <Compile Include="WeaverSyncEventTests~\SyncEventValid.cs" />
     <Compile Include="WeaverTargetRpcTests~\AbstractTargetRpc.cs" />
     <Compile Include="WeaverTargetRpcTests~\ErrorWhenTargetRpcIsStatic.cs" />
     <Compile Include="WeaverTargetRpcTests~\OverrideAbstractTargetRpc.cs" />
diff --git a/Assets/Mirror/Tests/Editor/Weaver/WeaverSyncDictionaryTests.cs b/Assets/Mirror/Tests/Editor/Weaver/WeaverSyncDictionaryTests.cs
index 8cf54dbbd..352c73090 100644
--- a/Assets/Mirror/Tests/Editor/Weaver/WeaverSyncDictionaryTests.cs
+++ b/Assets/Mirror/Tests/Editor/Weaver/WeaverSyncDictionaryTests.cs
@@ -72,7 +72,7 @@ public void SyncDictionaryGenericStructItemWithCustomMethods()
         }
 
         [Test]
-        public void SyncDictionaryErrorWhenUsingGenericInNetworkBehaviour()
+        public void GenericSyncDictionaryCanBeUsed()
         {
             IsSuccess();
         }
diff --git a/Assets/Mirror/Tests/Editor/Weaver/WeaverSyncDictionaryTests~/SyncDictionaryErrorWhenUsingGenericInNetworkBehaviour.cs b/Assets/Mirror/Tests/Editor/Weaver/WeaverSyncDictionaryTests~/GenericSyncDictionaryCanBeUsed.cs
similarity index 51%
rename from Assets/Mirror/Tests/Editor/Weaver/WeaverSyncDictionaryTests~/SyncDictionaryErrorWhenUsingGenericInNetworkBehaviour.cs
rename to Assets/Mirror/Tests/Editor/Weaver/WeaverSyncDictionaryTests~/GenericSyncDictionaryCanBeUsed.cs
index c058937a1..b87c2ee00 100644
--- a/Assets/Mirror/Tests/Editor/Weaver/WeaverSyncDictionaryTests~/SyncDictionaryErrorWhenUsingGenericInNetworkBehaviour.cs
+++ b/Assets/Mirror/Tests/Editor/Weaver/WeaverSyncDictionaryTests~/GenericSyncDictionaryCanBeUsed.cs
@@ -1,8 +1,8 @@
 using Mirror;
 
-namespace WeaverSyncDictionaryTests.SyncDictionaryErrorWhenUsingGenericInNetworkBehaviour
+namespace WeaverSyncDictionaryTests.GenericSyncDictionaryCanBeUsed
 {
-    class SyncDictionaryErrorWhenUsingGenericInNetworkBehaviour : NetworkBehaviour
+    class GenericSyncDictionaryCanBeUsed : NetworkBehaviour
     {
         readonly SomeSyncDictionary<int, string> someDictionary;
 
diff --git a/Assets/Mirror/Tests/Editor/Weaver/WeaverSyncListTests.cs b/Assets/Mirror/Tests/Editor/Weaver/WeaverSyncListTests.cs
index 85d1b0824..c3672bcfa 100644
--- a/Assets/Mirror/Tests/Editor/Weaver/WeaverSyncListTests.cs
+++ b/Assets/Mirror/Tests/Editor/Weaver/WeaverSyncListTests.cs
@@ -133,7 +133,7 @@ public void SyncListInterfaceWithCustomMethods()
         }
 
         [Test]
-        public void SyncListErrorWhenUsingGenericListInNetworkBehaviour()
+        public void GenericSyncListCanBeUsed()
         {
             IsSuccess();
         }
diff --git a/Assets/Mirror/Tests/Editor/Weaver/WeaverSyncListTests~/GenericSyncListCanBeUsed.cs b/Assets/Mirror/Tests/Editor/Weaver/WeaverSyncListTests~/GenericSyncListCanBeUsed.cs
new file mode 100644
index 000000000..86be36c42
--- /dev/null
+++ b/Assets/Mirror/Tests/Editor/Weaver/WeaverSyncListTests~/GenericSyncListCanBeUsed.cs
@@ -0,0 +1,12 @@
+using Mirror;
+
+namespace WeaverSyncListTests.GenericSyncListCanBeUsed
+{
+    class GenericSyncListCanBeUsed : NetworkBehaviour
+    {
+        readonly SomeList<int> someList;
+
+
+        public class SomeList<T> : SyncList<T> { }
+    }
+}
diff --git a/Assets/Mirror/Tests/Editor/Weaver/WeaverSyncListTests~/SyncListErrorWhenUsingGenericListInNetworkBehaviour.cs b/Assets/Mirror/Tests/Editor/Weaver/WeaverSyncListTests~/SyncListErrorWhenUsingGenericListInNetworkBehaviour.cs
deleted file mode 100644
index 937ad9e49..000000000
--- a/Assets/Mirror/Tests/Editor/Weaver/WeaverSyncListTests~/SyncListErrorWhenUsingGenericListInNetworkBehaviour.cs
+++ /dev/null
@@ -1,12 +0,0 @@
-using Mirror;
-
-namespace WeaverSyncListTests.SyncListErrorWhenUsingGenericListInNetworkBehaviour
-{
-    class SyncListErrorWhenUsingGenericListInNetworkBehaviour : NetworkBehaviour
-    {
-        readonly SomeList<int> someList;
-
-
-        public class SomeList<T> : SyncList<T> { }
-    }
-}