charleslemaux/Mirror
1
0
Fork 0
mirror of https://github.com/MirrorNetworking/Mirror.git synced 2024-11-18 11:00:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: Telepathy V1.7 - receive timeout disabled by default; MirrorTransport now uses 30s instead of 5s timeout to avoid timing out during scene changes etc.

Browse Source
This commit is contained in:
vis2k 2021-02-20 11:53:19 +08:00
parent 659c035d42
commit 21196fc05b
3 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Assets/Mirror/Runtime/Transport/Telepathy/Telepathy/Common.cs
View File

@ -25,7 +25,10 @@ public abstract class Common
// Default TCP receive time out can be huge (minutes). // Default TCP receive time out can be huge (minutes).
// That's way too much for games, let's make it configurable. // That's way too much for games, let's make it configurable.
// we need a timeout (in milliseconds) // we need a timeout (in milliseconds)
public int ReceiveTimeout = 5000; // => '0' means disabled
// => disabled by default because some people might use Telepathy
// without Mirror and without sending pings, so timeouts are likely
public int ReceiveTimeout = 0;
// constructor // constructor
protected Common(int MaxMessageSize) protected Common(int MaxMessageSize)

4
Assets/Mirror/Runtime/Transport/Telepathy/Telepathy/VERSION
View File

@ -1,3 +1,7 @@
V1.7 [2021-02-20]
- ReceiveTimeout: disabled by default for cases where people use Telepathy by
itself without pings etc.
V1.6 [2021-02-10] V1.6 [2021-02-10]
- configurable ReceiveTimeout to avoid TCPs high default timeout - configurable ReceiveTimeout to avoid TCPs high default timeout
- Server/Client receive queue limit now disconnects instead of showing a - Server/Client receive queue limit now disconnects instead of showing a

4
Assets/Mirror/Runtime/Transport/Telepathy/TelepathyTransport.cs
View File

@ -24,8 +24,8 @@ public class TelepathyTransport : Transport
[Tooltip("Send timeout in milliseconds.")] [Tooltip("Send timeout in milliseconds.")]
public int SendTimeout = 5000; public int SendTimeout = 5000;
[Tooltip("Receive timeout in milliseconds.")] [Tooltip("Receive timeout in milliseconds. High by default so users don't time out during scene changes.")]
public int ReceiveTimeout = 5000; public int ReceiveTimeout = 30000;
[Header("Server")] [Header("Server")]
[Tooltip("Protect against allocation attacks by keeping the max message size small. Otherwise an attacker might send multiple fake packets with 2GB headers, causing the server to run out of memory after allocating multiple large packets.")] [Tooltip("Protect against allocation attacks by keeping the max message size small. Otherwise an attacker might send multiple fake packets with 2GB headers, causing the server to run out of memory after allocating multiple large packets.")]