fix: Edgegap Lobby Error continues to Connecting (#3898)

Missing return, oops.
Also some minor readability cleanup
This commit is contained in:
Robin Rolf 2024-09-18 14:36:12 +01:00 committed by GitHub
parent 1cc18e67c5
commit 2d9ee5646c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -206,8 +206,11 @@ private IEnumerator WaitForLobbyRelay(string lobbyId, bool forServer)
Api.GetLobby(lobbyId, lobby => Api.GetLobby(lobbyId, lobby =>
{ {
waitingForResponse = false; waitingForResponse = false;
if (!string.IsNullOrEmpty(lobby.assignment.ip)) if (string.IsNullOrEmpty(lobby.assignment.ip))
{ {
// no lobby deployed yet, have the outer loop retry
return;
}
relayAddress = lobby.assignment.ip; relayAddress = lobby.assignment.ip;
foreach (Lobby.Port aport in lobby.assignment.ports) foreach (Lobby.Port aport in lobby.assignment.ports)
{ {
@ -253,6 +256,7 @@ private IEnumerator WaitForLobbyRelay(string lobbyId, bool forServer)
OnClientError?.Invoke(TransportError.Unexpected, errorMsg); OnClientError?.Invoke(TransportError.Unexpected, errorMsg);
ClientDisconnect(); ClientDisconnect();
} }
return;
} }
_status = TransportStatus.Connecting; _status = TransportStatus.Connecting;
if (forServer) if (forServer)
@ -263,7 +267,6 @@ private IEnumerator WaitForLobbyRelay(string lobbyId, bool forServer)
{ {
base.ClientConnect(""); base.ClientConnect("");
} }
}
}, error => }, error =>
{ {
running = false; running = false;