charleslemaux/Mirror
1
0
Fork 0
mirror of https://github.com/MirrorNetworking/Mirror.git synced 2024-11-18 02:50:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Added additional information about OnServerAddPlayer override

Browse Source
This commit is contained in:
Zac North 2018-11-12 10:40:45 -05:00 committed by Paul Pacheco
parent facbbf13c5
commit 2f2c595f41
1 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
migration.md
View File

@ -100,13 +100,22 @@ Every networked prefab and scene object needs to be adjusted. They will be usin
Note that if you remove and add a NetworkIdentity, you will need to reassign it in any component that was referencing it.
## 8. Update Extended Components
Some commonly extended components, such as NetworkManager, have changed method parameters in Mirror. A commonly used override is OnServerAddPlayer. In your newly Mirror-capable NetworkManager, if you are using the OnServerAddPlayer override, make sure that it takes the correct parameters:
```
public override void OnServerAddPlayer(NetworkConnection conn){
base.OnServerAddPlayer(conn);
Some commonly extended components, such as NetworkManager, have changed method parameters in Mirror. A commonly used override is OnServerAddPlayer. Using the original HLAPI, your override may have looked like this:
```C#
public override void OnServerAddPlayer(NetworkConnection conn, short playerControllerId, NetworkReader extraMessageReader)
{
base.OnServerAddPlayer(conn, playerControllerId, extraMessageReader);
// your code
}
```
In your newly Mirror-capable NetworkManager, if you are using the OnServerAddPlayer override, remove the "playerControllerId" parameter from your override and the base call:
```C#
public override void OnServerAddPlayer(NetworkConnection conn, NetworkReader extraMessageReader){
base.OnServerAddPlayer(conn, extraMessageReader);
// your code
}
```
Note that in both HLAPI and Mirror the parameter "extraMessageReader" is optional.
## 9. Update your firewall and router
LLAPI uses UDP. Mirror uses TCP by default. This means you may need to change your router