charleslemaux/Mirror
1
0
Fork 0
mirror of https://github.com/MirrorNetworking/Mirror.git synced 2024-11-18 02:50:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: Add OP_RENEW to SyncDictionary

Browse Source 
When all SyncDictionary values are set simultaneously, this treats the serialization/deserialization as "all" instead of "delta" which means Callback will not be invoked, so you will miss data changes from the host.
This commit is contained in:
Moddingdudes 2023-09-20 22:01:48 -04:00 committed by GitHub
parent 3fff51d4a1
commit 3a30dd84da
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Assets/Mirror/Core/SyncDictionary.cs
View File

@ -18,7 +18,8 @@ public enum Operation : byte
OP_ADD, OP_ADD,
OP_CLEAR, OP_CLEAR,
OP_REMOVE, OP_REMOVE,
OP_SET OP_SET,
OP_RENEW
} }
struct Change struct Change
@ -128,6 +129,8 @@ public override void OnSerializeDelta(NetworkWriter writer)
break; break;
case Operation.OP_CLEAR: case Operation.OP_CLEAR:
break; break;
case Operation.OP_RENEW:
break;
} }
} }
} }
@ -151,6 +154,9 @@ public override void OnDeserializeAll(NetworkReader reader)
// the next time the list is synchronized // the next time the list is synchronized
// because they have already been applied // because they have already been applied
changesAhead = (int)reader.ReadUInt(); changesAhead = (int)reader.ReadUInt();
//Call OP_RENEW when all items have been changed.
AddOperation(Operation.OP_RENEW, default, default, false);
} }
public override void OnDeserializeDelta(NetworkReader reader) public override void OnDeserializeDelta(NetworkReader reader)