charleslemaux/Mirror
1
0
Fork 0
mirror of https://github.com/MirrorNetworking/Mirror.git synced 2024-11-18 02:50:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

perf: PredictedRigidbody now caches original renderers instead of calling GetComponentsInChildren every frame

Browse Source
This commit is contained in:
mischa 2024-01-06 12:20:12 +01:00
parent 4eb9a255a0
commit 3a34dba5ed
1 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
Assets/Mirror/Components/PredictedRigidbody/PredictedRigidbody.cs
View File

@ -105,6 +105,7 @@ public class PredictedRigidbody : NetworkBehaviour
// visually interpolated GameObject copy for smoothing
protected GameObject visualCopy;
protected MeshRenderer[] originalRenderers;
void Awake()
{
@ -153,8 +154,13 @@ protected virtual void CreateVisualCopy()
// if we didn't find a renderer, show a warning
else Debug.LogWarning($"PredictedRigidbody: {name} found no renderer to copy onto the visual object. If you are using a custom setup, please overwrite PredictedRigidbody.CreateVisualCopy().");
// find renderers in children.
// this will be used a lot later, so only find them once when
// creating the visual copy here.
originalRenderers = GetComponentsInChildren<MeshRenderer>();
// replace this renderer's materials with the ghost (if enabled)
foreach (Renderer rend in GetComponentsInChildren<Renderer>())
foreach (MeshRenderer rend in originalRenderers)
{
if (showGhost)
{
@ -184,15 +190,17 @@ protected virtual void DestroyVisualCopy()
protected virtual void UpdateVisualCopy()
{
// only if visual copy was already created
if (visualCopy == null || originalRenderers == null) return;
// only show ghost while interpolating towards the object.
// if we are 'inside' the object then don't show ghost.
// otherwise it just looks like z-fighting the whole time.
// TODO optimize this later
// => iterated the renderers we found when creating the visual copy.
// we don't want to GetComponentsInChildren every time here!
bool insideTarget = Vector3.Distance(transform.position, visualCopy.transform.position) <= ghostDistanceThreshold;
foreach (MeshRenderer rend in GetComponentsInChildren<MeshRenderer>())
{
foreach (MeshRenderer rend in originalRenderers)
rend.enabled = !insideTarget;
}
}
// creater visual copy only on clients, where players are watching.