charleslemaux/Mirror
1
0
Fork 0
mirror of https://github.com/MirrorNetworking/Mirror.git synced 2024-11-18 02:50:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

NetworkConnection.ValidatePacketSize

Browse Source
This commit is contained in:
vis2k 2019-09-28 17:02:00 +02:00
parent d1b9f89c4a
commit 3c9459b60c
1 changed files with 29 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
Assets/Mirror/Runtime/NetworkConnection.cs
View File

@ -243,25 +243,39 @@ public virtual bool Send<T>(T msg, int channelId = Channels.DefaultReliable) whe
return Send(message, channelId);
}
// internal because no one except Mirror should send bytes directly to
// the client. they would be detected as a message. send messages instead.
internal virtual bool Send(byte[] bytes, int channelId = Channels.DefaultReliable)
// validate packet size before sending. show errors if too big/small.
// => it's best to check this here, we can't assume that all transports
// would check max size and show errors internally. best to do it
// in one place in hlapi.
// => it's important to log errors, so the user knows what went wrong.
static bool ValidatePacketSize(byte[] bytes, int channelId)
{
if (logNetworkMessages) Debug.Log("ConnectionSend con:" + connectionId + " bytes:" + BitConverter.ToString(bytes));
if (bytes.Length > Transport.activeTransport.GetMaxPacketSize(channelId))
{
Debug.LogError("NetworkConnection.SendBytes cannot send packet larger than " + Transport.activeTransport.GetMaxPacketSize(channelId) + " bytes");
Debug.LogError("NetworkConnection.ValidatePacketSize: cannot send packet larger than " + Transport.activeTransport.GetMaxPacketSize(channelId) + " bytes");
return false;
}
if (bytes.Length == 0)
{
// zero length packets getting into the packet queues are bad.
Debug.LogError("NetworkConnection.SendBytes cannot send zero bytes");
Debug.LogError("NetworkConnection.ValidatePacketSize: cannot send zero bytes");
return false;
}
// good size
return true;
}
// internal because no one except Mirror should send bytes directly to
// the client. they would be detected as a message. send messages instead.
internal virtual bool Send(byte[] bytes, int channelId = Channels.DefaultReliable)
{
if (logNetworkMessages) Debug.Log("ConnectionSend con:" + connectionId + " bytes:" + BitConverter.ToString(bytes));
// validate packet size first.
if (ValidatePacketSize(bytes, channelId))
{
// send to client or server
if (Transport.activeTransport.ClientConnected())
{
@ -271,6 +285,7 @@ internal virtual bool Send(byte[] bytes, int channelId = Channels.DefaultReliabl
{
return Transport.activeTransport.ServerSend(connectionId, channelId, bytes);
}
}
return false;
}