fix: Decouple ChatWindow from player (#1429)

Assets/Mirror/Examples/Chat/Scripts/ChatNetworkManager.cs

@@ -47,6 +47,8 @@ private void OnCreatePlayer(NetworkConnection connection, CreatePlayerMessage cr
 
             // set it as the player
             NetworkServer.AddPlayerForConnection(connection, playergo);
+
+            chatWindow.gameObject.SetActive(true);
         }
     }
 }

Assets/Mirror/Examples/Chat/Scripts/ChatWindow.cs

@@ -12,6 +12,23 @@ public class ChatWindow : MonoBehaviour
         public Text chatHistory;
         public Scrollbar scrollbar;
 
+        public void Awake()
+        {
+
+            Player.OnMessage += OnPlayerMessage;
+
+        }
+
+        private void OnPlayerMessage(Player player, string message)
+        {
+            string prettyMessage = player.isLocalPlayer ?
+                $"<color=red>{player.playerName}: </color> {message}" :
+                $"<color=blue>{player.playerName}: </color> {message}";
+            AppendMessage(prettyMessage);
+
+            Debug.Log(message);
+        }
+
         public void OnSend()
         {
             if (chatMessage.text.Trim() == "") return;

Assets/Mirror/Examples/Chat/Scripts/Player.cs

@@ -1,3 +1,4 @@
+using System;
 using System.Collections;
 using System.Collections.Generic;
 using UnityEngine;
@@ -9,7 +10,7 @@ public class Player : NetworkBehaviour
         [SyncVar]
         public string playerName;
 
-        public ChatWindow chatWindow => ((ChatNetworkManager)NetworkManager.singleton).chatWindow;
+        public static event Action<Player, string> OnMessage;
 
         [Command]
         public void CmdSend(string message)
@@ -18,21 +19,10 @@ public void CmdSend(string message)
                 RpcReceive(message.Trim());
         }
 
-        public override void OnStartLocalPlayer()
-        {
-            chatWindow.gameObject.SetActive(true);
-        }
-
         [ClientRpc]
         public void RpcReceive(string message)
         {
-            string prettyMessage = isLocalPlayer ?
+            OnMessage?.Invoke(this, message);
-                $"<color=red>{playerName}: </color> {message}" :
-                $"<color=blue>{playerName}: </color> {message}";
-
-            chatWindow.AppendMessage(prettyMessage);
-
-            Debug.Log(message);
         }
     }
 }