charleslemaux/Mirror
1
0
Fork 0
mirror of https://github.com/MirrorNetworking/Mirror.git synced 2024-11-18 02:50:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

NetworkClient.Ready: easier syntax

Browse Source
This commit is contained in:
vis2k 2021-03-13 13:34:58 +08:00
parent f38af96202
commit 4a47b1c7d2
1 changed files with 13 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
Assets/Mirror/Runtime/NetworkClient.cs
View File

@ -772,20 +772,21 @@ public static bool Ready()
}
// need a valid connection to become ready
if (connection != null)
if (connection == null)
{
// Set these before sending the ReadyMessage, otherwise host client
// will fail in InternalAddPlayer with null readyConnection.
// TODO this is redundant. have one source of truth for .ready
ready = true;
connection.isReady = true;
// Tell server we're ready to have a player object spawned
connection.Send(new ReadyMessage());
return true;
Debug.LogError("Ready() called with invalid connection object: conn=null");
return false;
}
Debug.LogError("Ready() called with invalid connection object: conn=null");
return false;
// Set these before sending the ReadyMessage, otherwise host client
// will fail in InternalAddPlayer with null readyConnection.
// TODO this is redundant. have one source of truth for .ready
ready = true;
connection.isReady = true;
// Tell server we're ready to have a player object spawned
connection.Send(new ReadyMessage());
return true;
}
[Obsolete("NetworkClient.Ready doesn't need a NetworkConnection parameter anymore. It always uses NetworkClient.connection anyway.")]