charleslemaux/Mirror
1
0
Fork 0
mirror of https://github.com/MirrorNetworking/Mirror.git synced 2024-11-18 02:50:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

perf(PredictedRigidbody): OnReceivedState compares sqr magnitude

Browse Source
This commit is contained in:
mischa 2024-03-27 22:42:30 +08:00
parent dba373b27d
commit 4b632edc4c
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Assets/Mirror/Components/PredictedRigidbody/PredictedRigidbody.cs
View File

@ -701,8 +701,10 @@ void OnReceivedState(double timestamp, RigidbodyState state)//, bool sleeping)
// this is as fast as it gets for skipping idle objects. // this is as fast as it gets for skipping idle objects.
// //
// if this ever causes issues, feel free to disable it. // if this ever causes issues, feel free to disable it.
float positionToStateDistanceSqr = Vector3.SqrMagnitude(state.position - physicsPosition);
if (compareLastFirst && if (compareLastFirst &&
Vector3.Distance(state.position, physicsPosition) < positionCorrectionThreshold && // Vector3.Distance(state.position, physicsPosition) < positionCorrectionThreshold && // slow comparison
positionToStateDistanceSqr < positionCorrectionThresholdSqr && // fast comparison
Quaternion.Angle(state.rotation, physicsRotation) < rotationCorrectionThreshold) Quaternion.Angle(state.rotation, physicsRotation) < rotationCorrectionThreshold)
{ {
// Debug.Log($"OnReceivedState for {name}: taking optimized early return!"); // Debug.Log($"OnReceivedState for {name}: taking optimized early return!");
@ -754,7 +756,8 @@ void OnReceivedState(double timestamp, RigidbodyState state)//, bool sleeping)
// we clamp it to 'now'. // we clamp it to 'now'.
// but only correct if off by threshold. // but only correct if off by threshold.
// TODO maybe we should interpolate this back to 'now'? // TODO maybe we should interpolate this back to 'now'?
if (Vector3.Distance(state.position, physicsPosition) >= positionCorrectionThreshold) // if (Vector3.Distance(state.position, physicsPosition) >= positionCorrectionThreshold) // slow comparison
if (positionToStateDistanceSqr >= positionCorrectionThresholdSqr) // fast comparison
{ {
// this can happen a lot when latency is ~0. logging all the time allocates too much and is too slow. // this can happen a lot when latency is ~0. logging all the time allocates too much and is too slow.
// double ahead = state.timestamp - newest.timestamp; // double ahead = state.timestamp - newest.timestamp;