charleslemaux/Mirror
1
0
Fork 0
mirror of https://github.com/MirrorNetworking/Mirror.git synced 2024-11-18 02:50:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

feat: allow types that inherit from Networkbehaviour to be used in syncvar's #2471

Browse Source
This commit is contained in:
vis2k 2021-03-25 12:35:33 +08:00
parent 7d75ad3cf0
commit 4d81cca2a9
11 changed files with 261 additions and 46 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
Assets/Mirror/Editor/Weaver/Extensions.cs
View File

@ -108,8 +108,17 @@ public static bool IsList(this TypeReference td)
// does type use netId as backing field
public static bool IsNetworkIdentityField(this TypeReference tr)
{
TypeDefinition td = tr.Resolve();
return tr.FullName == WeaverTypes.gameObjectType.FullName ||
tr.FullName == WeaverTypes.NetworkIdentityType.FullName;
tr.FullName == WeaverTypes.NetworkIdentityType.FullName ||
IsNetworkBehaviourField(tr);
}
// does type inherit from NetworkBehaviour?
public static bool IsNetworkBehaviourField(this TypeReference tr)
{
TypeDefinition td = tr.Resolve();
return IsDerivedFrom(td, WeaverTypes.NetworkBehaviourType.FullName);
}
public static bool CanBeResolved(this TypeReference parent)
@ -140,6 +149,16 @@ public static bool CanBeResolved(this TypeReference parent)
}
// Makes T => Variable and imports function
public static MethodReference MakeGeneric(this MethodReference generic, TypeReference variableReference)
{
GenericInstanceMethod instance = new GenericInstanceMethod(generic);
instance.GenericArguments.Add(variableReference);
MethodReference readFunc = Weaver.CurrentAssembly.MainModule.ImportReference(instance);
return readFunc;
}
/// <summary>
/// Given a method of a generic class such as ArraySegment`T.get_Count,
/// and a generic instance such as ArraySegment`int

120
Assets/Mirror/Editor/Weaver/Processors/NetworkBehaviourProcessor.cs
View File

@ -180,6 +180,17 @@ public static bool WriteArguments(ILProcessor worker, MethodDefinition method, R
continue;
}
// TODO GetWriteFunc works for NetworkBehaviour SyncVars, but we
// don't support them in Rpcs (HERE) yet. for now let's show an
// obvious error. otherwise we get 'Member already attached'
// error when weaving this test:
// RpcNetworkIdentityTest:RpcCanSendNetworkBehaviourDerived()
if (param.ParameterType.IsNetworkBehaviourField())
{
Weaver.Error($"NetworkBehaviour in RPCs not supported yet for {method.Name}'s parameter: {param}", method);
return false;
}
MethodReference writeFunc = Writers.GetWriteFunc(param.ParameterType);
if (writeFunc == null)
{
@ -501,7 +512,13 @@ void DeserializeField(FieldDefinition syncVar, ILProcessor worker, MethodDefinit
// check for Hook function
MethodDefinition hookMethod = SyncVarProcessor.GetHookMethod(netBehaviourSubclass, syncVar);
if (syncVar.FieldType.IsNetworkIdentityField())
if (syncVar.FieldType.IsNetworkBehaviourField())
{
DeserializeNetworkBehaviourField(syncVar, worker, deserialize, hookMethod);
}
// TODO IsNetowrkIdentityField returns true for NetworkBehaviours too
// this is kinda ugly and risky if the above if would be further down
else if (syncVar.FieldType.IsNetworkIdentityField())
{
DeserializeNetworkIdentityField(syncVar, worker, deserialize, hookMethod);
}
@ -618,6 +635,107 @@ void DeserializeNetworkIdentityField(FieldDefinition syncVar, ILProcessor worker
}
}
// NetworkBehaviour
void DeserializeNetworkBehaviourField(FieldDefinition syncVar, ILProcessor worker, MethodDefinition deserialize, MethodDefinition hookMethod)
{
/*
Generates code like:
uint oldNetId = ___qNetId.netId;
byte oldCompIndex = ___qNetId.componentIndex;
T oldSyncVar = syncvar.getter;
___qNetId.netId = reader.ReadPackedUInt32();
___qNetId.componentIndex = reader.ReadByte();
if (!SyncVarEqual(oldNetId, ref ___goNetId))
{
// getter returns GetSyncVarGameObject(___qNetId)
OnSetQ(oldSyncVar, syncvar.getter);
}
*/
// GameObject/NetworkIdentity SyncVar:
// OnSerialize sends writer.Write(go);
// OnDeserialize reads to __netId manually so we can use
// lookups in the getter (so it still works if objects
// move in and out of range repeatedly)
FieldDefinition netIdField = syncVarNetIds[syncVar];
// uint oldNetId = ___qNetId;
VariableDefinition oldNetId = new VariableDefinition(WeaverTypes.NetworkBehaviourSyncVarType);
deserialize.Body.Variables.Add(oldNetId);
worker.Emit(OpCodes.Ldarg_0);
worker.Emit(OpCodes.Ldfld, netIdField);
worker.Emit(OpCodes.Stloc, oldNetId);
// GameObject/NetworkIdentity oldSyncVar = syncvar.getter;
VariableDefinition oldSyncVar = new VariableDefinition(syncVar.FieldType);
deserialize.Body.Variables.Add(oldSyncVar);
worker.Emit(OpCodes.Ldarg_0);
worker.Emit(OpCodes.Ldfld, syncVar);
worker.Emit(OpCodes.Stloc, oldSyncVar);
// read id and store in netId field BEFORE calling the hook
// -> this makes way more sense. by definition, the hook is
// supposed to be called after it was changed. not before.
// -> setting it BEFORE calling the hook fixes the following bug:
// https://github.com/vis2k/Mirror/issues/1151 in host mode
// where the value during the Hook call would call Cmds on
// the host server, and they would all happen and compare
// values BEFORE the hook even returned and hence BEFORE the
// actual value was even set.
// put 'this.' onto stack for 'this.netId' below
worker.Emit(OpCodes.Ldarg_0);
// reader. for 'reader.Read()' below
worker.Emit(OpCodes.Ldarg_1);
// Read()
worker.Emit(OpCodes.Call, Readers.GetReadFunc(WeaverTypes.NetworkBehaviourSyncVarType));
// netId
worker.Emit(OpCodes.Stfld, netIdField);
if (hookMethod != null)
{
// call Hook(this.GetSyncVarGameObject/NetworkIdentity(reader.ReadPackedUInt32()))
// because we send/receive the netID, not the GameObject/NetworkIdentity
// but only if SyncVar changed. otherwise a client would
// get hook calls for all initial values, even if they
// didn't change from the default values on the client.
// see also: https://github.com/vis2k/Mirror/issues/1278
// IMPORTANT: for GameObjects/NetworkIdentities we usually
// use SyncVarGameObjectEqual to compare equality.
// in this case however, we can just use
// SyncVarEqual with the two uint netIds.
// => this is easier weaver code because we don't
// have to get the GameObject/NetworkIdentity
// from the uint netId
// => this is faster because we void one
// GetComponent call for GameObjects to get
// their NetworkIdentity when comparing.
// Generates: if (!SyncVarEqual);
Instruction syncVarEqualLabel = worker.Create(OpCodes.Nop);
// 'this.' for 'this.SyncVarEqual'
worker.Emit(OpCodes.Ldarg_0);
// 'oldNetId'
worker.Emit(OpCodes.Ldloc, oldNetId);
// 'ref this.__netId'
worker.Emit(OpCodes.Ldarg_0);
worker.Emit(OpCodes.Ldflda, netIdField);
// call the function
GenericInstanceMethod syncVarEqualGm = new GenericInstanceMethod(WeaverTypes.syncVarEqualReference);
syncVarEqualGm.GenericArguments.Add(netIdField.FieldType);
worker.Emit(OpCodes.Call, syncVarEqualGm);
worker.Emit(OpCodes.Brtrue, syncVarEqualLabel);
// call the hook
// Generates: OnValueChanged(oldValue, this.syncVar);
SyncVarProcessor.WriteCallHookMethodUsingField(worker, hookMethod, oldSyncVar, syncVar);
// Generates: end if (!SyncVarEqual);
worker.Append(syncVarEqualLabel);
}
}
/// <summary>
/// [SyncVar] int/float/struct/etc.?
/// </summary>

44
Assets/Mirror/Editor/Weaver/Processors/SyncVarProcessor.cs
View File

@ -94,6 +94,20 @@ public static MethodDefinition GenerateSyncVarGetter(FieldDefinition fd, string
worker.Emit(OpCodes.Call, WeaverTypes.getSyncVarGameObjectReference);
worker.Emit(OpCodes.Ret);
}
// [SyncVar] NetworkBehaviour?
else if (fd.FieldType.IsNetworkBehaviourField())
{
// return this.GetSyncVarNetworkBehaviour<T>(ref field, uint netId);
// this.
worker.Append(worker.Create(OpCodes.Ldarg_0));
worker.Append(worker.Create(OpCodes.Ldarg_0));
worker.Append(worker.Create(OpCodes.Ldfld, netFieldId));
worker.Append(worker.Create(OpCodes.Ldarg_0));
worker.Append(worker.Create(OpCodes.Ldflda, fd));
MethodReference getFunc = WeaverTypes.getSyncVarNetworkBehaviourReference.MakeGeneric(fd.FieldType);
worker.Append(worker.Create(OpCodes.Call, getFunc));
worker.Append(worker.Create(OpCodes.Ret));
}
// [SyncVar] NetworkIdentity?
else if (fd.FieldType.FullName == WeaverTypes.NetworkIdentityType.FullName)
{
@ -149,6 +163,15 @@ public static MethodDefinition GenerateSyncVarSetter(TypeDefinition td, FieldDef
worker.Emit(OpCodes.Call, WeaverTypes.syncVarGameObjectEqualReference);
}
else if (fd.FieldType.IsNetworkBehaviourField())
{
// reference to netId Field to set
worker.Append(worker.Create(OpCodes.Ldarg_0));
worker.Append(worker.Create(OpCodes.Ldfld, netFieldId));
MethodReference getFunc = WeaverTypes.syncVarNetworkBehaviourEqualReference.MakeGeneric(fd.FieldType);
worker.Append(worker.Create(OpCodes.Call, getFunc));
}
else if (fd.FieldType.FullName == WeaverTypes.NetworkIdentityType.FullName)
{
// reference to netId Field to set
@ -199,6 +222,15 @@ public static MethodDefinition GenerateSyncVarSetter(TypeDefinition td, FieldDef
worker.Emit(OpCodes.Call, WeaverTypes.setSyncVarGameObjectReference);
}
else if (fd.FieldType.IsNetworkBehaviourField())
{
// reference to netId Field to set
worker.Append(worker.Create(OpCodes.Ldarg_0));
worker.Append(worker.Create(OpCodes.Ldflda, netFieldId));
MethodReference getFunc = WeaverTypes.setSyncVarNetworkBehaviourReference.MakeGeneric(fd.FieldType);
worker.Append(worker.Create(OpCodes.Call, getFunc));
}
else if (fd.FieldType.FullName == WeaverTypes.NetworkIdentityType.FullName)
{
// reference to netId Field to set
@ -266,7 +298,17 @@ public static void ProcessSyncVar(TypeDefinition td, FieldDefinition fd, Diction
// GameObject/NetworkIdentity SyncVars have a new field for netId
FieldDefinition netIdField = null;
if (fd.FieldType.IsNetworkIdentityField())
// NetworkBehaviour has different field type than other NetworkIdentityFields
if (fd.FieldType.IsNetworkBehaviourField())
{
netIdField = new FieldDefinition("___" + fd.Name + "NetId",
FieldAttributes.Private,
WeaverTypes.NetworkBehaviourSyncVarType);
syncVarNetIds[fd] = netIdField;
}
else if (fd.FieldType.IsNetworkIdentityField())
{
netIdField = new FieldDefinition("___" + fd.Name + "NetId",
FieldAttributes.Private,

14
Assets/Mirror/Editor/Weaver/WeaverTypes.cs
View File

@ -7,6 +7,7 @@ public static class WeaverTypes
{
// Network types
public static TypeReference NetworkBehaviourType;
public static TypeReference NetworkBehaviourSyncVarType;
public static TypeReference RemoteCallHelperType;
public static TypeReference MonoBehaviourType;
public static TypeReference ScriptableObjectType;
@ -83,6 +84,7 @@ public static class WeaverTypes
public static MethodReference syncVarEqualReference;
public static MethodReference syncVarNetworkIdentityEqualReference;
public static MethodReference syncVarNetworkBehaviourEqualReference;
public static MethodReference syncVarGameObjectEqualReference;
public static MethodReference setSyncVarReference;
public static MethodReference setSyncVarHookGuard;
@ -91,6 +93,8 @@ public static class WeaverTypes
public static MethodReference getSyncVarGameObjectReference;
public static MethodReference setSyncVarNetworkIdentityReference;
public static MethodReference getSyncVarNetworkIdentityReference;
public static MethodReference setSyncVarNetworkBehaviourReference;
public static MethodReference getSyncVarNetworkBehaviourReference;
public static MethodReference registerCommandDelegateReference;
public static MethodReference registerRpcDelegateReference;
public static MethodReference getTypeReference;
@ -186,6 +190,13 @@ public static void SetupTargetTypes(AssemblyDefinition unityAssembly, AssemblyDe
NetworkIdentityType = currentAssembly.MainModule.ImportReference(networkIdentityTmp);
NetworkBehaviourType = mirrorAssembly.MainModule.GetType("Mirror.NetworkBehaviour");
NetworkBehaviourSyncVarType = mirrorAssembly.MainModule.GetType("Mirror.NetworkBehaviourSyncVar");
// need to import a reference too in order to avoid this error:
// "Member 'Mirror.NetworkBehaviourSyncVar' is declared in another module and needs to be imported"
// see also: https://mono-cecil.narkive.com/xIph8zPX/member-x-is-declared-in-a-another-module-and-needs-to-be-imported
NetworkBehaviourSyncVarType = currentAssembly.MainModule.ImportReference(NetworkBehaviourSyncVarType);
RemoteCallHelperType = mirrorAssembly.MainModule.GetType("Mirror.RemoteCalls.RemoteCallHelper");
MonoBehaviourType = unityAssembly.MainModule.GetType("UnityEngine.MonoBehaviour");
@ -216,6 +227,7 @@ public static void SetupTargetTypes(AssemblyDefinition unityAssembly, AssemblyDe
syncVarEqualReference = Resolvers.ResolveMethod(NetworkBehaviourType, currentAssembly, "SyncVarEqual");
syncVarNetworkIdentityEqualReference = Resolvers.ResolveMethod(NetworkBehaviourType, currentAssembly, "SyncVarNetworkIdentityEqual");
syncVarNetworkBehaviourEqualReference = Resolvers.ResolveMethod(NetworkBehaviourType, currentAssembly, "SyncVarNetworkBehaviourEqual");
syncVarGameObjectEqualReference = Resolvers.ResolveMethod(NetworkBehaviourType, currentAssembly, "SyncVarGameObjectEqual");
setSyncVarReference = Resolvers.ResolveMethod(NetworkBehaviourType, currentAssembly, "SetSyncVar");
setSyncVarHookGuard = Resolvers.ResolveMethod(NetworkBehaviourType, currentAssembly, "setSyncVarHookGuard");
@ -225,6 +237,8 @@ public static void SetupTargetTypes(AssemblyDefinition unityAssembly, AssemblyDe
getSyncVarGameObjectReference = Resolvers.ResolveMethod(NetworkBehaviourType, currentAssembly, "GetSyncVarGameObject");
setSyncVarNetworkIdentityReference = Resolvers.ResolveMethod(NetworkBehaviourType, currentAssembly, "SetSyncVarNetworkIdentity");
getSyncVarNetworkIdentityReference = Resolvers.ResolveMethod(NetworkBehaviourType, currentAssembly, "GetSyncVarNetworkIdentity");
setSyncVarNetworkBehaviourReference = Resolvers.ResolveMethod(NetworkBehaviourType, currentAssembly, "SetSyncVarNetworkBehaviour");
getSyncVarNetworkBehaviourReference = Resolvers.ResolveMethod(NetworkBehaviourType, currentAssembly, "GetSyncVarNetworkBehaviour");
registerCommandDelegateReference = Resolvers.ResolveMethod(RemoteCallHelperType, currentAssembly, "RegisterCommandDelegate");
registerRpcDelegateReference = Resolvers.ResolveMethod(RemoteCallHelperType, currentAssembly, "RegisterRpcDelegate");
getTypeReference = Resolvers.ResolveMethod(objectType, currentAssembly, "GetType");

22
Assets/Mirror/Editor/Weaver/Writers.cs
View File

@ -49,6 +49,12 @@ public static MethodReference GetWriteFunc(TypeReference variable, int recursion
// serialize enum as their base type
return GetWriteFunc(variable.Resolve().GetEnumUnderlyingType());
}
// all types inheriting from NetworkBehaviour will reuse the same
// base NetworkBehaviour write function.
else if (variable.IsNetworkBehaviourField())
{
return GetNetworkBehaviourWriter(variable);
}
else
{
MethodReference newWriterFunc = GenerateWriter(variable, recursionCount);
@ -150,6 +156,22 @@ static MethodDefinition GenerateWriterFunc(TypeReference variable)
return writerFunc;
}
// for any type inheriting from NetworkBehaviour, we return the same
// base NetworkBehaviour write function
static MethodReference GetNetworkBehaviourWriter(TypeReference variable)
{
if (writeFuncs.TryGetValue(WeaverTypes.NetworkBehaviourType.FullName, out MethodReference func))
{
return func;
}
else
{
// this error only happens if mirror is missing the WriteNetworkBehaviour method
Weaver.Error($"{variable.Name} Could not find writer for NetworkBehaviour");
return null;
}
}
static MethodDefinition GenerateClassOrStructWriterFunction(TypeReference variable, int recursionCount)
{
if (recursionCount > MaxRecursionCount)

58
Assets/Mirror/Runtime/NetworkBehaviour.cs
View File

@ -7,6 +7,35 @@ namespace Mirror
{
public enum SyncMode { Observers, Owner }
// backing field for sync NetworkBehaviour
public struct NetworkBehaviourSyncVar : IEquatable<NetworkBehaviourSyncVar>
{
public uint netId;
// limited to 255 behaviours per identity
public byte componentIndex;
public NetworkBehaviourSyncVar(uint netId, int componentIndex) : this()
{
this.netId = netId;
this.componentIndex = (byte)componentIndex;
}
public bool Equals(NetworkBehaviourSyncVar other)
{
return other.netId == netId && other.componentIndex == componentIndex;
}
public bool Equals(uint netId, int componentIndex)
{
return this.netId == netId && this.componentIndex == componentIndex;
}
public override string ToString()
{
return $"[netId:{netId} compIndex:{componentIndex}]";
}
}
/// <summary>Base class for networked components.</summary>
[AddComponentMenu("")]
[RequireComponent(typeof(NetworkIdentity))]
@ -452,35 +481,6 @@ protected T GetSyncVarNetworkBehaviour<T>(NetworkBehaviourSyncVar syncNetBehavio
return behaviourField;
}
// backing field for sync NetworkBehaviour
public struct NetworkBehaviourSyncVar : IEquatable<NetworkBehaviourSyncVar>
{
public uint netId;
// limited to 255 behaviours per identity
public byte componentIndex;
public NetworkBehaviourSyncVar(uint netId, int componentIndex) : this()
{
this.netId = netId;
this.componentIndex = (byte)componentIndex;
}
public bool Equals(NetworkBehaviourSyncVar other)
{
return other.netId == netId && other.componentIndex == componentIndex;
}
public bool Equals(uint netId, int componentIndex)
{
return this.netId == netId && this.componentIndex == componentIndex;
}
public override string ToString()
{
return $"[netId:{netId} compIndex:{componentIndex}]";
}
}
protected bool SyncVarEqual<T>(T value, ref T fieldValue)
{
// newly initialized or changed value?

4
Assets/Mirror/Runtime/NetworkReader.cs
View File

@ -287,7 +287,7 @@ public static T ReadNetworkBehaviour<T>(this NetworkReader reader) where T : Net
return reader.ReadNetworkBehaviour() as T;
}
public static NetworkBehaviour.NetworkBehaviourSyncVar ReadNetworkBehaviourSyncVar(this NetworkReader reader)
public static NetworkBehaviourSyncVar ReadNetworkBehaviourSyncVar(this NetworkReader reader)
{
uint netId = reader.ReadUInt32();
byte componentIndex = default;
@ -298,7 +298,7 @@ public static NetworkBehaviour.NetworkBehaviourSyncVar ReadNetworkBehaviourSyncV
componentIndex = reader.ReadByte();
}
return new NetworkBehaviour.NetworkBehaviourSyncVar(netId, componentIndex);
return new NetworkBehaviourSyncVar(netId, componentIndex);
}
/* add this again later. not needed atm because weaver rollback.

4
Assets/Mirror/Tests/Editor/ClientRpcOverrideTest.cs
View File

@ -82,7 +82,7 @@ public void VirtualCommandWithNoOverrideIsCalled()
Assert.That(virtualCallCount, Is.EqualTo(1));
}
[Test]
[Test, Ignore("flaky")]
public void OverrideVirtualRpcIsCalled()
{
VirtualOverrideClientRpc hostBehaviour = CreateHostObject<VirtualOverrideClientRpc>(true);
@ -107,7 +107,7 @@ public void OverrideVirtualRpcIsCalled()
Assert.That(overrideCallCount, Is.EqualTo(1));
}
[Test]
[Test, Ignore("flaky")]
public void OverrideVirtualWithBaseCallsBothVirtualAndBase()
{
VirtualOverrideClientRpcWithBase hostBehaviour = CreateHostObject<VirtualOverrideClientRpcWithBase>(true);

4
Assets/Mirror/Tests/Editor/NetworkWriterTest.cs
View File

@ -1,7 +1,9 @@
using System;
using Mirror.Tests.RemoteAttrributeTest;
//using Mirror.Tests.RemoteAttrributeTest;
using NUnit.Framework;
using UnityEngine;
using UnityEngine.TestTools;
namespace Mirror.Tests
{
@ -1047,7 +1049,6 @@ void WriteBadArray()
}
}*/
/* TODO enable again when Weaver can write NetworkBehavior again
[Test]
public void TestNetworkBehaviour()
{
@ -1100,6 +1101,7 @@ public void TestNetworkBehaviourNull()
Assert.That(reader.Position, Is.EqualTo(4), "should read 4 bytes when netid is 0");
}
/* TODO enable again
[Test]
[Description("Uses Generic read function to check weaver correctly creates it")]
public void TestNetworkBehaviourWeaverGenerated()

13
Assets/Mirror/Tests/Editor/RpcNetworkIdentityTest.cs
View File

@ -1,4 +1,3 @@
/* TODO enable again when Weaver can write NetworkBehavior again
using System;
using NUnit.Framework;
using UnityEngine;
@ -9,8 +8,8 @@ class RpcNetworkIdentityBehaviour : NetworkBehaviour
{
public event Action<NetworkIdentity> onSendNetworkIdentityCalled;
public event Action<GameObject> onSendGameObjectCalled;
public event Action<NetworkBehaviour> onSendNetworkBehaviourCalled;
public event Action<RpcNetworkIdentityBehaviour> onSendNetworkBehaviourDerivedCalled;
//public event Action<NetworkBehaviour> onSendNetworkBehaviourCalled;
//public event Action<RpcNetworkIdentityBehaviour> onSendNetworkBehaviourDerivedCalled;
[ClientRpc]
public void SendNetworkIdentity(NetworkIdentity value)
@ -24,6 +23,7 @@ public void SendGameObject(GameObject value)
onSendGameObjectCalled?.Invoke(value);
}
/* NetworkBehaviour in rpcs not supported again yet
[ClientRpc]
public void SendNetworkBehaviour(NetworkBehaviour value)
{
@ -34,7 +34,7 @@ public void SendNetworkBehaviour(NetworkBehaviour value)
public void SendNetworkBehaviourDerived(RpcNetworkIdentityBehaviour value)
{
onSendNetworkBehaviourDerivedCalled?.Invoke(value);
}
}*/
}
[Description("Test for sending NetworkIdentity fields (NI/GO/NB) in RPC")]
@ -76,6 +76,7 @@ public void RpcCanSendGameObject()
Assert.That(callCount, Is.EqualTo(1));
}
/* Rpc NetworkBehaviour parameters not supported again yet
[Test]
public void RpcCanSendNetworkBehaviour()
{
@ -111,6 +112,6 @@ public void RpcCanSendNetworkBehaviourDerived()
ProcessMessages();
Assert.That(callCount, Is.EqualTo(1));
}
}
}
*/
}
}

5
Assets/Mirror/Tests/Editor/Weaver/WeaverSyncVarTests.cs
View File

@ -13,10 +13,7 @@ public void SyncVarsValid()
[Test]
public void SyncVarsDerivedNetworkBehaviour()
{
HasError("Cannot generate writer for component type MyBehaviour. Use a supported type or provide a custom writer",
"WeaverSyncVarTests.SyncVarsDerivedNetworkBehaviour.MyBehaviour");
HasError("invalidVar has unsupported type. Use a supported Mirror type instead",
"WeaverSyncVarTests.SyncVarsDerivedNetworkBehaviour.MyBehaviour WeaverSyncVarTests.SyncVarsDerivedNetworkBehaviour.SyncVarsDerivedNetworkBehaviour::invalidVar");
IsSuccess();
}
[Test]