charleslemaux/Mirror
1
0
Fork 0
mirror of https://github.com/MirrorNetworking/Mirror.git synced 2024-11-18 11:00:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

add TODOs

Browse Source
This commit is contained in:
vis2k 2021-03-13 13:16:08 +08:00
parent 5e7c873af9
commit 4daf0e439f
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Assets/Mirror/Runtime/NetworkManager.cs
View File

@ -1220,6 +1220,7 @@ public virtual void OnServerChangeScene(string newSceneName) {}
public virtual void OnServerSceneChanged(string sceneName) {}
/// <summary>Called on the client when connected to a server. By default it sets client as ready and adds a player.</summary>
// TODO client only ever uses NetworkClient.connection. this parameter is redundant.
public virtual void OnClientConnect(NetworkConnection conn)
{
// OnClientConnect by default calls AddPlayer but it should not do
@ -1239,6 +1240,7 @@ public virtual void OnClientConnect(NetworkConnection conn)
}
/// <summary>Called on clients when disconnected from a server.</summary>
// TODO client only ever uses NetworkClient.connection. this parameter is redundant.
public virtual void OnClientDisconnect(NetworkConnection conn)
{
StopClient();
@ -1248,6 +1250,7 @@ public virtual void OnClientDisconnect(NetworkConnection conn)
public virtual void OnClientError(NetworkConnection conn, int errorCode) {}
/// <summary>Called on clients when a servers tells the client it is no longer ready, e.g. when switching scenes.</summary>
// TODO client only ever uses NetworkClient.connection. this parameter is redundant.
public virtual void OnClientNotReady(NetworkConnection conn) {}
/// <summary>Called from ClientChangeScene immediately before SceneManager.LoadSceneAsync is executed</summary>
@ -1258,6 +1261,7 @@ public virtual void OnClientChangeScene(string newSceneName, SceneOperation scen
// Scene changes can cause player objects to be destroyed. The default
// implementation of OnClientSceneChanged in the NetworkManager is to
// add a player object for the connection if no player object exists.
// TODO client only ever uses NetworkClient.connection. this parameter is redundant.
public virtual void OnClientSceneChanged(NetworkConnection conn)
{
// always become ready.