charleslemaux/Mirror
1
0
Fork 0
mirror of https://github.com/MirrorNetworking/Mirror.git synced 2024-11-18 11:00:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: Telepathy updated to latest version: protect against allocation attacks via MaxMessageSize. Can be configured in the TelepathyTransport component now.

Browse Source
This commit is contained in:
vis2k 2019-03-23 20:34:43 +01:00
parent b0af876221
commit 67d715fe74
2 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

BIN
Assets/Mirror/Runtime/Transport/Telepathy/Telepathy.dll
View File

Binary file not shown.

5
Assets/Mirror/Runtime/Transport/TelepathyTransport.cs
View File

@ -10,6 +10,9 @@ public class TelepathyTransport : Transport
[Tooltip("Nagle Algorithm can be disabled by enabling NoDelay")]
public bool NoDelay = true;
[Tooltip("Protect against allocation attacks by keeping the max message size small. Otherwise an attacker might send multiple fake packets with 2GB headers, causing the server to run out of memory after allocating multiple large packets.")]
public int MaxMessageSize = 16 * 1024;
protected Telepathy.Client client = new Telepathy.Client();
protected Telepathy.Server server = new Telepathy.Server();
@ -22,7 +25,9 @@ void Awake()
// configure
client.NoDelay = NoDelay;
client.MaxMessageSize = MaxMessageSize;
server.NoDelay = NoDelay;
server.MaxMessageSize = MaxMessageSize;
// HLAPI's local connection uses hard coded connectionId '0', so we
// need to make sure that external connections always start at '1'