charleslemaux/Mirror
1
0
Fork 0
mirror of https://github.com/MirrorNetworking/Mirror.git synced 2024-11-18 02:50:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: Edgegap Plugin 'InvalidOperationException: This instance has already started one or more requests.' when trying to Connect->Disconnect->Reconnect

Browse Source
This commit is contained in:
mischa 2023-11-05 13:31:13 +01:00
parent ec548a6921
commit 68d768b871
1 changed files with 21 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
Assets/Mirror/Hosting/Edgegap/Editor/EdgegapWindow.cs
View File

@ -250,16 +250,29 @@ string selectedApiTokenValue
{
SetToolUIState(ToolState.Connecting);
_httpClient.BaseAddress = new Uri(selectedApiEnvironment.GetApiUrl());
// MIRROR CHANGE ///////////////////////////////////////////////////
// the old code throws an exception when trying to connect again after disconnecting:
// "InvalidOperationException: This instance has already started one or more requests. Properties can only be modified before sending the first request."
// _httpClient.BaseAddress = new Uri(selectedApiEnvironment.GetApiUrl());
// string path = $"/v1/app/{selectedAppName}/version/{selectedAppVersionName}";
// _httpClient.DefaultRequestHeaders.Accept.Add(new MediaTypeWithQualityHeaderValue("application/json"));
// _httpClient.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("token", selectedApiTokenValue);
// HttpResponseMessage response = await _httpClient.GetAsync(path);
//
// solution: https://stackoverflow.com/questions/51478525/httpclient-this-instance-has-already-started-one-or-more-requests-properties-ca
// "Rather than setting DefaultRequestHeaders, set the headers on each HttpRequestMessage you are sending."
// Create the request message
string baseUrl = selectedApiEnvironment.GetApiUrl();
string path = $"/v1/app/{selectedAppName}/version/{selectedAppVersionName}";
// Headers
_httpClient.DefaultRequestHeaders.Accept.Add(new MediaTypeWithQualityHeaderValue("application/json"));
_httpClient.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("token", selectedApiTokenValue);
// Make HTTP request
HttpResponseMessage response = await _httpClient.GetAsync(path);
Uri fullUrl = new Uri(new Uri(baseUrl), path);
HttpRequestMessage request = new HttpRequestMessage(HttpMethod.Get, fullUrl);
request.Headers.Accept.Clear();
request.Headers.Accept.Add(new MediaTypeWithQualityHeaderValue("application/json"));
request.Headers.Authorization = new AuthenticationHeaderValue("token", selectedApiTokenValue);
HttpResponseMessage response = await _httpClient.SendAsync(request);
// END MIRROR CHANGE ///////////////////////////////////////////////
if (response.IsSuccessStatusCode)
{