charleslemaux/Mirror
1
0
Fork 0
mirror of https://github.com/MirrorNetworking/Mirror.git synced 2024-11-18 11:00:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(NetworkManager): Prevent client from calling ServerChangeScene (#3729)

Browse Source 
- Throws error if server isn't active
- allows for changing to offline scene regardless
This commit is contained in:
MrGadget 2024-01-10 04:16:47 -05:00 committed by GitHub
parent 6445547aef
commit 6e0c4a66d8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Assets/Mirror/Core/NetworkManager.cs
View File

@ -850,6 +850,14 @@ public virtual void ServerChangeScene(string newSceneName)
return; return;
} }
// Throw error if called from client
// Allow changing scene while stopping the server
if (!NetworkServer.active && newSceneName != offlineScene)
{
Debug.LogError("ServerChangeScene can only be called on an active server.");
return;
}
// Debug.Log($"ServerChangeScene {newSceneName}"); // Debug.Log($"ServerChangeScene {newSceneName}");
NetworkServer.SetAllClientsNotReady(); NetworkServer.SetAllClientsNotReady();
networkSceneName = newSceneName; networkSceneName = newSceneName;