charleslemaux/Mirror
1
0
Fork 0
mirror of https://github.com/MirrorNetworking/Mirror.git synced 2024-11-18 02:50:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

NetworkTransformUnreliable: remove dead code

Browse Source
This commit is contained in:
mischa 2024-10-08 15:47:09 +02:00
parent 7bf3f9e78d
commit 6f4cc8ed24
1 changed files with 1 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
Assets/Mirror/Components/NetworkTransform/NetworkTransformUnreliable.cs
View File

@ -20,13 +20,8 @@ public class NetworkTransformUnreliable : NetworkTransformBase
public float rotationSensitivity = 0.01f; public float rotationSensitivity = 0.01f;
public float scaleSensitivity = 0.01f; public float scaleSensitivity = 0.01f;
protected bool positionChanged;
protected bool rotationChanged;
protected bool scaleChanged;
// Used to store last sent snapshots // Used to store last sent snapshots
protected TransformSnapshot lastSnapshot; protected TransformSnapshot lastSnapshot;
protected bool cachedSnapshotComparison;
protected Changed cachedChangedComparison; protected Changed cachedChangedComparison;
protected bool hasSentUnchangedPosition; protected bool hasSentUnchangedPosition;
@ -263,16 +258,6 @@ public override void OnDeserialize(NetworkReader reader, bool initialState)
} }
} }
// Returns true if position, rotation AND scale are unchanged, within given sensitivity range.
protected virtual bool CompareSnapshots(TransformSnapshot currentSnapshot)
{
positionChanged = Vector3.SqrMagnitude(lastSnapshot.position - currentSnapshot.position) > positionSensitivity * positionSensitivity;
rotationChanged = Quaternion.Angle(lastSnapshot.rotation, currentSnapshot.rotation) > rotationSensitivity;
scaleChanged = Vector3.SqrMagnitude(lastSnapshot.scale - currentSnapshot.scale) > scaleSensitivity * scaleSensitivity;
return (!positionChanged && !rotationChanged && !scaleChanged);
}
protected virtual void UpdateLastSentSnapshot(Changed change, TransformSnapshot currentSnapshot) protected virtual void UpdateLastSentSnapshot(Changed change, TransformSnapshot currentSnapshot)
{ {
if (change == Changed.None || change == Changed.CompressRot) return; if (change == Changed.None || change == Changed.CompressRot) return;
@ -316,7 +301,7 @@ protected virtual Changed CompareChangedSnapshots(TransformSnapshot currentSnaps
} }
if (syncRotation) if (syncRotation)
{ {
if (compressRotation) if (compressRotation)
{ {
bool rotationChanged = Quaternion.Angle(lastSnapshot.rotation, currentSnapshot.rotation) > rotationSensitivity; bool rotationChanged = Quaternion.Angle(lastSnapshot.rotation, currentSnapshot.rotation) > rotationSensitivity;
@ -455,21 +440,5 @@ protected virtual void UpdateSyncData(ref SyncData syncData, SortedList<double,
syncData.scale = (syncData.changedDataByte & Changed.Scale) > 0 ? syncData.scale : (snapshots.Count > 0 ? snapshots.Values[snapshots.Count - 1].scale : GetScale()); syncData.scale = (syncData.changedDataByte & Changed.Scale) > 0 ? syncData.scale : (snapshots.Count > 0 ? snapshots.Values[snapshots.Count - 1].scale : GetScale());
} }
} }
// This is to extract position/rotation/scale data from payload. Override
// Construct and Deconstruct if you are implementing a different SyncData logic.
// Note however that snapshot interpolation still requires the basic 3 data
// position, rotation and scale, which are computed from here.
protected virtual void DeconstructSyncData(System.ArraySegment<byte> receivedPayload, out byte? changedFlagData, out Vector3? position, out Quaternion? rotation, out Vector3? scale)
{
using (NetworkReaderPooled reader = NetworkReaderPool.Get(receivedPayload))
{
SyncData syncData = reader.Read<SyncData>();
changedFlagData = (byte)syncData.changedDataByte;
position = syncData.position;
rotation = syncData.quatRotation;
scale = syncData.scale;
}
}
} }
} }