charleslemaux/Mirror
1
0
Fork 0
mirror of https://github.com/MirrorNetworking/Mirror.git synced 2024-11-18 11:00:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

test for #3106 OnStartLocalPlayer being called twice from ReplacePlayerForConnection

Browse Source
This commit is contained in:
vis2k 2022-03-09 16:25:28 +08:00
parent f6df4edaae
commit 70e40b88b5
1 changed files with 33 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
Assets/Mirror/Tests/Editor/NetworkServerTest.cs
View File

@ -1337,6 +1337,39 @@ public void RemovePlayerForConnection_CallsOnStopLocalPlayer()
Assert.That(clientComp.called, Is.EqualTo(1));
}
// test for https://github.com/vis2k/Mirror/issues/3106
// need to make sure OnStartLocalPlayer is only called ONCE, not TWICE.
[Test]
public void ReplacePlayerForConnection_CallsOnStartLocalPlayer()
{
NetworkServer.Listen(1);
ConnectClientBlockingAuthenticatedAndReady(out NetworkConnectionToClient connectionToClient);
// spawn owned object
CreateNetworkedAndSpawnPlayer(
out _, out NetworkIdentity serverPreviousIdentity, out StartLocalPlayerCalledNetworkBehaviour serverPreviousComp,
out _, out NetworkIdentity clientPreviousIdentity, out StartLocalPlayerCalledNetworkBehaviour clientPreviousComp,
connectionToClient);
serverPreviousIdentity.name = nameof(serverPreviousIdentity);
clientPreviousIdentity.name = nameof(clientPreviousIdentity);
// spawn not owned object
CreateNetworkedAndSpawn(
out _, out NetworkIdentity serverNextIdentity, out StartLocalPlayerCalledNetworkBehaviour serverNextComp,
out _, out NetworkIdentity clientNextIdentity, out StartLocalPlayerCalledNetworkBehaviour clientNextComp);
serverNextIdentity.name = nameof(serverNextIdentity);
clientNextIdentity.name = nameof(clientNextIdentity);
// replace connection's player from 'previous' to 'next'
NetworkServer.ReplacePlayerForConnection(connectionToClient, serverNextIdentity.gameObject);
ProcessMessages();
// should NOT call OnStartLocalPlayer on 'previous' since it just stopped being the local player
// should call OnStartLocalPlayer on 'next' since it's became the new local player.
Assert.That(clientPreviousComp.called, Is.EqualTo(0));
Assert.That(clientNextComp.called, Is.EqualTo(1));
}
// test for https://github.com/vis2k/Mirror/issues/3106
[Test]
public void ReplacePlayerForConnection_CallsOnStopLocalPlayer()