charleslemaux/Mirror
1
0
Fork 0
mirror of https://github.com/MirrorNetworking/Mirror.git synced 2024-11-18 11:00:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: NetworkServer.DisconnectAll doesn't set inactive anymore. it should simply "disconnect all" connections.

Browse Source 
otherwise Shutdown may not be able to properly clean up all objects.
prepares to fix #3344
This commit is contained in:
vis2k 2023-01-12 11:44:57 +01:00
parent c04eeacba6
commit 74e6b72239
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Assets/Mirror/Core/NetworkServer.cs
View File

@ -860,7 +860,11 @@ public static void DisconnectAll()
// cleanup // cleanup
connections.Clear(); connections.Clear();
localConnection = null; localConnection = null;
active = false; // this used to set active=false.
// however, then Shutdown can't properly destroy objects:
// https://github.com/MirrorNetworking/Mirror/issues/3344
// "DisconnectAll" should only disconnect all, not set inactive.
// active = false;
} }
// add/remove/replace player /////////////////////////////////////////// // add/remove/replace player ///////////////////////////////////////////