charleslemaux/Mirror
1
0
Fork 0
mirror of https://github.com/MirrorNetworking/Mirror.git synced 2024-11-18 02:50:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: #3365 NetworkClient.OnTransportDisconnected now always invokes OnDisconnected, even during connecting phase

Browse Source
This commit is contained in:
vis2k 2023-01-28 23:41:14 +09:00
parent e21d42a324
commit 7d2d21ac2c
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Assets/Mirror/Core/NetworkClient.cs
View File

@ -383,7 +383,13 @@ internal static void OnTransportDisconnected()
// Raise the event before changing ConnectState
// because 'active' depends on this during shutdown
if (connection != null) OnDisconnectedEvent?.Invoke();
//
// previously OnDisconnected was only invoked if connection != null.
// however, if DNS resolve fails in Transport.Connect(),
// OnDisconnected would never be called because 'connection' is only
// create after the Transport.Connect() call.
// fixes: https://github.com/MirrorNetworking/Mirror/issues/3365
OnDisconnectedEvent?.Invoke();
connectState = ConnectState.Disconnected;
ready = false;