charleslemaux/Mirror
1
0
Fork 0
mirror of https://github.com/MirrorNetworking/Mirror.git synced 2024-11-18 02:50:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: NetworkClient.Disconnect avoids NullReferenceException if Transport ClientDisconnect calls OnDisconnected immediately. Related to: https://github.com/vis2k/Mirror/issues/2353

Browse Source
This commit is contained in:
vis2k 2020-10-21 20:40:14 +02:00
parent ebc9f7a4b3
commit 85be663b13
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
Assets/Mirror/Runtime/NetworkClient.cs
View File

@ -128,7 +128,14 @@ public static void Disconnect()
if (connection != null)
{
connection.Disconnect();
connection.Dispose();
// connection.Disconnect calls Transport.ClientDisconnect.
// if transport calls Mirror's OnDisconnected event immediately
// before returning, then we end up in a circular call:
// https://github.com/vis2k/Mirror/issues/2353
// in which case connection becomes null after returning here.
// in other words, the following Dispose call needs to use '.?'
// to avoid NullReferenceExceptions.
connection?.Dispose();
connection = null;
RemoveTransportHandlers();
}