diff --git a/Assets/Mirror/Editor/Weaver/CompilationFinishedHook.cs b/Assets/Mirror/Editor/Weaver/CompilationFinishedHook.cs index 028809943..49a6bb448 100644 --- a/Assets/Mirror/Editor/Weaver/CompilationFinishedHook.cs +++ b/Assets/Mirror/Editor/Weaver/CompilationFinishedHook.cs @@ -20,7 +20,10 @@ public static class CompilationFinishedHook public static bool WeaverEnabled { get; set; } // controls whether we weave any assemblies when CompilationPipeline delegates are invoked public static bool UnityLogEnabled = true; // controls weather Weaver errors are reported direct to the Unity console (tests enable this) - public static bool WeaveFailed { get; private set; } // holds the result status of our latest Weave operation + + // holds the result status of our latest Weave operation + // NOTE: WeaveFailed is critical to unit tests, but isn't used for anything else. + public static bool WeaveFailed { get; private set; } // debug message handler that also calls OnMessageMethod delegate static void HandleMessage(string msg) @@ -153,7 +156,9 @@ static void OnCompilationFinished(string assemblyPath, CompilerMessage[] message // passing null in the outputDirectory param will do an in-place update of the assembly if (Program.Process(unityEngineCoreModuleDLL, mirrorRuntimeDll, null, new[] { assemblyPath }, dependencyPaths.ToArray(), HandleWarning, HandleError)) { + // NOTE: WeaveFailed is critical for unit tests but isn't used elsewhere WeaveFailed = false; + //Debug.Log("Weaving succeeded for: " + assemblyPath); } else