charleslemaux/Mirror
1
0
Fork 0
mirror of https://github.com/MirrorNetworking/Mirror.git synced 2024-11-18 02:50:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

update comments

Browse Source
This commit is contained in:
vis2k 2021-09-02 19:01:18 +08:00
parent 86eeecc9cf
commit 99e0a6f401
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Assets/Mirror/Runtime/NetworkClient.cs
View File

@ -308,7 +308,7 @@ static bool UnpackAndInvoke(NetworkReader reader, int channelId)
// message in a batch are NOT length prefixed to save bandwidth.
// every message needs to be handled and read until the end.
// otherwise it would overlap into the next message.
// => need to error and disconnect to avoid undefined behaviour.
// => need to warn and disconnect to avoid undefined behaviour.
// => WARNING, not error. can happen if attacker sends random data.
Debug.LogWarning($"Closed connection. Unknown message id: {msgType}. This can happen if no handler was registered for this message.");
connection.Disconnect();

2
Assets/Mirror/Runtime/NetworkServer.cs
View File

@ -441,7 +441,7 @@ static bool UnpackAndInvoke(NetworkConnectionToClient connection, NetworkReader
// message in a batch are NOT length prefixed to save bandwidth.
// every message needs to be handled and read until the end.
// otherwise it would overlap into the next message.
// => need to error and disconnect to avoid undefined behaviour.
// => need to warn and disconnect to avoid undefined behaviour.
// => WARNING, not error. can happen if attacker sends random data.
Debug.LogWarning($"Closed connection: {connection}. Unknown message id: {msgType}. This can happen if no handler was registered for this message.");
connection.Disconnect();