charleslemaux/Mirror
1
0
Fork 0
mirror of https://github.com/MirrorNetworking/Mirror.git synced 2024-11-18 11:00:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Weaver: SyncVarAccessReplacer: syntax & comments to make it more obvious

Browse Source
This commit is contained in:
mischa 2023-06-24 11:39:26 +08:00
parent 6fb0b33188
commit a8a42a2bc1
1 changed files with 21 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
Assets/Mirror/Editor/Weaver/Processors/SyncVarAttributeAccessReplacer.cs
View File

@ -75,24 +75,36 @@ static void ProcessMethod(SyncVarAccessLists syncVarAccessLists, MethodDefinitio
static int ProcessInstruction(SyncVarAccessLists syncVarAccessLists, MethodDefinition md, Instruction instr, int iCount) static int ProcessInstruction(SyncVarAccessLists syncVarAccessLists, MethodDefinition md, Instruction instr, int iCount)
{ {
// stfld (sets value of a field)? // stfld (sets value of a field)?
if (instr.OpCode == OpCodes.Stfld && instr.Operand is FieldDefinition opFieldst) if (instr.OpCode == OpCodes.Stfld)
{ {
ProcessSetInstruction(syncVarAccessLists, md, instr, opFieldst); // operand is a FieldDefinition in the same assembly?
if (instr.Operand is FieldDefinition opFieldst)
{
ProcessSetInstruction(syncVarAccessLists, md, instr, opFieldst);
}
} }
// ldfld (load value of a field)? // ldfld (load value of a field)?
if (instr.OpCode == OpCodes.Ldfld && instr.Operand is FieldDefinition opFieldld) if (instr.OpCode == OpCodes.Ldfld)
{ {
// this instruction gets the value of a field. cache the field reference. // operand is a FieldDefinition in the same assembly?
ProcessGetInstruction(syncVarAccessLists, md, instr, opFieldld); if (instr.Operand is FieldDefinition opFieldld)
{
// this instruction gets the value of a field. cache the field reference.
ProcessGetInstruction(syncVarAccessLists, md, instr, opFieldld);
}
} }
// ldflda (load field address aka reference) // ldflda (load field address aka reference)
if (instr.OpCode == OpCodes.Ldflda && instr.Operand is FieldDefinition opFieldlda) if (instr.OpCode == OpCodes.Ldflda)
{ {
// watch out for initobj instruction // operand is a FieldDefinition in the same assembly?
// see https://github.com/vis2k/Mirror/issues/696 if (instr.Operand is FieldDefinition opFieldlda)
return ProcessLoadAddressInstruction(syncVarAccessLists, md, instr, opFieldlda, iCount); {
// watch out for initobj instruction
// see https://github.com/vis2k/Mirror/issues/696
return ProcessLoadAddressInstruction(syncVarAccessLists, md, instr, opFieldlda, iCount);
}
} }
// we processed one instruction (instr) // we processed one instruction (instr)