charleslemaux/Mirror
1
0
Fork 0
mirror of https://github.com/MirrorNetworking/Mirror.git synced 2024-11-18 02:50:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(MiddlewareTransport): Implement OnServerConnectedWithAddress

Browse Source
This commit is contained in:
MrGadget 2024-07-11 11:27:16 -04:00
parent 8f6b01b0f4
commit aad625decc
2 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
Assets/Mirror/Tests/Editor/Transports/MiddlewareTransportTest.cs
View File

@ -292,13 +292,13 @@ public void TestClientExceptionCallback()
} }
[Test] [Test]
[TestCase(0)] [TestCase(0, "")]
[TestCase(1)] [TestCase(1, "")]
[TestCase(19)] [TestCase(19, "")]
public void TestServerConnectedCallback(int id) public void TestServerConnectedCallback(int id, string remoteClientAddress)
{ {
int called = 0; int called = 0;
middleware.OnServerConnected = (i) => middleware.OnServerConnectedWithAddress = (i, remoteClientAddress) =>
{ {
called++; called++;
Assert.That(i, Is.EqualTo(id)); Assert.That(i, Is.EqualTo(id));
@ -306,10 +306,10 @@ public void TestServerConnectedCallback(int id)
// start to give callback to inner // start to give callback to inner
middleware.ServerStart(); middleware.ServerStart();
inner.OnServerConnected.Invoke(id); inner.OnServerConnectedWithAddress.Invoke(id, remoteClientAddress);
Assert.That(called, Is.EqualTo(1)); Assert.That(called, Is.EqualTo(1));
inner.OnServerConnected.Invoke(id); inner.OnServerConnectedWithAddress.Invoke(id, remoteClientAddress);
Assert.That(called, Is.EqualTo(2)); Assert.That(called, Is.EqualTo(2));
} }

1
Assets/Mirror/Transports/Middleware/MiddlewareTransport.cs
View File

@ -43,6 +43,7 @@ public override void ClientConnect(string address)
public override void ServerStart() public override void ServerStart()
{ {
inner.OnServerConnected = OnServerConnected; inner.OnServerConnected = OnServerConnected;
inner.OnServerConnectedWithAddress = OnServerConnectedWithAddress;
inner.OnServerDataReceived = OnServerDataReceived; inner.OnServerDataReceived = OnServerDataReceived;
inner.OnServerDisconnected = OnServerDisconnected; inner.OnServerDisconnected = OnServerDisconnected;
inner.OnServerError = OnServerError; inner.OnServerError = OnServerError;