charleslemaux/Mirror
1
0
Fork 0
mirror of https://github.com/MirrorNetworking/Mirror.git synced 2024-11-18 02:50:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

ignore getter too

Browse Source
This commit is contained in:
vis2k 2022-04-02 12:26:31 +08:00
parent f39862f8ac
commit af9f92713e
1 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
Assets/Mirror/Editor/Weaver/Processors/SyncVarAttributeAccessReplacer.cs
View File

@ -171,15 +171,17 @@ static int ProcessLoadAddressInstruction(SyncVarAccessLists syncVarAccessLists,
// https://github.com/vis2k/Mirror/issues/3129
else
{
// need to ignore ref passing in the generated [SyncVar]
// property. that's allowed. everywhere else it's not.
// for example, Networkhealth generated property setter calls
// NetworkBehaviour.GeneratedSyncVarSetter(ref originalField, ...)
//
// generated Deserialization also passes as ref for same method.
// ignore that too.
if (md != replacement &&
md.Name != NetworkBehaviourProcessor.DeserializeMethodName)
// the original [SyncVar] field is passed as ref by weaver.
// * generated property getter may pass as ref for NI:
// GetSyncVarNetworkIdentity(___currentPlayerNetId, ref currentPlayer);
// * generated property setter always passes as ref:
// GeneratedSyncVarSetter_NetworkIdentity(value, ref currentPlayer, ...);
// * generated DeserializeSyncVars passes as ref:
// GeneratedSyncVarDeserialize_NetworkIdentity(ref currentPlayer, ...);
// ignore these cases. forbid everything else.
if (md != replacement && // setter
!syncVarAccessLists.replacementGetterProperties.ContainsKey(opField) && // getter
md.Name != NetworkBehaviourProcessor.DeserializeMethodName) // Deserialize
{
Log.Error($"{md.FullName} accesses [SyncVar] {opField.Name} by reference. [REPLACEMENT={replacement.Name}] This is not supported, because [SyncVar]s are internally represented as properties, and C# can not access properties by reference.");
WeavingFailed = true;