charleslemaux/Mirror
1
0
Fork 0
mirror of https://github.com/MirrorNetworking/Mirror.git synced 2024-11-18 11:00:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

explain the special case in RebuildObservers

Browse Source
This commit is contained in:
vis2k 2019-11-25 19:11:47 +09:00
parent e0d276e86b
commit ba88ca6ab5
1 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
Assets/Mirror/Runtime/NetworkIdentity.cs
View File

@ -1021,7 +1021,22 @@ public void RebuildObservers(bool initialize)
} }
} }
// special case for host mode client. // special case for host mode: we use SetHostVisibility to hide
// NetworkIdentities that aren't in observer range from host.
// this is what games like Dota/Counter-Strike do too, where a host
// does NOT see all players by default. they are in memory, but
// hidden to the host player.
//
// this code is from UNET, it's a bit strange but it works:
// * it hides newly connected identities in host mode
// => that part was the intended behaviour
// * it hides ALL NetworkIdentities in host mode when the host
// connects but hasn't selected a character yet
// * it hides ALL NetworkIdentities in server-only mode because
// observers never contain the 'null' .localConnection
// => that was not intended, but let's keep it as it is so we
// don't break anything in host mode. it's way easier than
// iterating all identities in a special function in StartHost.
if (initialize) if (initialize)
{ {
if (!newObservers.Contains(NetworkServer.localConnection)) if (!newObservers.Contains(NetworkServer.localConnection))