charleslemaux/Mirror
1
0
Fork 0
mirror of https://github.com/MirrorNetworking/Mirror.git synced 2024-11-18 02:50:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

More ForceShown fixes

Browse Source
This commit is contained in:
Robin Rolf 2024-01-30 02:51:02 +01:00
parent 477d430a3f
commit bf49b6c923
2 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Assets/Mirror/Components/InterestManagement/SpatialHashing/FastSpatialInterestManagement.cs
View File

@ -345,13 +345,8 @@ private void RemoveObserversShownToDefault(NetworkIdentity changedIdentity, Vect
foreach (NetworkIdentity gridIdentity in tile) foreach (NetworkIdentity gridIdentity in tile)
{ {
if (gridIdentity == changedIdentity)
{
// Don't do anything with yourself
continue;
}
// if the gridIdentity is a player, it can see changedIdentity // if the gridIdentity is a player, it can see changedIdentity
// (also yourself! don't need the extra check here)
if (gridIdentity.connectionToClient != null) if (gridIdentity.connectionToClient != null)
{ {
tempShownToDefaultSet.Remove(gridIdentity.connectionToClient); tempShownToDefaultSet.Remove(gridIdentity.connectionToClient);

9
Assets/Mirror/Tests/Editor/InterestManagement/InterestManagementTests_FastSpatialHashing.cs
View File

@ -154,6 +154,15 @@ public void ForceShown()
// A&B should see each other // A&B should see each other
Assert.That(a.observers.ContainsKey(b.connectionToClient.connectionId), Is.True); Assert.That(a.observers.ContainsKey(b.connectionToClient.connectionId), Is.True);
Assert.That(b.observers.ContainsKey(a.connectionToClient.connectionId), Is.True); Assert.That(b.observers.ContainsKey(a.connectionToClient.connectionId), Is.True);
// A&B to default
a.visibility = Visibility.Default;
b.visibility = Visibility.Default;
aoi.LateUpdate();
AssertSelfVisible(a);
AssertSelfVisible(b);
// and they can't see each other anymore
Assert.That(a.observers.ContainsKey(b.connectionToClient.connectionId), Is.False);
Assert.That(b.observers.ContainsKey(a.connectionToClient.connectionId), Is.False);
} }
[Test] [Test]