charleslemaux/Mirror
1
0
Fork 0
mirror of https://github.com/MirrorNetworking/Mirror.git synced 2024-11-18 02:50:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Optimize SmoothFollowPhysicsCopy

Browse Source
This commit is contained in:
Justin Nolan 2024-02-10 21:23:28 +08:00
parent 946716b29a
commit bf9ee49e37
1 changed files with 30 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
Assets/Mirror/Components/PredictedRigidbody/PredictedRigidbody.cs
View File

@ -90,7 +90,7 @@ public class PredictedRigidbody : NetworkBehaviour
protected Transform physicsCopyTransform; // caching to avoid GetComponent protected Transform physicsCopyTransform; // caching to avoid GetComponent
protected Rigidbody physicsCopyRigidbody; // caching to avoid GetComponent protected Rigidbody physicsCopyRigidbody; // caching to avoid GetComponent
protected Collider physicsCopyCollider; // caching to avoid GetComponent protected Collider physicsCopyCollider; // caching to avoid GetComponent
float smoothFollowThreshold; // caching to avoid calculation in LateUpdate float smoothFollowThresholdSquared; // caching to avoid calculation in LateUpdate
// we also create one extra ghost for the exact known server state. // we also create one extra ghost for the exact known server state.
protected GameObject remoteCopy; protected GameObject remoteCopy;
@ -208,7 +208,7 @@ protected virtual void CreateGhosts()
// cache some threshold to avoid calculating them in LateUpdate // cache some threshold to avoid calculating them in LateUpdate
float colliderSize = physicsCopyCollider.bounds.size.magnitude; float colliderSize = physicsCopyCollider.bounds.size.magnitude;
smoothFollowThreshold = colliderSize * teleportDistanceMultiplier; smoothFollowThresholdSquared = (colliderSize * teleportDistanceMultiplier) * (colliderSize * teleportDistanceMultiplier);
} }
protected virtual void DestroyGhosts() protected virtual void DestroyGhosts()
@ -262,11 +262,19 @@ protected virtual void SmoothFollowPhysicsCopy()
physicsCopyTransform.GetPositionAndRotation(out Vector3 physicsPosition, out Quaternion physicsRotation); // faster than physicsCopyRigidbody.position + physicsCopyRigidbody.rotation physicsCopyTransform.GetPositionAndRotation(out Vector3 physicsPosition, out Quaternion physicsRotation); // faster than physicsCopyRigidbody.position + physicsCopyRigidbody.rotation
float deltaTime = Time.deltaTime; float deltaTime = Time.deltaTime;
float distance = Vector3.Distance(currentPosition, physicsPosition); // avoid vector ops because current scripting backends are terrible at inlining
if (distance > smoothFollowThreshold) // https://github.com/Unity-Technologies/UnityCsReference/blob/4e215c07ca8e9a32a589043202fd919bdfc0a26d/Runtime/Export/Math/Vector3.cs#L63
float toVectorX = physicsPosition.x - currentPosition.x;
float toVectorY = physicsPosition.y - currentPosition.y;
float toVectorZ = physicsPosition.z - currentPosition.z;
float distanceSquared = toVectorX * toVectorX + toVectorY * toVectorY + toVectorZ * toVectorZ;
// Compare the square distances to avoid Math.Sqrt
if (distanceSquared > smoothFollowThresholdSquared)
{ {
tf.SetPositionAndRotation(physicsPosition, physicsRotation); // faster than .position and .rotation manually tf.SetPositionAndRotation(physicsPosition, physicsRotation); // faster than .position and .rotation manually
Debug.Log($"[PredictedRigidbody] Teleported because distance to physics copy = {distance:F2} > threshold {smoothFollowThreshold:F2}"); Debug.Log($"[PredictedRigidbody] Teleported because distance squared to physics copy = {distanceSquared:F2} > threshold {smoothFollowThresholdSquared:F2}");
return; return;
} }
@ -275,8 +283,23 @@ protected virtual void SmoothFollowPhysicsCopy()
// => speed increases by distance² because the further away, the // => speed increases by distance² because the further away, the
// sooner we need to catch the fuck up // sooner we need to catch the fuck up
// float positionStep = (distance * distance) * interpolationSpeed; // float positionStep = (distance * distance) * interpolationSpeed;
float positionStep = distance * positionInterpolationSpeed; float positionStep = distanceSquared * positionInterpolationSpeed * deltaTime;
Vector3 newPosition = Vector3.MoveTowards(currentPosition, physicsPosition, positionStep * deltaTime);
Vector3 newPosition;
// Dont call Vector3.MoveTowards as it calculates (physicsPosition - currentPosition) and the square distance again which we already did
if (distanceSquared == 0 || (positionStep >= 0 && distanceSquared <= positionStep * positionStep))
{
newPosition = physicsPosition;
}
else
{
float distance = (float)Math.Sqrt(distanceSquared);
newPosition = new Vector3(currentPosition.x + toVectorX / distance * positionStep,
currentPosition.y + toVectorY / distance * positionStep,
currentPosition.z + toVectorZ / distance * positionStep);
}
// smoothly interpolate to the target rotation. // smoothly interpolate to the target rotation.
// Quaternion.RotateTowards doesn't seem to work at all, so let's use SLerp. // Quaternion.RotateTowards doesn't seem to work at all, so let's use SLerp.