charleslemaux/Mirror
1
0
Fork 0
mirror of https://github.com/MirrorNetworking/Mirror.git synced 2024-11-18 11:00:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

NetworkServer/Client Broadcast: consistent syntax

Browse Source
This commit is contained in:
mischa 2024-07-27 10:10:38 +02:00 committed by MrGadget
parent cfebe511fa
commit ca27f3d6c9
2 changed files with 20 additions and 41 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
Assets/Mirror/Core/NetworkClient.cs
View File

@ -1512,24 +1512,10 @@ static void BootstrapIdentity(NetworkIdentity identity)
}
// broadcast ///////////////////////////////////////////////////////////
static void BroadcastTimeSnapshot()
// NetworkServer has BroadcastToConnection.
// NetworkClient has BroadcastToServer.
static void BroadcastToServer()
{
Send(new TimeSnapshotMessage(), Channels.Unreliable);
}
// make sure Broadcast() is only called every sendInterval.
// calling it every update() would require too much bandwidth.
static void Broadcast()
{
// joined the world yet?
if (!connection.isReady) return;
// nothing to do in host mode. server already knows the state.
if (NetworkServer.active) return;
// send time snapshot every sendInterval.
BroadcastTimeSnapshot();
// for each entity that the client owns
foreach (NetworkIdentity identity in connection.owned)
{
@ -1563,6 +1549,23 @@ static void Broadcast()
}
}
// make sure Broadcast() is only called every sendInterval.
// calling it every update() would require too much bandwidth.
static void Broadcast()
{
// joined the world yet?
if (!connection.isReady) return;
// nothing to do in host mode. server already knows the state.
if (NetworkServer.active) return;
// send time snapshot every sendInterval.
Send(new TimeSnapshotMessage(), Channels.Unreliable);
// broadcast client state to server
BroadcastToServer();
}
// update //////////////////////////////////////////////////////////////
// NetworkEarlyUpdate called before any Update/FixedUpdate
// (we add this to the UnityEngine in NetworkLoop)

24
Assets/Mirror/Core/NetworkServer.cs
View File

@ -1963,30 +1963,6 @@ static void Broadcast()
// update connection to flush out batched messages
connection.Update();
}
// TODO this is way too slow because we iterate ALL spawned :/
// TODO this is way too complicated :/
// to understand what this tries to prevent, consider this example:
// monster has health=100
// we change health=200, dirty bit is set
// player comes in range, gets full serialization spawn packet.
// next Broadcast(), player gets the health=200 change because dirty bit was set.
//
// this code clears all dirty bits if no players are around to prevent it.
// BUT there are two issues:
// 1. what if a playerB was around the whole time?
// 2. why don't we handle broadcast and spawn packets both HERE?
// handling spawn separately is why we need this complex magic
//
// see test: DirtyBitsAreClearedForSpawnedWithoutObservers()
// see test: SyncObjectChanges_DontGrowWithoutObservers()
//
// PAUL: we also do this to avoid ever growing SyncList .changes
//ClearSpawnedDirtyBits();
//
// this was moved to NetworkIdentity.AddObserver!
// same result, but no more O(N) loop in here!
// TODO remove this comment after moving spawning into Broadcast()!
}
// update //////////////////////////////////////////////////////////////