charleslemaux/Mirror
1
0
Fork 0
mirror of https://github.com/MirrorNetworking/Mirror.git synced 2024-11-18 19:10:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

cleanup

Browse Source
This commit is contained in:
vis2k 2021-08-11 13:59:31 +08:00
parent f61dd290e3
commit cf29a06bca
1 changed files with 5 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
Assets/Mirror/Tests/Runtime/ClientSceneTests_LocalPlayer.cs
View File

@ -20,17 +20,14 @@ public override void SetUp()
public IEnumerator LocalPlayerIsSetToNullAfterDestroy() public IEnumerator LocalPlayerIsSetToNullAfterDestroy()
{ {
// need spawned local player // need spawned local player
CreateNetworkedAndSpawnPlayer(out GameObject go, out NetworkIdentity identity, NetworkServer.localConnection); CreateNetworkedAndSpawnPlayer(out GameObject go, out _, NetworkServer.localConnection);
// need to have localPlayer set for this test // need to have localPlayer set for this test
Assert.That(NetworkClient.localPlayer, !Is.Null); Assert.That(NetworkClient.localPlayer, !Is.Null);
// destroy, wait one frame, localPlayer should be cleared
GameObject.Destroy(go); GameObject.Destroy(go);
// wait a frame for destroy to happen
yield return null; yield return null;
// use "is null" here to avoid unity == check
Assert.IsTrue(NetworkClient.localPlayer is null, "local player should be set to c# null"); Assert.IsTrue(NetworkClient.localPlayer is null, "local player should be set to c# null");
} }
@ -46,11 +43,9 @@ public IEnumerator DestroyingOtherObjectDoesntEffectLocalPlayer()
// need to have localPlayer set for this test // need to have localPlayer set for this test
Assert.That(NetworkClient.localPlayer, !Is.Null); Assert.That(NetworkClient.localPlayer, !Is.Null);
// destroy, wait one frame, localPlayer should remain
GameObject.Destroy(notPlayer); GameObject.Destroy(notPlayer);
// wait a frame for destroy to happen
yield return null; yield return null;
Assert.IsTrue(NetworkClient.localPlayer != null, "local player should not be cleared"); Assert.IsTrue(NetworkClient.localPlayer != null, "local player should not be cleared");
Assert.IsTrue(NetworkClient.localPlayer == player, "local player should still be equal to player"); Assert.IsTrue(NetworkClient.localPlayer == player, "local player should still be equal to player");
} }
@ -59,20 +54,17 @@ public IEnumerator DestroyingOtherObjectDoesntEffectLocalPlayer()
public IEnumerator LocalPlayerIsSetToNullAfterDestroyMessage() public IEnumerator LocalPlayerIsSetToNullAfterDestroyMessage()
{ {
// need spawned local player // need spawned local player
CreateNetworkedAndSpawnPlayer(out GameObject go, out NetworkIdentity identity, NetworkServer.localConnection); CreateNetworkedAndSpawnPlayer(out _, out NetworkIdentity identity, NetworkServer.localConnection);
// need to have localPlayer set for this test // need to have localPlayer set for this test
Assert.That(NetworkClient.localPlayer, !Is.Null); Assert.That(NetworkClient.localPlayer, !Is.Null);
// OnObjectDestroy, wait one frame, localPlayer should be cleared
NetworkClient.OnObjectDestroy(new ObjectDestroyMessage NetworkClient.OnObjectDestroy(new ObjectDestroyMessage
{ {
netId = identity.netId netId = identity.netId
}); });
// wait a frame for destroy to happen
yield return null; yield return null;
// use "is null" here to avoid unity == check
Assert.IsTrue(NetworkClient.localPlayer is null, "local player should be set to c# null"); Assert.IsTrue(NetworkClient.localPlayer is null, "local player should be set to c# null");
} }
} }