charleslemaux/Mirror
1
0
Fork 0
mirror of https://github.com/MirrorNetworking/Mirror.git synced 2024-11-18 02:50:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

using IsDerivedFrom instead of while loop (#1739)

Browse Source
This commit is contained in:
James Frowen 2020-04-19 20:12:37 +01:00 committed by GitHub
parent a86d1cdfff
commit f17cea771e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
Assets/Mirror/Editor/Weaver/Weaver.cs
View File

@ -417,38 +417,20 @@ static bool WeaveSyncObject(TypeDefinition td)
bool modified = false;
// are ANY parent classes SyncListStruct
TypeReference parent = td.BaseType;
while (parent != null)
if (td.IsDerivedFrom(SyncListType))
{
if (parent.FullName.StartsWith(SyncListType.FullName, StringComparison.Ordinal))
{
SyncListProcessor.Process(td);
modified = true;
break;
}
if (parent.FullName.StartsWith(SyncSetType.FullName, StringComparison.Ordinal))
{
SyncListProcessor.Process(td);
modified = true;
break;
}
if (parent.FullName.StartsWith(SyncDictionaryType.FullName, StringComparison.Ordinal))
{
SyncDictionaryProcessor.Process(td);
modified = true;
break;
}
try
{
parent = parent.Resolve().BaseType;
}
catch (AssemblyResolutionException)
{
// this can happen for pluins.
//Console.WriteLine("AssemblyResolutionException: "+ ex.ToString());
break;
}
SyncListProcessor.Process(td);
modified = true;
}
else if (td.IsDerivedFrom(SyncSetType))
{
SyncListProcessor.Process(td);
modified = true;
}
else if (td.IsDerivedFrom(SyncDictionaryType))
{
SyncDictionaryProcessor.Process(td);
modified = true;
}
// check for embedded types