charleslemaux/Mirror
1
0
Fork 0
mirror of https://github.com/MirrorNetworking/Mirror.git synced 2024-11-18 02:50:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

UnpackAndInvoke: invalid message header errors changed to warnings. it can happen if an attacker sends random data.

Browse Source
This commit is contained in:
vis2k 2021-09-02 19:29:31 +08:00
parent 2026b6038b
commit f67704bbd9
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Assets/Mirror/Runtime/NetworkClient.cs
View File

@ -318,7 +318,8 @@ static bool UnpackAndInvoke(NetworkReader reader, int channelId)
}
else
{
Debug.LogError("Invalid message header.");
// => WARNING, not error. can happen if attacker sends random data.
Debug.LogWarning("Invalid message header.");
// simply return false. caller is responsible for disconnecting.
//connection.Disconnect();
return false;

3
Assets/Mirror/Runtime/NetworkServer.cs
View File

@ -451,7 +451,8 @@ static bool UnpackAndInvoke(NetworkConnectionToClient connection, NetworkReader
}
else
{
Debug.LogError($"Invalid message header for connection: {connection}.");
// => WARNING, not error. can happen if attacker sends random data.
Debug.LogWarning($"Invalid message header for connection: {connection}.");
// simply return false. caller is responsible for disconnecting.
//connection.Disconnect();
return false;