Commit Graph

8283 Commits

Author SHA1 Message Date
Paul Pacheco
0772d44761 Nobody should instantiate LogFilter 2018-10-12 15:59:44 -05:00
Paul Pacheco
5879d24cb0 Remove extra semicolons 2018-10-12 15:59:01 -05:00
Paul Pacheco
6356e411be Spacing issues 2018-10-12 14:14:25 -05:00
Paul Pacheco
52ca8b746a Remove extra line 2018-10-12 13:17:53 -05:00
Paul Pacheco
8c9b937091 Remove extra semicolon 2018-10-12 13:16:43 -05:00
Paul Pacheco
1a326d0957 Do not initialize variables to default values, found by SA 2018-10-12 11:30:43 -05:00
Paul Pacheco
f15888dfef Removed unused parameters 2018-10-12 11:25:02 -05:00
Paul Pacheco
c258585cb2
Fix code style issues
Fix code styles issues found by SA
2018-10-12 11:08:16 -05:00
Paul Pacheco
3512903ec3
Fix invalid link
this is not a link
2018-10-11 21:06:34 -05:00
Paul Pacheco
9c874fa6e8
Fix bullet point indentation 2018-10-11 21:04:24 -05:00
Paul Pacheco
7317637682
Fix bullet indentation
Static analysis keeps bitching about this
2018-10-11 21:03:10 -05:00
Paul Pacheco
49b3f2bcaa
Fix bullet indentation
Static analysis keeps bitching about this.
2018-10-11 20:56:21 -05:00
Paul Pacheco
6684851467 Make variable local, keep less state 2018-10-11 20:24:34 -05:00
Paul Pacheco
7750ab664c Make variable local 2018-10-11 20:23:00 -05:00
Paul Pacheco
5a1be98885 initialize these lists only once 2018-10-11 20:19:57 -05:00
Paul Pacheco
a4b642fca6 These fields should never be assigned after creation 2018-10-11 20:16:35 -05:00
Paul Pacheco
875115db2c Remove redundant parenthesis 2018-10-11 20:13:54 -05:00
Paul Pacheco
b57bbf4ec7 ensure reader is only initialized once 2018-10-11 20:12:01 -05:00
Paul Pacheco
71ea8291d4 Make sure m_MessageHandlers are initialized only once 2018-10-11 20:11:06 -05:00
Paul Pacheco
8716eb6cdf remove redundant array size spec 2018-10-11 20:09:14 -05:00
Paul Pacheco
1b81fea8ef Channel is only set at constructor 2018-10-11 19:58:08 -05:00
Paul Pacheco
e2577ef785 Simplify conditionals 2018-10-11 19:43:20 -05:00
Paul Pacheco
9a542e98cc Simplify conditional 2018-10-11 19:40:36 -05:00
Paul Pacheco
e265ef3efd Remove useless assignment 2018-10-11 19:32:11 -05:00
Paul Pacheco
bb237d6fbb Simplify conditional 2018-10-11 19:31:39 -05:00
Paul Pacheco
5bd90fa63c Removed useless assignment 2018-10-11 19:30:42 -05:00
Paul Pacheco
680d6437af Simplify conditional 2018-10-11 19:29:25 -05:00
Paul Pacheco
31d39744e8 Remove duplicate lines 2018-10-10 13:53:40 -05:00
Paul Pacheco
f1efb6b889 Implement IEquatable as recommended by Microsoft and SA 2018-10-10 09:51:27 -05:00
Paul Pacheco
5b0d1190b8 Implement IEquatable as recommended by Microsoft and SA 2018-10-10 09:43:00 -05:00
Paul Pacheco
9cd74a240f Removed unused method 2018-10-09 23:59:15 -05:00
Paul Pacheco
f0723e50dd simplify with null coalesce 2018-10-09 23:53:02 -05:00
Paul Pacheco
059730ca37 Remove redundant casting 2018-10-09 14:48:04 -05:00
Paul Pacheco
757cafe0a7 Remove unused variable 2018-10-09 14:42:54 -05:00
Paul Pacheco
6a80f77e6d
fix list indentation 2018-10-09 14:20:36 -05:00
Paul Pacheco
216504a78c Clientscene is a static class (#59) 2018-10-09 19:56:04 +02:00
Paul Pacheco
4b2ab9b3d6 Remove redundant return 2018-10-09 11:11:07 -05:00
Paul Pacheco
6bbe38bbca Remove redundant return 2018-10-09 10:53:39 -05:00
Paul Pacheco
c1a68792c9 Ensure writer is initialized only once 2018-10-09 10:47:36 -05:00
Paul Pacheco
95b6e9fc12 Removed unused code 2018-10-09 10:39:00 -05:00
Paul Pacheco
95972329af Simplify validation 2018-10-09 10:33:12 -05:00
Paul Pacheco
c590b89836 Dont assign in conditional, it is confusing 2018-10-09 10:30:31 -05:00
Paul Pacheco
738baf2cad Remove redundant initializations 2018-10-09 10:22:55 -05:00
vis2k
277f18280e Added comments for OnRebuildObservers return value and adjusted NetworkProximityChecker to make this less weird. 2018-10-09 10:59:21 +02:00
Paul Pacheco
3f9a423258 writer should be private, directy accessing it can corrupt the message 2018-10-08 10:39:50 -05:00
Paul Pacheco
f608d0e540 underlying list should not be initialized more than once 2018-10-08 10:24:16 -05:00
Paul Pacheco
a1a46813e1 local objects is readonly, we never assign it again 2018-10-08 10:22:22 -05:00
Paul Pacheco
69fc6091b1 Introduce new variable instead of reusing parameter r 2018-10-08 10:20:21 -05:00
Paul Pacheco
14c6a354d1
fix atx-closed heading 2018-10-08 10:16:15 -05:00
Paul Pacheco
1f3ce14185
Fix list indentation 2018-10-08 10:14:28 -05:00