Commit Graph

7548 Commits

Author SHA1 Message Date
MrGadget1024
b642da6b2f fix: Fix #3349 - NetworkTransformReliable use correct value in OnSerialize
- Fixes #3349
2023-01-09 09:41:19 -05:00
MrGadget
3e52ef0deb
Fix CI (#3348)
* Update activation.ylm

* Added Semantic.yml

* Added SonarQube.yml

* Updated main.yml

* Updated main.yml

* SonarQube - container fixed

* main.yml - disabled SonarQube for now
- That's going to need a bit more work.
2023-01-09 12:14:04 +01:00
vis2k
2c9f6c4960 fix: kcp2k V1.27. fixes #3337 2023-01-08 11:51:50 +01:00
MrGadget1024
c93935422e Check for no Camera.main in OnGUI
- avoids NRE flood if no camera with MainCamera tag.
2023-01-06 18:50:13 -05:00
mischa
3c85efa2d9
fix: #3330 #2422 SpawnObjects now activates, but does not spawn scene objects with inactive parents (#3347)
* fix: #3330 #2422 SpawnObjects now activates, but does not spawn scene objects with inactive parents

* helper function

* remove old workaround.
identities which aren't active in hierarchy don't have Awake called forcefully anymore.
it's not necessary because the second pass won't spawn them anymore.

* add comments
2023-01-06 18:21:03 +01:00
vis2k
c9dfd95bb7 add comment 2023-01-06 17:40:57 +01:00
vis2k
7b7ad85204 fix: #3340 SyncSet/Dictionary callbacks are only called once 2023-01-05 21:54:53 +01:00
vis2k
c5aa4746e1 fix: #3340 SyncList callbacks are only called once 2023-01-05 21:21:51 +01:00
vis2k
0d53f7c3a0 fix: #3343 allow modifying client synclists for unspawned objects like character previews 2023-01-04 01:32:11 +01:00
vis2k
8570afab94 fix: #3341 SyncLists can now be modified before spawning again 2023-01-04 01:10:53 +01:00
vis2k
02218bda13 fix: #3342 InitSyncObject IsWritable/IsRecording permissions fixed for host mode and other player's objects on client 2023-01-04 01:10:51 +01:00
vis2k
d645aad95c fix: forgot to remove SyncList OnSerializeAll log message 2023-01-04 01:02:47 +01:00
MrGadget1024
34f6df24a1 NetworkClient - moved RegisterMessageHandlers down 2023-01-03 15:41:01 -05:00
MrGadget
273f91088f
fix: #3326 NetworkIdentity doesn't reset SyncObjects anymore (#3339)
* Fixes: #3326
- All callers to Reset are either unspawning (disabling) the object or have run a custom UnSpawnHandler
- Sync collections should retain their data in any case because the object may get respawned
- When it is respawned, OnDeserializeAll clears the internal collection and changes lists before adding back the entire payload.
- Users can always call the public Reset on the SyncObject themselves if they want it wiped.

* fixed comment
2023-01-03 09:59:36 +01:00
MrGadget1024
30ec858551 NetworkClient - formatting 2023-01-02 12:50:41 -05:00
MrGadget1024
0189b7f45e NetworkServer - formatting 2023-01-02 12:49:53 -05:00
MrGadget1024
1f09c7f98d NetworkIdentity - formatting 2023-01-02 12:49:04 -05:00
MrGadget1024
ed102ffb23 NetworkIdentity - moved SetClientOwner down with AssignClientAuthority
- AssignClientAuthority is the only caller in this class
2023-01-02 12:28:58 -05:00
MrGadget1024
9405e9fef6 NetworkIdentity - moved ResetStatics up 2023-01-02 12:26:53 -05:00
MrGadget1024
bc28022552 NetworkIdentity - moved HandleRemoteCall up
- Nothing in NetworkIdentity calls this, only external callers
2023-01-02 12:24:20 -05:00
MrGadget1024
de421cdc1f NetworkIdentity - moved ClearDirtyBits methods up to their respective callers 2023-01-02 12:21:08 -05:00
MrGadget1024
c0e047b01a NetworkClient - moved NotifyAuthority and 2 related others down below Reset 2023-01-02 12:13:59 -05:00
MrGadget1024
d71c9e2a77 NetworkIdentity - moved ClearObservers down below Reset 2023-01-02 12:09:15 -05:00
MrGadget1024
82ff8fddf7 NetworkClient - moved DestroyObject down 2023-01-02 11:15:13 -05:00
MrGadget1024
3616ad818b NetworkServer - moved obsoletes
- localClientActive to above active
- ActivateHostScene to bottom out of the way
2023-01-02 09:53:01 -05:00
MrGadget1024
ce7706b5a0 NetworkServer - moved RemoveTransportHandlers up 2023-01-02 09:42:46 -05:00
MrGadget1024
ed8baffc6c NetworkServer - moved Listent and Shutdown up 2023-01-02 09:40:43 -05:00
MrGadget1024
2943aff578 NetworkServer - moved RebuildObserversCustom down 2023-01-02 09:33:52 -05:00
MrGadget1024
c4b919b7bc NetworkServer - moved AddAllReadyServerConnectionsToObservers down 2023-01-02 09:32:41 -05:00
MrGadget1024
5f455245ee NetworkServer - moved message handers up with RegisterMessageHandlers 2023-01-02 09:22:49 -05:00
MrGadget1024
ecfa4dd26e NetworkServer - Organized spawn methods to call order 2023-01-02 09:10:14 -05:00
MrGadget1024
a25502f82d NetworkServer - put AddPlayerForConnection methods in call order
- moved RemovePlayerForConnection up
2023-01-02 08:57:29 -05:00
MrGadget1024
051b63caee NetworkServer - put Destroy methods together in call order 2023-01-02 08:54:08 -05:00
MrGadget1024
1f87ebdf45 NetworkClient - Moved Destroy method down
- put it with DestroyAllClientObjects
- preparing for consolidation
2023-01-02 07:12:21 -05:00
MrGadget
77a4ad9674
breaking: Removed Old Obsoletes (#3335)
- Also normalized Deprecatd comments for easier searching
2023-01-01 18:37:49 +01:00
MrGadget
c364d194fe
fix: #3334 NetworkClient DestroyAllClientObjects Before ClearSpawners (#3336)
* fix: NetworkClient DestroyAllClientObjects Before ClearSpawners
- DestroyAllClientObjects needs to be able to call Unspawn handlers
- Fixes: 3334

* Update Assets/Mirror/Core/NetworkClient.cs

Co-authored-by: mischa <16416509+vis2k@users.noreply.github.com>
2023-01-01 18:22:02 +01:00
MrGadget1024
4deb179d62 PreprocessorDefine - fixed typo in comment 2022-12-31 10:32:41 -05:00
MrGadget1024
ff461331d4 PreprocessorDefine - added 12 months comment 2022-12-31 10:29:48 -05:00
MrGadget1024
9df0b0f143 Define symbols for Server, Standalone, WebGL platforms 2022-12-31 10:27:36 -05:00
MrGadget1024
97547a285c Culled compiler symbols to last 12 months
- Going forward, we need to remove oldest when we add new one each month when we publish to the store, so we only keep them back 12 months.
2022-12-31 10:19:16 -05:00
vis2k
642423aef8 MIRROR_71_0_OR_NEWER 2022-12-31 14:44:09 +01:00
vis2k
ca9f07d812 fix: #3329 NetworkTransform UpdateServer checks if .connectionToClient is null to support room demo / scene changes 2022-12-31 14:36:57 +01:00
vis2k
6581300ce0 remove unused imports 2022-12-31 14:34:28 +01:00
MrGadget
993caf3b36
NetworkClient - Use TryGetComponent (#3331)
This eliminates allocations, at least in the editor, per Unity docs.
2022-12-31 13:59:57 +01:00
MrGadget
82a7e752a8
Use TryGetComponent (#3332)
This eliminates allocations, at least in the editor, per Unity docs.
2022-12-31 13:59:42 +01:00
MrGadget
fe4aa931e1
feat: NetManHUD StopClient button for Host (#3333) 2022-12-31 13:59:12 +01:00
MrGadget1024
be5cd6472a fix: set offline mode before OnStopClient
- Prevents StopClient from running more than once
- Fixes: #2080
2022-12-30 22:03:53 -05:00
mischa
739ef7ccc0
fix: #2240 #3324 NetworkIdentity.OnDestroy removes from spawned if not removed yet. prevents null entries in .spawned. (#3327)
* fix: #2240 #3324 NetworkIdentity.OnDestroy removes from spawned if not removed yet.
prevents null entries in .spawned.

* Update Assets/Mirror/Core/NetworkIdentity.cs

Co-authored-by: MrGadget <9826063+MrGadget1024@users.noreply.github.com>

Co-authored-by: MrGadget <9826063+MrGadget1024@users.noreply.github.com>
2022-12-30 22:38:16 +01:00
mischa
e95c9ae9a7
fix: #3318 NetworkServer.SpawnObjects only spawns objects which haven't been spawned yet. (#3328)
additive scene loading would call SpawnObjects again, which would attempt to spawn _all_ previously spawned objects _and_ the newly loaded ones.
2022-12-30 21:45:51 +01:00
MrGadget1024
1746468bef Removed unnecessary check 2022-12-30 15:32:46 -05:00