charleslemaux/Mirror
1
0
Fork 0
mirror of https://github.com/MirrorNetworking/Mirror.git synced 2024-11-18 11:00:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix sonarqube null warning

Browse Source 
Once upon a time, connections could be null here.  This is no longer
the case, connections always have something,

Even if they were null,  this method would not work at all because
the conn.Send call at the bottom would throw NRE.

Therefore the null checks here are unnecesary
This commit is contained in:
Paul Pacheco 2020-03-20 07:58:46 -05:00
parent 57eff86e3f
commit 59687675c9
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Assets/Mirror/Runtime/NetworkServer.cs
View File

@ -940,8 +940,8 @@ internal static void SendSpawnMessage(NetworkIdentity identity, NetworkConnectio
SpawnMessage msg = new SpawnMessage SpawnMessage msg = new SpawnMessage
{ {
netId = identity.netId, netId = identity.netId,
isLocalPlayer = conn?.identity == identity, isLocalPlayer = conn.identity == identity,
isOwner = identity.connectionToClient == conn && conn != null, isOwner = identity.connectionToClient == conn,
sceneId = identity.sceneId, sceneId = identity.sceneId,
assetId = identity.assetId, assetId = identity.assetId,
// use local values for VR support // use local values for VR support