charleslemaux/Mirror
1
0
Fork 0
mirror of https://github.com/MirrorNetworking/Mirror.git synced 2024-11-18 11:00:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

CompilationFinishedHook: Mirror.Runtime.dll is not found via recursive directory search in case someone moves the folder somewhere else

Browse Source
This commit is contained in:
vis2k 2018-08-27 10:17:27 +02:00
parent 4d1d9c6ea3
commit bbadf972ed
1 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
Mirror/Weaver/CompilationFinishedHook.cs
View File

@ -36,7 +36,7 @@ static CompilationFinishedHook()
string mirrorRuntimeDll = FindMirrorRuntime();
if (!File.Exists(mirrorRuntimeDll))
{
Debug.LogError("Could not find Mirror runtime, make sure the file " + mirrorRuntimeDll + " is in your project");
Debug.LogError("Could not find Mirror.Runtime.dll, make sure the file is in your project");
return;
}
@ -64,16 +64,22 @@ static CompilationFinishedHook()
Debug.LogError("Weaving failed for: " + assemblyPath);
}
};
}
private static string FindMirrorRuntime()
{
string path = Path.Combine("Assets", "Plugins");
path = Path.Combine(path, "Mirror.Runtime.dll");
return path;
// we can't assume that Mirror.Runtime.dll is always at the same
// path, because some people might move the 'Mirror' folder into
// another folder, etc.
// -> can't check loaded assemblies/assets because this happens
// after compiling, before load
// -> search assets folder instead and cache result
// -> we have Runtime and Runtime-Editor dll. it doesn't matter
// which one we use, so let's always use the one that is found
// first
// -> should always find exactly 2 runtime dlls
string[] files = Directory.GetFiles("Assets", "Mirror.Runtime.dll", SearchOption.AllDirectories);
return files.Length > 0 ? files[0] : "";
}
}
}