vis2k
4ba456439a
NetworkIdentity.RebuildObservers: improve comments to explain what happens
2020-03-04 13:15:56 +01:00
vis2k
dbfd1830d3
NetworkIdentity.RebuildObservers: syntax improved
2020-03-04 13:14:26 +01:00
vis2k
1133fe4e25
forgot to remove comment
2020-03-04 09:23:23 +01:00
vis2k
8e6f5ba89c
NetworkIdentityTests: RebuildObserversDoesNotAddServerConnectionsIfImplemented
2020-03-04 09:22:04 +01:00
vis2k
9c09c26a5c
fix: SendToObservers missing result variable
2020-03-04 09:20:28 +01:00
vis2k
66d858e631
NetworkIdentityTests: RebuildObserversAddsReadyServerConnectionsIfNotImplemented
2020-03-04 09:17:47 +01:00
Paul Pacheco
9c81c9b2eb
refactor: SendToObserver returns void ( #1539 )
...
We calculate a bool out of SendToObserver, but it is not clear what it is
and we don't use the result at all. So just simplify things.
2020-03-04 08:52:17 +01:00
vis2k
549c729a07
NetworkIdentityTests: AddAllReadyServerConnectionsToObservers
2020-03-03 23:43:20 +01:00
vis2k
a5602011dd
rename to be 100% obvious
2020-03-03 23:31:44 +01:00
vis2k
66d3e8ddf7
NetworkIdentity.RebuildObservers code split into AddAllServerConnectionsToObservers helper function
2020-03-03 23:29:47 +01:00
vis2k
d6a93275f9
NetworkIdentity.RebuildObservers: result renamed to rebuildOverwritten because that's what it's for
2020-03-03 23:22:49 +01:00
vis2k
6eedd2405c
NetworkIdentity.GetNewObservers: result renamed to rebuildOverwritten because that's what it's for
2020-03-03 23:22:37 +01:00
vis2k
15a47ca19c
NetworkIdentityTests: RebuildObserversOnlyAddsOwnPlayerIfReady
2020-03-03 23:05:41 +01:00
vis2k
3e8c6089b0
NetworkIdentityTests: RebuildObserversAddsOwnReadyPlayer
2020-03-03 23:05:41 +01:00
Paul Pacheco
60226797ac
tests: Fix tests
...
CI/CD pipeline runs in headless mode, so this check is invalid
2020-03-03 15:43:25 -06:00
Paul Pacheco
108c83a43a
refactor: use NUnit idiomatic constraints
...
Why?
Suppose you have this:
```cs
Assert.That(manager.networkAddress == "localhost");
```
and suppose it fails, it will give you:
"Expected True, but got False"
which does not give you anything useful.
Suppose you have this instead:
```cs
Assert.That(manager.networkAddress, Is.EqualTo("localhost"));
```
Suppose it fails, now it will give you a much more useful error message:
"Expected 'localhost' but got 'xxxxx'"
It makes debugging tests a lot easier.
2020-03-03 15:39:25 -06:00
vis2k
fb9c55bf6e
NetworkIdentityTests cleaned up
2020-03-03 22:37:13 +01:00
vis2k
b2a094930f
syntax
2020-03-03 22:27:27 +01:00
vis2k
a302306dd1
NetworkIdentityTests: GetNewObserversFalseIfNoComponents test
2020-03-03 22:24:13 +01:00
vis2k
102484b811
NetworkIdentityTests: GetNewObserversClearsHashSet test
2020-03-03 22:24:13 +01:00
vis2k
260ca9a491
NetworkIdentityTests: GetNewObservers test
2020-03-03 22:24:13 +01:00
vis2k
01f5fb4a94
NetworkIdentity.RebuildObservers: GetNewObservers code split into separate function
2020-03-03 22:24:13 +01:00
Paul Pacheco
e00e8195bb
Simplify
2020-03-03 10:40:57 -06:00
vis2k
4bc1c3eb20
NetworkIdentityTests HandleEvent tests invalid component index / function hash too
2020-03-03 13:19:09 +01:00
vis2k
bbcc3599ef
NetworkIdentityTests HandleRpc tests invalid component index / function hash too
2020-03-03 13:19:03 +01:00
vis2k
b9dab2ca7a
NetworkIdentityTests HandleCommand tests invalid component index / function hash too
2020-03-03 13:18:55 +01:00
vis2k
ea54890dca
NetworkIdentityTests: HandleCommand/Rpc/SyncEvent tests improved
2020-03-03 13:15:54 +01:00
vis2k
6cdb9a3d8b
NetworkIdentityTests: HandleSyncEvent
2020-03-03 13:08:58 +01:00
vis2k
0f362ec1cf
NetworkIdentityTests: HandleRPC
2020-03-03 13:06:20 +01:00
vis2k
598766764c
typo
2020-03-03 13:03:25 +01:00
vis2k
0b257fbd3a
NetworkIdentityTests: HandleCommand
2020-03-03 13:02:44 +01:00
vis2k
bd9747e735
NetworkReader/WriterTest: benchmark doesn't need to run each time, takes at least 6s together.
2020-03-03 12:15:07 +01:00
uwee
67462553fb
test add NetworkManagerTests ( #1537 )
...
* test add NetworkManagerTests
not complete and 1 does not reliably work
* fix broken client test
* remove incomplete test for NG
* added more state checking
* shutdown state test
* add startposition tests
2020-03-03 09:28:28 +01:00
Lymdun
ca166bd95f
Improve LocalConnectionTest ( #1538 )
2020-03-02 22:41:27 +01:00
vis2k
e9d4f04da5
typo
2020-03-02 15:55:01 +01:00
vis2k
7df6e79b61
NetworkIdentityTests: AssignAndRemoveClientAuthority improved
2020-03-02 15:54:47 +01:00
vis2k
4b6affb523
NetworkIdentityTests: AssignAndRemoveClientAuthority test improved
2020-03-02 15:50:32 +01:00
vis2k
eb958ae182
NetworkIdentity.AssignClientAuthority: null check first. more obvious error message and easier to test.
2020-03-02 15:50:13 +01:00
vis2k
66a9127b96
NetworkIdentityTests: AssignAndRemoveClientAuthority
2020-03-02 15:40:26 +01:00
vis2k
9c8d6f3cb1
NetworkIdentityTests: ServerUpdate
2020-03-02 13:28:10 +01:00
vis2k
97a5a1211d
add comment
2020-03-02 12:13:23 +01:00
vis2k
b787274732
forgot to save
2020-03-02 12:07:56 +01:00
vis2k
5a1bfdf1a4
NetworkIdentity.MirrorUpdate renamed to ServerUpdate because that's what it does
2020-03-02 12:06:12 +01:00
vis2k
de4a7107a6
NetworkIdentityTests: Reset
2020-03-02 11:44:36 +01:00
vis2k
e43ed3e09d
NetworkIdentityTests: ClearAllComponentsDirtyBits
2020-03-02 11:14:27 +01:00
vis2k
f9fdca3598
NetworkIdentityTests: ClearDirtyComponentsDirtyBits test improved
2020-03-02 11:09:16 +01:00
vis2k
eac93e1a27
NetworkIdentityTests: ClearDirtyComponentsDirtyBits
2020-03-02 11:07:07 +01:00
uwee
df430e1bfc
Test coverage for NetworkTransformChild ( #1536 )
...
* Test coverage for NetworkTransformChild
* add missing meta file
* applied codacy suggestions
2020-03-02 09:44:39 +01:00
uwee
05a44b9c6f
adds missing addplayertest ( #1530 )
...
* adds missing addplayertest
code is set to depreciate but should still be covered until then.
* remove json file from commit
opps
* updated to include suggestions from Codacy
2020-03-02 09:43:10 +01:00
Paul Pacheco
22636c9a6c
Disable telepathy tests until they are fixed ( #1534 )
2020-03-02 09:40:04 +01:00
vis2k
65645dd266
NetworkIdentity: AssignClientAuthority moved above RemoveClientAuthority
2020-03-01 12:05:46 +01:00
vis2k
508e253bb1
NetworkIdentityTests: AddObserver
2020-03-01 12:02:25 +01:00
vis2k
8cd50cf9f2
NetworkIdentityTests: make sure that calling OnStartClient twice will return early
2020-03-01 11:54:23 +01:00
vis2k
90cece63dc
NetworkIdentityTests: ClearObservers
2020-03-01 11:54:02 +01:00
vis2k
d9036a6a79
CustomAttributeTests: use channels enum
2020-03-01 11:41:25 +01:00
uwee
b440130647
adds test coverage for CustomAttribute ( #1531 )
2020-03-01 11:13:48 +01:00
vis2k
3bc38d8938
copy paste error
2020-02-28 16:56:38 +01:00
vis2k
4357752f91
NetworkIdentityTests: OnNetworkDestroy
2020-02-28 16:55:22 +01:00
vis2k
6b35bf0133
NetworkIdentity.OnNetworkDestroy moved upwards and catches exceptions now too
2020-02-28 16:55:14 +01:00
vis2k
62c5cf4b14
fix error log
2020-02-28 16:54:55 +01:00
vis2k
5ed5f84409
fix: NetworkIdentity.OnStartLocalPlayer catches exceptions now too. fixes a potential bug where an exception in PlayerInventory.OnStartLocalPlayer would cause PlayerEquipment.OnStartLocalPlayer to not be called
2020-02-28 16:33:59 +01:00
vis2k
4926bb818a
add comments
2020-02-28 16:32:48 +01:00
vis2k
fc7d2e8df6
NetworkIdentity: OnStartLocalPlayer moved next to OnStartClient
2020-02-28 16:31:39 +01:00
vis2k
1c356bff44
NetworkIdentity: remove redundant OnUpdateVars function
2020-02-28 16:26:05 +01:00
vis2k
782848094b
NetworkIdentityTests: OnStartLocalPlayer
2020-02-28 16:23:14 +01:00
vis2k
bbaad910f7
NetworkIdentityTests: OnDeserializeSafelyShouldDetectAndHandleDeSerializationMismatch
2020-02-28 16:10:48 +01:00
vis2k
fe7c1c7f50
improve previous test
2020-02-28 15:43:01 +01:00
vis2k
0df42ebf75
NetworkIdentityTests: OnSerializeAllSafelyShouldDetectTooManyComponents
2020-02-28 15:41:34 +01:00
vis2k
bfe09ab141
NetworkIdentityTests: OnSerializeAndDeserializeAllSafely
2020-02-28 15:35:37 +01:00
vis2k
a5269b4261
NetworkIdentityTests: OnCheckObserver
2020-02-28 11:58:51 +01:00
vis2k
f21b80b8b0
NetworkIdentityTests: OnSetHostVisibilityCallsComponentsAndCatchesExceptions
2020-02-27 10:23:44 +01:00
vis2k
cd4e39729e
NetworkIdentityTests: NotifyAuthorityCallsOnStartStopAuthority
2020-02-27 10:19:16 +01:00
vis2k
44addfa336
NetworkIdentityTests: rename
2020-02-27 10:10:54 +01:00
vis2k
47b1aa7400
NetworkIdentityTests: OnStopAuthorityComponentExceptionIsCaught
2020-02-27 10:10:07 +01:00
vis2k
b62487cf87
NetworkIdentity.OnStopAuthority made internal for consistency with OnStartServer/OnStartClient, and so that we can test it
2020-02-27 10:08:45 +01:00
vis2k
e87c1d6a26
add comments
2020-02-27 10:08:36 +01:00
vis2k
85aae6482d
NetworkIdentityTests: OnStartAuthorityComponentExceptionIsCaught
2020-02-27 10:06:56 +01:00
vis2k
0965283c53
NetworkIdentity.OnStartAuthority made internal for consistency with OnStartServer/OnStartClient, and so that we can test it
2020-02-27 10:06:46 +01:00
vis2k
6183cae611
NetworkIdentityTests: OnStartClient test makes sure that OnStartClient was called exactly once
2020-02-27 10:05:07 +01:00
vis2k
f6c8e0e89e
NetworkIdentityTests: OnStartServer test makes sure that OnStartServer was called exactly once
2020-02-27 10:04:58 +01:00
vis2k
617bd0a175
NetworkIdentity.OnStartClient: added comment
2020-02-27 09:53:24 +01:00
vis2k
53499f031f
NetworkIdentityTests: OnStartClientComponentExceptionIsCaught
2020-02-27 09:53:24 +01:00
Paul Pacheco
59faa81926
fix: build in IL2CPP ( #1524 )
...
The weaver generated code now builds properly under IL2CPP
fixes #1519
fixes #1520
2020-02-26 18:02:14 -06:00
vis2k
ae451e6fe0
NetworkIdentityTests: OnStartServerInHostModeSetsIsClientTrue to make sure that isClient is true in OnStartServer if in host mode. we fixed the bug recently, now we have a test too
2020-02-26 22:08:47 +01:00
vis2k
6f3c286a62
Tests: MemoryTransport for easier testing
2020-02-26 21:56:55 +01:00
vis2k
89859c9fd4
NetworkIdentityTests: OnStartServerComponentExceptionIsCaught
2020-02-26 20:01:21 +01:00
vis2k
1b624f12e0
add comment
2020-02-26 19:55:27 +01:00
vis2k
42c0128f18
NetworkIdentityTests: OnValidateSetupIDsSetsEmptyAssetIDForSceneObject
2020-02-26 19:42:01 +01:00
vis2k
a0f798f65f
NetworkIdentityTests: SetSceneIdSceneHashPartInternal
2020-02-26 19:34:35 +01:00
vis2k
12d2c68301
NetworkIdentityTest: make sure that it's added to sceneId dict too
2020-02-26 19:25:20 +01:00
vis2k
8ca4deb61d
NetworkIdentityTests: AssignSceneID
2020-02-26 19:23:32 +01:00
vis2k
4b430d98f7
NetworkIdentityTests: RemoveObserverInternal
2020-02-26 19:12:34 +01:00
vis2k
4d2c81e12e
NetworkIdentityTests: SetClientOwner test to make sure the previous commit's bug doesn't happen again
2020-02-26 18:30:55 +01:00
vis2k
548db52fdf
fix: NetworkIdentity.SetClientOwner: overwriting the owner was still possible even though it shouldn't be. all caller functions double check and return early if it already has an owner, so we should do the same here.
2020-02-26 18:30:30 +01:00
vis2k
1a9625ee4a
NetworkIdentity.SetClientOwner: improve error message
2020-02-26 18:28:57 +01:00
vis2k
4269cfe43c
NetworkIdentityTests: cleanup spawned dict too
2020-02-26 18:19:11 +01:00
vis2k
ebe12b6cdb
NetworkIdentityTest: GetSetAssetId
2020-02-26 18:15:14 +01:00
vis2k
22ee387470
NetworkIdentityTests: proper GameObject cleanup
2020-02-26 18:12:45 +01:00
vis2k
66776a744d
NetworkServer.UnSpawn test
2020-02-26 17:40:07 +01:00
vis2k
29fe487954
NetworkIdentity.IsMarkedForReset helper function to check reset state
2020-02-26 17:39:57 +01:00
vis2k
8a05826ca4
NetworkServerTest.SpawnObject: make sure that it doesn't touch non-scene-objects
2020-02-26 17:30:19 +01:00
vis2k
708d7838d6
NetworkServerTest: SpawnObjects
2020-02-26 17:20:35 +01:00
vis2k
d4d524dad2
fix: NetworkServer.SpawnObjects: return false if server isn't running
2020-02-26 17:16:38 +01:00
vis2k
cdfc1752f2
NetworkServerTest: ValidateSceneObject
2020-02-26 17:08:36 +01:00
vis2k
e409ed8f48
NetworkServer.ValidateSceneObject made internal so it can be tested and reused if needed
2020-02-26 17:01:31 +01:00
vis2k
1be758b12b
syntax
2020-02-26 17:01:10 +01:00
vis2k
c8fbea387d
update comment
2020-02-26 16:57:09 +01:00
vis2k
bba4ebd154
NetworkServerTest: CommandTest tries invalid netid and command without authority too
2020-02-26 10:27:36 +01:00
vis2k
038e3c1969
NetworkServerTest: HideForConnection
2020-02-26 10:14:42 +01:00
vis2k
9bdfb676e3
NetworkServerTest: ShowForConnection
2020-02-26 10:11:00 +01:00
vis2k
5cdf02b258
NetworkServerTest: GetNetworkIdentity
2020-02-25 22:25:47 +01:00
vis2k
67a2a85cb9
NetworkServer.GetNetworkIdentity made internal so it can be tested and reused in other places if needed
2020-02-25 22:25:39 +01:00
vis2k
e7c9dc4f6e
NetworkServerTest: SendToClientOfPlayer
2020-02-25 22:13:58 +01:00
vis2k
c2afc05692
NetworkServerTest: RegisterUnregisterClearHandlerTest
2020-02-25 22:07:44 +01:00
vis2k
212af3fc9d
NetworkServerTest: RegisterHandlerTest
2020-02-25 22:01:48 +01:00
vis2k
d4f21c0818
remove unused var
2020-02-25 11:53:04 +01:00
vis2k
48bdc68906
NetworkServerTest: SendToAllTest
2020-02-25 11:35:15 +01:00
vis2k
4596b19dd9
fix: SendToReady sends to that exact connection if it is detected as local connection, instead of falling back to the .localConnection field which might be something completely different.
2020-02-25 11:14:26 +01:00
vis2k
4b90aafe12
fix: SendToAll sends to that exact connection if it is detected as local connection, instead of falling back to the .localConnection field which might be something completely different.
2020-02-25 11:13:59 +01:00
vis2k
4267983139
fix: SendToObservers sends to that exact connection if it is detected as local connection, instead of falling back to the .localConnection field which might be something completely different.
2020-02-25 11:13:38 +01:00
vis2k
a497803de0
NetworkServerTests: use call counts instead of bools to make sure that it's called exactly once
2020-02-25 11:00:35 +01:00
vis2k
69bb1574f0
NetworkServerTest: ActivateHostSceneCallsOnStartClient
2020-02-25 10:36:40 +01:00
vis2k
f378333000
NetworkServer.ActivateLocalClientScene renamed to ActivateHostScene because that's what it really does. It does NOT do something for every local client on a client. Only for a host.
2020-02-25 10:31:30 +01:00
vis2k
5efaa4af1a
CommandMessageCallsCommandTest: use two components to make sure that the correct one is used by the command
2020-02-24 15:44:05 +01:00
vis2k
1315bd3dde
CommandMessageCallsCommandTest: proper usage of weaver generated command code (static!)
2020-02-24 15:40:06 +01:00
vis2k
6d2b4eb102
remove comment
2020-02-24 15:37:31 +01:00
vis2k
e6b12133d1
remove comment
2020-02-24 15:35:46 +01:00
vis2k
3eb1e8968c
add comment
2020-02-24 15:35:16 +01:00
vis2k
02c31d0805
NetworkServerTest: CommandMessageCallsCommandTest to run a full command through our pipeline
2020-02-24 15:31:53 +01:00
vis2k
e9c6f6f2a9
NetworkBehaviour.GetMethodHash made internal for tests
2020-02-24 15:31:53 +01:00
vis2k
e6cd2e2280
NetworkBehaviour.RegisterRpc/Command/EventDelegate made public for tests. internal won't work because they are called from outside assemblies like NetworkTransform. protected won't work because then we can't test them from the outside.
2020-02-24 15:31:53 +01:00
vis2k
31af385a70
NetworkBehaviour.ClearDelegates added for tests
2020-02-24 15:31:53 +01:00
vis2k
215e973903
NetworkServerTest: ReadyMessageSetsClientReadyTest
2020-02-24 14:46:58 +01:00
vis2k
dc29106370
NetworkServerTest.TearDown rests state
2020-02-24 14:32:41 +01:00
vis2k
ea0b20636b
NetworkServerTest: SetAllClientsNotReadyTest
2020-02-24 14:31:30 +01:00
vis2k
012c053597
NetworkServerTest: SetClientReadyAndNotReadyTest
2020-02-24 11:26:19 +01:00
vis2k
3bd947a973
NetworkServerTest: OnDataReceivedInvalidConnectionIdTest
2020-02-24 11:17:53 +01:00
vis2k
e49f4e0aff
NetworkServerTest: OnDataReceivedTest
2020-02-24 11:14:11 +01:00
vis2k
ad0d20144a
NetworkServerTests: ConnectDuplicateConnectionIdsTest
2020-02-24 10:51:04 +01:00
vis2k
9c325abbd8
NetworkServerTests: OnConnectedOnlyAllowsGreaterZeroConnectionIdsTest
2020-02-24 10:48:39 +01:00
vis2k
47a4ac7ff7
NetworkServerTest: SetLocalConnectionTest checks overwrite too
2020-02-24 10:43:19 +01:00
Paul Pacheco
f0a993c106
fix: properly detect NT rotation ( #1516 )
2020-02-23 20:46:06 +01:00
MrGadget
8417465413
Make StartHost Not virtual ( #1513 )
2020-02-23 14:40:06 +01:00
vis2k
1cce3164b9
NetworkServerTest: DisconnectAllTest
2020-02-23 11:43:08 +01:00
vis2k
357ad0ffb6
add comment
2020-02-23 11:40:47 +01:00
vis2k
a57a46764e
NetworkServerTest: DisconnectAllConnectionsTest
2020-02-23 11:40:01 +01:00
vis2k
fe1b158b22
NetworkServerTest: RemoveLocalConnectionTest
2020-02-23 11:36:14 +01:00
vis2k
ad0442be02
NetworkServerTest: RemoveConenctionTest
2020-02-23 11:30:58 +01:00
vis2k
8b16c7c343
NetworkServerTest: AddConnectionTest tests duplicate too
2020-02-23 11:29:08 +01:00
vis2k
12faf65d18
NetworkServerTest: AddConnectionTest
2020-02-23 11:25:20 +01:00
