charleslemaux/Mirror
1
0
Fork 0
mirror of https://github.com/MirrorNetworking/Mirror.git synced 2024-11-18 11:00:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
1,614 Commits 189 Branches 1,882 Tags 486 MiB
40d2ec54e5
Commit Graph

558 Commits

Author SHA1 Message Date
rodolphito
40d2ec54e5 This method seems pretty redundant, could just be called directly. (#677) 2019-03-27 13:06:42 -05:00
MrGadget
49f39f9c09 Updated Obsolete comment and code to remove singleton (#661) 
* Updated Obsolete comment and code to remove singleton

* Update NetworkClient.cs

* Update NetworkClient.cs

* Update NetworkClient.cs
 2019-03-27 15:13:25 +01:00
rodolphito
1feff9d749 Removed useless comment. (#676) 2019-03-27 13:56:59 +01:00
rodolphito
6edfd3ddf1 Removed more internals. (#673) 2019-03-27 13:37:12 +01:00
rodolphito
ba298c74b0 Style guidelines say these are bad. (#672) 2019-03-27 13:20:36 +01:00
rodolphito
57066a6003 These can be private. (#669) 2019-03-27 13:13:27 +01:00
rodolphito
4897edd76a More internal access modifier removals (#671) 2019-03-27 13:13:11 +01:00
rodolphito
9be7426efa Remove s_ prefix because the entire class is static, the prefix doesnt actually specify anything. (#668) 2019-03-27 12:04:07 +01:00
rodolphito
86c1942310 Remove s_ prefix because the entire class is static, the prefix doesnt actually specify anything. (#667) 2019-03-27 12:03:37 +01:00
rodolphito
595039865f Removed duplicated address storage. (#664) 
* Removed duplicated address storage.

* Removed the obsoletion as per vis' request.
 2019-03-27 10:27:41 +01:00
rodolphito
c289ffb440 Remove proxy methods for setting playerController. (#665) 
* Deprecate proxy methods for setting playerController.

* shortened obsoleted methods.

* This isnt actually public facing, its internal. Obsoletion is unnecessary, plain removal is ok.
 2019-03-27 10:26:45 +01:00
uwee
f4cdfbf952 Remove IsClientConnected (#663) 
* remove IsClientConnected

no longer needed now that NetworkClient is static

* removed in other scripts also

* marked as obsolete
 2019-03-27 09:15:03 +01:00
MrGadget
d7306986b6 Updated Lobby Example Scenes Lighting (#662) 2019-03-26 17:49:56 +01:00
MrGadget
d2868646fa SyncVar Updates (#660) 
* Change SyncVar hooks to use `nameof`
I intentionally left the test for missing hook as a literal string because it won't compile otherwise.

* Removed unnecessary property value set from hook
 2019-03-26 15:40:28 +01:00
uwee
68f63b5f69 bool InActiveScene not referenced in any script? (#656) 
* code is not referenced in any script?

* fully remove code
 2019-03-26 13:58:05 +01:00
Paul Pacheco
2d63ee1318
fix: Set syncvar variables after calling the hook (#659) 
Previously, during deserialize,  Mirror either called the hook for a syncvar or it set the variable, but never both. So users had to set the variable inside the hook.

```cs
class Player : NetworkBehaviour {

	[SyncVar(hook=nameof(OnVarChanged))]
	public int myvar;

	public void OnVarChanged(int newvalue) {

		Debug.Log("Got new value " + newvalue);
		Debug.Log("Old value is " + myvar);

		// with this pull request the following line is no longer needed
		// the weaver will do this after the hook finishes
		// this.myvar = newvalue;
	}
}
```

fix: Hook not working with NetworkIdentity or GameObjects

Deserializing NetworkIdentity or GameObjects was broken, it called the hook only if there was no hook,  and it saved the variable only if there was a hook.
 2019-03-26 07:15:25 -05:00
Paul Pacheco
4d74f555b1 Update Assets/Mirror/Runtime/NetworkClient.cs 
Co-Authored-By: vis2k <info@noobtuts.com>
 2019-03-26 12:16:57 +01:00
vis2k
1879f5ecdc Add [Obsolete] for compatibility 2019-03-26 12:16:57 +01:00
vis2k
9bc1dc1e85 NetworkClient class made static 2019-03-26 12:16:57 +01:00
vis2k
912572d6fe NetworkClient.ConnectLocalServer: use the same order as Connect 2019-03-26 12:16:57 +01:00
vis2k
7bc320d098 LocalClient class moved into NetworkClient 2019-03-26 12:16:57 +01:00
vis2k
31836c16d1 NetworkClient.RemoveTransportHandlers made static 2019-03-26 12:16:57 +01:00
vis2k
4dbaff8ac1 NetworkManager.StartClient/StartHost don't return NetworkClient anymore 2019-03-26 12:16:57 +01:00
vis2k
d1d006e6d7 NetworkClient.Connect made static 2019-03-26 12:16:57 +01:00
vis2k
080bf2eaf0 NetworkClient.InitializeTransportHandlers made static 2019-03-26 12:16:57 +01:00
vis2k
32ed62f82b NetworkClient.OnError made static 2019-03-26 12:16:57 +01:00
vis2k
461ba0b036 NetworkClient.OnDisconnected made static 2019-03-26 12:16:57 +01:00
vis2k
60083ff72d NetworkClient.OnDataReceived made static 2019-03-26 12:16:57 +01:00
vis2k
42bceb25d9 NetworkClient.OnConnected made static 2019-03-26 12:16:57 +01:00
vis2k
493bf7fa5f NetworkClient.RegisterSystemHandlers made static 2019-03-26 12:16:57 +01:00
vis2k
bc6c2542f6 NetworkClient.UnregisterHandler made static 2019-03-26 12:16:57 +01:00
vis2k
9eac983872 . NetworkManager.RegisterClientMessages doesn't require NetworkClient parameter anymore 2019-03-26 12:16:57 +01:00
vis2k
712aecb452 NetworkClient.REgisterHandle made static 2019-03-26 12:16:57 +01:00
vis2k
ba00554e0c NetworkClient.GetRTT made static 2019-03-26 12:16:57 +01:00
vis2k
4abc58b136 NetworkClient.Send(msgId, msg) made static 2019-03-26 12:16:57 +01:00
vis2k
cd56c6a6f7 NetworkTime.UpdateClient doesn't require NetworkClient anymore 2019-03-26 12:16:57 +01:00
vis2k
8c125d2fd3 NetworkClient.Send made static 2019-03-26 12:16:57 +01:00
vis2k
558e1d8754 NetworkClient.SetHandlers made static 2019-03-26 12:16:57 +01:00
vis2k
180d3f8cf4 NetworkClient.isConnected made static 2019-03-26 12:16:57 +01:00
vis2k
604c205025 NetworkClient.serverIp made static 2019-03-26 12:16:57 +01:00
vis2k
882a7d5ba8 NetworkClient.connection made static 2019-03-26 12:16:57 +01:00
vis2k
f351a8a6d4 NetworkClient.connectState made static 2019-03-26 12:16:57 +01:00
vis2k
006d5d3bc8 NetworkClient.handlers made static 2019-03-26 12:16:57 +01:00
rodolphito
3a8fa3f571 Remove internal access modifier. (#658) 2019-03-26 12:09:43 +01:00
rodolphito
a96417112d Use ulong instead of uint to support up to 64 animator parameters. (#655) 
* Use ulong instead of uint to support up to 64 animator parameters.

* Split onto new line as Paul asked
 2019-03-26 07:57:51 +01:00
uwee
65eaba1fe0 fix: #651 GetSceneAt assumes default scene (#654) 
Changed to GetActiveScene
 2019-03-26 07:57:31 +01:00
Paul Pacheco
8c93f31b80 refactor: Load parameters right before function call 2019-03-25 23:13:52 -05:00
vis2k
ff909bf830 Telepathy license file included 2019-03-25 20:03:27 +01:00
vis2k
14807f6ef7 add comment 2019-03-25 16:20:17 +01:00
vis2k
13bb748603 fix: Revert "NetworkClient.Shutdown: call ClientScene.Shutdown, otherwise it's never called" - caused client's player to not be removed from scene after disconnecting 
This reverts commit e1e7b3132e.
 2019-03-25 16:19:22 +01:00