Commit Graph

5205 Commits

Author SHA1 Message Date
vis2k
df2330239f add TODO 2021-03-13 19:53:51 +08:00
vis2k
b9027737c8 add TODO 2021-03-13 19:47:35 +08:00
vis2k
23722ce828 add comment 2021-03-13 19:42:49 +08:00
vis2k
b258a27c09 add comment 2021-03-13 19:42:20 +08:00
vis2k
f19385d565 add TODO 2021-03-13 19:40:18 +08:00
vis2k
461ce519ff obsolete redundant NetworkClient.RegisterHandler version with NetworkConnection 2021-03-13 19:35:49 +08:00
vis2k
e0d023828f add TODOs 2021-03-13 19:30:46 +08:00
vis2k
5cb86830f1 BasicAuthenticator.OnAuthResponseMessage: remove unnecessary NetworkConnection parameter to remove last dependency on RegisterHandler version with NetworkConnection 2021-03-13 19:30:16 +08:00
vis2k
ecf15f5070 NetworkManager: OnClientSceneInternal uses RegisterHandler version without NetworkConnection parameter to prepare for removal 2021-03-13 19:25:29 +08:00
vis2k
8e0ef05c64 NetworkManager: OnClientNotReadyMessageInternal uses RegisterHandler version without NetworkConnection parameter to prepare for removal 2021-03-13 19:24:45 +08:00
vis2k
5bf7be143c NetworkClient.OnConnected/DisconnectEvent: remove redundant NetworkConnection parameter. It's always NetworkClient.connection anyway. 2021-03-13 19:22:57 +08:00
vis2k
f38d29b61c MultipleMatches example: CanvasController uses RegisterHandler version without NetworkConnection parameter to prepare for removal 2021-03-13 19:17:59 +08:00
vis2k
3cfee7dd14 add TODO 2021-03-13 19:13:53 +08:00
vis2k
21e0d6c8e0 NetworkClient.RegisterSystemHandlers: use the variant without NetworkConnection parameter so we can remove the other one later 2021-03-13 19:12:08 +08:00
vis2k
251d3cd392 NetworkClient.ClearLocalPlayer removed. clear it directly instead. 2021-03-13 18:36:52 +08:00
vis2k
9cf4207819 fix: #2635 - Reset also checks if local player before clearing it (see previous commit) 2021-03-13 18:36:29 +08:00
vis2k
457b21d907 fix: #2635 NetworkIdentity.OnDestroy only clears NetworkClient.localPlayer if WE are STILL the local player.
fixes data race in rooms scene (explanation see comments)
2021-03-13 18:29:20 +08:00
vis2k
2cd4403429 add TODO 2021-03-13 13:59:19 +08:00
vis2k
be229f27d8 add TODO 2021-03-13 13:58:39 +08:00
vis2k
251000436f syntax 2021-03-13 13:54:04 +08:00
vis2k
e5f6d25ae3 syntax 2021-03-13 13:53:27 +08:00
vis2k
01d1630b7f syntax 2021-03-13 13:52:44 +08:00
vis2k
a643cf7045 syntax 2021-03-13 13:52:32 +08:00
vis2k
89df32563b syntax 2021-03-13 13:52:14 +08:00
vis2k
b2892e7e1a add TODO 2021-03-13 13:51:20 +08:00
vis2k
0949c9d875 NetworkClient.HandleClientDisconnect removed. set .ready=false directly instead. way easier to understand. 2021-03-13 13:48:29 +08:00
vis2k
d7ee25e589 NetworkClient.HandleClientDisconnect: remove unnecessary connection parameter. it wasn't even used. 2021-03-13 13:44:34 +08:00
vis2k
4a47b1c7d2 NetworkClient.Ready: easier syntax 2021-03-13 13:34:58 +08:00
vis2k
f38af96202
NetworkClient.Ready: remove unnecessary NetworkConnection parameter (#2634) 2021-03-13 13:33:02 +08:00
vis2k
4daf0e439f add TODOs 2021-03-13 13:17:17 +08:00
vis2k
5e7c873af9 comment formatting 2021-03-13 13:15:00 +08:00
vis2k
a5224ecd10 syntax 2021-03-13 13:11:13 +08:00
vis2k
4ce55f585c NetworkClient.Ready: improve error message 2021-03-13 13:10:39 +08:00
vis2k
10aca712c2 add TODO 2021-03-13 13:08:20 +08:00
vis2k
a2dc9e6283 add TODO 2021-03-13 13:07:15 +08:00
vis2k
87c2f982cd NetworkClient.AddPlayer: remove unnecessary ready line. we don't even get there if we aren't already ready. 2021-03-13 13:04:24 +08:00
vis2k
d118de81db NetworkClient.AddPlayer: check if ready again. UNET checked if it has a readyConnection before too. 2021-03-13 13:01:21 +08:00
vis2k
c3f27f0fa1 NetworkClient.AddPlayer: simplify syntax, add TODO 2021-03-13 12:53:36 +08:00
vis2k
dc181ffe08 NetworkClient.AddPlayer: remove unnecessary NetworkConnection parameter 2021-03-13 12:44:54 +08:00
vis2k
0d5df4842f obsolete NetworkClient.readyConnection redundant state 2021-03-13 12:36:54 +08:00
vis2k
dd5c137c7b Tests: remove last dependencies on .readyConnection 2021-03-13 12:35:45 +08:00
vis2k
e42ecab505
Update README.md 2021-03-13 12:30:33 +08:00
vis2k
13b4f7d5e7 old Logging files moved into Old folder 2021-03-13 12:22:56 +08:00
vis2k
44ec5f3b1a breaking: update to Unity 2019.4 LTS now that 2020.3 LTS is out. 2021-03-13 12:19:18 +08:00
MrGadget1024
c7c43da3ad fix: NetworkLoop compiler definition wrong version 2021-03-12 09:04:44 -05:00
vis2k
c39a35077e SendCommandInternal: use NetworkClient.connection instead of NetworkClient.readyConnection to remove dependency on .readyConnection 2021-03-12 16:37:36 +08:00
vis2k
cf08822f00 test for #2629 [Command(requiresAuthority=false)] to make sure it never happens again 2021-03-12 15:32:10 +08:00
vis2k
9d38188d6e fix: NetworkClient.Ready(): set .connection to connection parameter like UNET did.
this was changed in 89cdec3075 because it's unnecessary.
but NetworkBehaviourTests.SendCommandInternal depends on it.
so let's keep feature parity for now.
2021-03-12 15:26:56 +08:00
vis2k
67d24ee2ca forgot to revert test too 2021-03-12 15:07:47 +08:00
vis2k
c749c84ee4 forgot to fix log 2021-03-12 15:06:03 +08:00