Paul Pacheco
6c7e578d5a
Remove redundant validations
2020-09-22 11:22:36 -05:00
Paul Pacheco
3e8870f791
we only weave one assembly at a time, no need for array
2020-09-22 10:11:07 -05:00
Paul Pacheco
eaf6ac66f0
output directory is always null, no need to pass it around
2020-09-22 10:06:13 -05:00
Paul Pacheco
eadb029393
Rename methods for clarity
2020-09-22 09:53:23 -05:00
Paul Pacheco
9d7c9069d7
Simplify namespace
2020-09-22 08:17:06 -05:00
Paul Pacheco
0fbcefe8df
Follow naming convention
2020-09-22 08:16:04 -05:00
Paul Pacheco
85d26ebce6
type safe type comparison
2020-09-21 23:00:30 -05:00
Paul Pacheco
541b516d60
Remove unused parameter
2020-09-21 17:09:13 -05:00
Paul Pacheco
030dc86ea9
Namespace simplifications
2020-09-21 17:08:46 -05:00
Paul Pacheco
12debf1c8c
Simplify namespace
2020-09-21 17:05:20 -05:00
Paul Pacheco
f77186e1d1
Simplify namespace
2020-09-21 17:00:57 -05:00
Paul Pacheco
d123e03915
Simplify namespace
2020-09-21 17:00:10 -05:00
Paul Pacheco
8fcbba50c4
Remove unused parameter
2020-09-21 16:59:05 -05:00
Paul Pacheco
7347e5700d
Remove unused parameter
2020-09-21 16:58:33 -05:00
Paul Pacheco
76ce3796eb
Simplify attribute namespace
2020-09-21 16:58:08 -05:00
Paul Pacheco
ca418457e8
Simplify guard check
2020-09-21 16:57:22 -05:00
Paul Pacheco
65f6e42b53
Simplify namespaces
2020-09-21 16:53:01 -05:00
James Frowen
94419ba003
Update ApiConnector.cs
...
adding null check for when listserver fails to be created
2020-09-20 00:44:13 +01:00
James Frowen
44401ab3bf
Update NetworkHeadlessLogger.cs
2020-09-19 11:30:41 +01:00
vis2k
d559bcfea7
Icon updated to half M
2020-09-19 10:01:10 +02:00
Paul Pacheco
07d290fd8c
Enhance code readability by using extension method ( #2260 )
...
# Before
This is hard to read:
```
if (ca.AttributeType.FullName == typeof(Mirror.CommandAttribute).FullName) {
...
}
```
# After
```
if (ca.AttributeType.Is<Mirror.CommandAttribute>()) {
...
}
```
2020-09-18 14:54:51 -05:00
James Frowen
7919942110
Splitting up test function
...
* Update NetworkServerTest.cs
splitting up test
* Update NetworkServer.cs
using string interpolation
2020-09-18 20:47:54 +01:00
Paul Pacheco
e50ea6318f
perf(weaver): No need to manually load mirror and unity assemblies ( #2261 )
2020-09-18 14:32:14 -05:00
James Frowen
a573bccc79
Update ApiUpdater.cs
2020-09-18 20:14:10 +01:00
Paul Pacheco
0b5989f87d
Move overloads together
2020-09-18 13:06:34 -05:00
Paul Pacheco
6cfdd6469a
Simplify type lookup in weaver ( #2258 )
...
# Before
WeaverTypes declared a static variable like this:
```cs
public static TypeReference int32Type;
```
Weavertypes then loaded the variable in SetupTargetTypes like this:
```cs
int32Type = ImportSystemModuleType(currentAssembly, systemModule, "System.Int32");
```
Note we lookup the type with a string, any typo there won't be detected until the code is executed. It will also not be found by the IDE when you click "find references", or when you refactor.
Then we use it like this:
```cs
var intType = WeaverTypes.int32Type;
```
This is a DRY violation: I have to modify 3 different code sections just to say that I want the int32 type.
# After
Get rid of all the duplication, and use the type instead of a string:
```cs
var intType = WeaverTypes.Import<int>();
```
No need for static variable, or to add it in SetupTargetTypes.
2020-09-18 13:05:16 -05:00
James Frowen
8dac53ce3c
making InvokeUserCode use correct type in argument ( #2259 )
2020-09-17 22:41:37 +01:00
James Frowen
c69d8cca0b
flip equals to return early ( #2245 )
...
* flip equals to return early
* flip equals to return early
* removing un-needed comment
2020-09-16 12:05:43 +01:00
James Frowen
23bd9559d3
pref: increasing performance when Send is called on no observers ( #2244 )
...
* pref increasing performance when sending to no observers
* pref increasing performance when sending to no observers
2020-09-16 10:32:16 +02:00
James Frowen
5eb5ff6601
fix: fixing NullReferenceException when loading scene ( #2240 )
...
* fixing null ref error when local player is destroyed
* removing null objects
* fixing InvalidOperationException
* moving code to its own function
* Update Assets/Mirror/Runtime/ClientScene.cs
2020-09-16 10:30:10 +02:00
James Frowen
7580e9a6f5
Update ClientScene.cs ( #2250 )
...
* Update ClientScene.cs
Improving logging
- making sure sceneId is always hex
- only logging "Client spawn for ..." if it was successful
* Update ClientSceneTests_OnSpawn.cs
2020-09-14 22:35:41 +01:00
James Frowen
833c329ab2
Update ApiUpdater.cs
...
- Adding handlers in Awake instead of Start to make sure they are added before start on headless
- using GetComponent for NetworkManagerListServer
- Adding asserts to make sure values are set
2020-09-14 21:58:33 +01:00
James Frowen
b4fea1bfa3
Update NetworkServer.cs ( #2247 )
2020-09-13 19:07:59 +01:00
James Frowen
aec9b8a2ec
Update NetworkIdentity.cs
...
fixing block not being in remarks
2020-09-13 15:44:25 +01:00
James Frowen
d5c2387d1d
Update SyncObject.cs
2020-09-13 14:33:32 +01:00
James Frowen
ae9d2e35a9
docs: adding debug notes on list server ( #2246 )
2020-09-13 02:47:57 +01:00
James Frowen
844904dae5
adding doc comment ( #2243 )
2020-09-13 01:54:23 +01:00
James Frowen
94da8aec34
fix: Fixing IndexChanged hook not being called for NetworkRoomPlayer ( #2242 )
...
* adding Server to make sure index is only changed on the server
* removing calls to RecalculateRoomPlayerIndices on client
2020-09-13 01:52:32 +01:00
James Frowen
0c78fa0d7a
making sure CallOnClientExitRoom is called when object is disabled/destroyed ( #2241 )
2020-09-12 23:36:46 +01:00
Paul Pacheco
992129e5b6
Simplify string interpolation
2020-09-12 09:04:52 -05:00
James Frowen
5edba81dee
fix: ClientScene.localplayer is now set to null when it is destroyed ( #2227 )
...
* moving FakeNetworkConnection to common test folder
* adding test for local player destroy
* adding method to clear local player
* temp move test functions
* adding test for destroying non player
* moving asset to setup
* adding tests for destroy message and host mode
* adding ClearLocalPlayer to reset
2020-09-08 09:45:24 +02:00
James Frowen
2033f7d009
breaking: Removing manual invoke for Cmd and RPC ( #2223 )
...
* Removing manual invoke for Cmd and RPC
There should be no reason to manaully invoke remote code
they are marked with EditorBrowsableState.Never which implies they should not be called by the user
* removing tests
2020-09-06 16:14:05 +02:00
vis2k
a30e8fcd85
adding empty SyncEventProcessor file for deleted file
2020-09-06 16:07:52 +02:00
James Frowen
a232c539a7
adding empty program file for deleted file
2020-09-06 16:05:50 +02:00
James Frowen
bfa482fde7
Adding Network Lerp Rigidbody docs and change log ( #2226 )
...
* adding NetworkLerpRigidbody to change log
* adding docs for Network Lerp Rigidbody
2020-09-05 13:09:06 +01:00
James Frowen
f326999d50
removing methods that only set enum ( #2221 )
2020-09-04 22:41:38 +01:00
James Frowen
622b52124b
Refactoring handle remote call ( #2222 )
...
* using string interpolation for logs
* return early instead of if/else
2020-09-04 22:40:56 +01:00
James Frowen
eac69ab5f6
docs: sync event obsolete ( #2216 )
...
* adding note to guides about removed SyncEvent
* updating Obsolete
making Obsolete error whe used
updating text to say it has been removed
linking to issue
* adding Obsolete note to other references to SyncEvent
2020-09-04 16:29:46 +01:00
vis2k
e67cef6666
Remove ScriptTemplates to clean up folder ( #2213 )
...
* Remove ScriptTemplates to clean up folder
* Update main.yml
Removing script templates from CI
Co-authored-by: James Frowen <jamesfrowendev@gmail.com>
2020-09-04 07:55:11 +02:00
James Frowen
24e3ea099c
adding version define from v18 breaking change ( #2214 )
2020-09-03 15:46:15 +01:00
James Frowen
e79e340e0d
fixing typo in NetworkIdentity.cs
2020-09-03 11:51:05 +01:00
vis2k
cd3d9c2144
Delete old file
2020-09-03 09:05:47 +02:00
vis2k
fc1096d66c
breaking: Removed [SyncEvent] because ClientRpc/TargetRpc does the same thing, and it's an enormous effort to support the Weaver code. ( #2178 )
2020-09-03 09:04:29 +02:00
James Frowen
ad8af783dc
Replacing prefabAssetPath with assetPath for PrefabStage to stop warning ( #2210 )
2020-09-03 08:48:06 +02:00
James Frowen
1ade82d435
feat: making NetworkBehaviour.IsDirty public ( #2208 )
2020-08-31 12:26:50 +01:00
James Frowen
5701369e84
feat: adding script to help debug list server ( #2202 )
...
Script uses OnGui so can be used to check if server has been added to list server
2020-08-27 23:15:43 +01:00
James Frowen
fc530782cc
fix: fixing width and layout group on cloud example ( #2201 )
2020-08-27 23:10:11 +01:00
vis2k
f6dbf8c19e
Fix broken Weaver test
2020-08-27 00:18:01 +02:00
vis2k
594aec45bf
Weaver RpcProcessor validation moved to NetworkBeahviourProcessor.ProcessClientRpc
2020-08-26 13:15:23 +02:00
vis2k
25ef6ac36a
Weaver TargetRpcProcessor validation moved to NetworkBehaviourProcessor.ProcessTargetRpc
2020-08-26 13:13:56 +02:00
vis2k
820d0daa29
Weaver CommandProcessor validation moved to NetworkBehaviourProcessor.ProcessCommand
2020-08-26 13:12:56 +02:00
vis2k
5e7257d7bc
Weaver ValidateRemoteCallAndParameters IsStatic check added so we don't need to check in Command/Rpc/TargetRpcProcessors
2020-08-26 13:11:56 +02:00
vis2k
2e178b7eaf
Weaver NetworkBehaviourProcessor: ValidateRemoteCallAndParameters function added to be used from Command/Rpc/TargetRpcProcessors
2020-08-26 13:08:46 +02:00
vis2k
fbad5d2401
Add comment
2020-08-26 13:04:39 +02:00
vis2k
68ebaf1756
Weaver TargetRpcProcessor: ValidateTargetRpc simplified
2020-08-26 13:03:44 +02:00
vis2k
e6ffe6d6bf
Weaver: Simplify ValidateParameters
2020-08-26 13:02:25 +02:00
vis2k
ce3dd51d81
Weaver NetworkBehaviourProcessor: ProcessMethodsValidateParameters renamed to ValidateParameters
2020-08-26 13:01:43 +02:00
vis2k
ee8ad1d750
Weaver TargetRpcProcessor: ProcessMethodsValidateTargetRpc renamed to ValidateTargetRpc
2020-08-26 13:01:43 +02:00
vis2k
1b49a21d49
Weaver RpcProcessor: ProcessMethodsValidateRpc renamed to ValidateRpc
2020-08-26 13:01:43 +02:00
vis2k
9131586f5c
Weaver NetworkBehaviourProcessor: ProcessMethodsValidateFunction renamed to ValidateFunction
2020-08-26 13:01:43 +02:00
vis2k
3dab0ec7c5
Weaver CommandProcessor: ProcessMethodsValidateCommand renamed to ValidateCommand
2020-08-26 13:01:43 +02:00
James Frowen
a9d21ea9ab
fix: adding error for generated read writer for abstract class ( #2191 )
...
* fix adding error for gernated read writer for abstract class
weaver can not initialize class abstract class so cant not create a reader
this gives a helpful error telling the server to make a custom reader
* adding tests for error message
* fixing typo
* renaming
* fixing expected error messages
2020-08-25 17:14:39 +01:00
James Frowen
c9a9f92c7c
commenting out reader error checks ( #2196 )
...
Reader code doesn't run on Rpc now if a valid writer can not be found
In future PR write and read functions should be generated together as they share most of the same checks
2020-08-25 01:39:03 +01:00
James Frowen
d73de03eca
renaming variables in Readers to match writers ( #2195 )
2020-08-24 14:48:15 +01:00
James Frowen
11a8d41464
fixng ArgumentNullException ( #2193 )
2020-08-24 14:43:51 +01:00
James Frowen
771f1fea13
fixing typo ( #2192 )
...
variable should start with lower case
2020-08-23 19:30:20 +01:00
James Frowen
1045b1f2ed
tests using HasError ( #2188 )
...
* replacing assert with haserror
* adding IsSuccess and HasWarning functions
* using IsSuccess
* checking weaverWarnings empty in success
* using HasWarning
* replacing asserts missed by regex
* fixing typo
* adding HasNoErrors function to be used when tests only have warnings
* fixing typo
* making fields public to stop warnings
* simplifying more test files
2020-08-22 20:20:16 +01:00
James Frowen
bd7c93674e
Error with message overloads ( #2168 )
...
* weaver error with message overloads
* finding method with 1 arg
2020-08-22 21:07:33 +02:00
James Frowen
d5d434cf13
weaver: renaming variables and changing order things happen ( #2172 )
...
* renaming variables
* adding todo
* moving order that things happen
2020-08-22 21:05:01 +02:00
James Frowen
ea0b9e1215
returning lists instead of passing them in as args ( #2183 )
2020-08-22 20:51:47 +02:00
James Frowen
f051c4b911
Simplify weaver tests ( #2186 )
...
* Simplifying weaver test files
* updating error messages
2020-08-22 19:00:11 +01:00
James Frowen
c312874bcb
renaming test folder in order to use WeaverTestsBuildFromTestName ( #2189 )
2020-08-22 18:59:06 +01:00
James Frowen
f1d7f207c3
adding HasError method ( #2185 )
...
Makes it easier to write error message within weaver tests because there is mess syntax to worry about
2020-08-22 16:23:56 +01:00
vis2k
9ec5eadd51
Weaver: PropertySiteProcessor.ProcessSitesModule renamed to Process for consistency
2020-08-22 13:59:17 +02:00
vis2k
ed60e592dc
Syntax
2020-08-22 13:57:52 +02:00
vis2k
16f8f05abe
Weaver: ReaderWriterProcessor.ProcessReadersAndWriters renamed to Process for consistency
2020-08-22 13:56:52 +02:00
vis2k
84602aace6
ServerClientAttributeProcessor: ProcessSiteClass renamed to Process for consistency
2020-08-22 13:55:22 +02:00
vis2k
342ed13f55
Weaver: update ServerClientAttributeProcessor explanation
2020-08-22 13:40:41 +02:00
vis2k
427adf6c8e
Weaver: ProcessNetworkBehaviourType code moved into NetworkBehaviourProcessor.Process
2020-08-22 13:40:41 +02:00
James Frowen
4774f83032
moving FindSyncObjectsFields to its own function ( #2182 )
2020-08-22 12:10:01 +02:00
vis2k
df38c4fb2c
Syntax
2020-08-21 20:00:42 +02:00
vis2k
5cc908a18d
Weaver PropertySiteProcessor: remove redundant AssemblyDefinition parameter. Weaver passes assembly.MainModule anyway.
2020-08-21 18:25:01 +02:00
vis2k
4258220b26
Weaver PropertySiteProcessor: pass CurrentAssembly to Process function to reduce coupling
2020-08-21 18:22:12 +02:00
vis2k
7b9066832b
Syntax
2020-08-21 18:04:32 +02:00
vis2k
fe32557a38
Weaver ProcessSyncVars: remove redundant numSyncVars field, use syncVars.Count instead
2020-08-21 17:33:11 +02:00
vis2k
54c32227bd
[Obsolete] SyncEvent ( #2180 )
2020-08-21 17:03:06 +02:00
James Frowen
eec49fafce
feat: Use Server Client attribute outside of NetworkBehaviour ( #2150 )
...
* adding generated test for other baseclasses
* removing errors when attribute is not in networkbehaviour
* temp weaver tests
* updating weaver tests for monobehaviour
* adding weaver tests for non-networkbehaviour
* moving where serverclient attributes are processed
* removing un-used code
* regenerate tests
2020-08-21 16:02:37 +01:00
James Frowen
c6fa49c72a
fix: adding version define from v17 breaking change
2020-08-21 13:49:54 +01:00
vis2k
35d8e0ed60
Syntax
2020-08-21 12:12:40 +02:00
vis2k
07f5912215
Weaver GenericArgumentResolver: reuse StripGenericParametersFromClassName
2020-08-21 12:07:18 +02:00
vis2k
0e124ff8b2
Weaver Resolvers: remove unused code
2020-08-21 12:02:01 +02:00
vis2k
bfb97e7202
Syntax
2020-08-21 11:54:49 +02:00
vis2k
2ea787f4fc
Weaver Extensions: HasCustomAttribute uses Linq to simplify code
2020-08-21 11:38:36 +02:00
vis2k
467d9e834f
Weaver Extensions: GetMethod uses Linq to simplify code
2020-08-21 11:38:36 +02:00
vis2k
045b50a929
Weaver Extensions: GetMethods uses Linq to simplify code
2020-08-21 11:31:25 +02:00
vis2k
687c9002dd
typo
2020-08-21 11:28:51 +02:00
vis2k
0043288900
typo
2020-08-21 11:28:38 +02:00
vis2k
e8ae2246c0
Weaver Extensions: remove unused functions
2020-08-21 11:27:11 +02:00
vis2k
22486885f1
syntax
2020-08-21 11:21:26 +02:00
vis2k
948b97e30d
Weaver Tests: StripGenericParametersFromClassNameTest
2020-08-21 11:20:31 +02:00
vis2k
ad42aa19de
internal
2020-08-21 11:18:05 +02:00
vis2k
3b6f98be9f
Weaver Extensions: IsDerivedFrom strip generic parameters code moved into separate function
2020-08-21 11:16:05 +02:00
vis2k
461396601f
ignore warnings
2020-08-21 11:07:08 +02:00
James Frowen
c39a2d546e
splitting up GetWriteFunc function ( #2171 )
2020-08-21 10:57:41 +02:00
James Frowen
150b14a2ed
perf: adding check for no connections ( #2130 )
...
* adding check for no connections
Dont need to run Server Update if there are no connections
* adding toggle to disable skip
* formatt
* removing skipUpdateIfNoConnections check, and merging if checks
* removing extra line
* adding tests for NoConnections
2020-08-21 10:51:58 +02:00
James Frowen
7c7edb2586
weaver: Moving stuff around in writer ( #2170 )
...
* removing TypeDef versions of extension methods
* moving function up
* Renaming function
* fixing comment
* changing comment
* Update Writers.cs
Co-authored-by: vis2k <info@noobtuts.com>
2020-08-20 22:35:57 +02:00
James Frowen
99d4f8c9bd
breaking: replacing isHeadless with isServerBuild ( #2093 )
...
* replacing isHeadless with isServerBuild
* renaming startOnHeadless
* fixing isServerBuild bool
* making property a field instead
* replacing isServerBuild for #if UNITY_SERVER
* fixing comment and removing extra lines
* removing system from System.Obsolete
* renaming to autoStartServerBuild
2020-08-20 13:56:46 +02:00
James Frowen
a2124c3522
Renaming tests and namespaces ( #2167 )
...
* renaming test
* renaming test file
* removing test suffix from methods
* changing test namesapce
2020-08-19 02:18:20 +01:00
James Frowen
0c790e339d
adding assert to make sure transport is set ( #2164 )
...
* adding assert to make sure transport is set
this helps people who want to connect without using networkmanager
* moving Transport.activeTransport to setup
* replacing Substitute.For for addComponent
Can't used Substitute for monobehaviours as they will still be null with unity equals
2020-08-18 18:57:31 +02:00
James Frowen
3a276b4e30
fix: weaver test for abstract methods ( #2166 )
...
* weaver test for abstract methods
* doing nothing is method is abstract
* not calling base if it is abstract
* adding tests for message to make sure they work
2020-08-18 18:56:48 +02:00
James Frowen
7294c42798
splitting up ProcessEvents function ( #2174 )
2020-08-18 18:56:21 +02:00
James Frowen
e4d9304478
moving getwriter to above op code ( #2175 )
2020-08-18 18:54:35 +02:00
James Frowen
901898e897
removing old tests ( #2165 )
...
these are covered by CollectionWriterTests.gen.cs
2020-08-17 12:01:33 +01:00
James Frowen
aa49c54dd0
removing program class ( #2161 )
2020-08-16 12:22:12 +02:00
James Frowen
381e5a115b
feat: allowing lists to automatically be sent in Commands, Rpc, and Messages ( #2151 )
...
* weaver tests for list read write
* generated tests for list read write
* adding method to check for list type
* temp
* weaver functions for creating read write for list
* generating tests for lists
2020-08-15 18:00:55 +02:00
James Frowen
5b179e8917
Generated tests for collection read write ( #2158 )
...
* adding generated tests for collection writers
tests for read+write for array and array segment
* changing menu path
* adding tests for collections of classes
* swapping order in class name
2020-08-15 02:57:38 +01:00
James Frowen
2fbd131f61
Test for array segment and writers ( #2157 )
...
* tests for array and segment writers
* fix typo
2020-08-14 23:29:07 +01:00
James Frowen
c1410b0924
fix: adding error when Server/Client is used on abstract methods ( #1978 )
...
* tests for Server attribute on virtual methods
test for virtual, abstract and override methods
* adding test for client attribute
* adding error when attribute is put on abstract method
* improving error message
* updating error mesages in tests
* updating to use WeaverTypes
* adding check before error
2020-08-14 10:52:06 +02:00
James Frowen
71bf792db5
moving where CallOnClientEnterRoom is called ( #1922 )
2020-08-14 10:47:44 +02:00
James Frowen
fc48e0ecf9
Adding alternative to NetworkRigidbody ( #2123 )
...
Uses Lerp to set position and velocity
2020-08-11 10:27:09 +02:00
James Frowen
2046e8813e
removing Internal functions that do nothing ( #2154 )
2020-08-10 08:57:47 +02:00
James Frowen
5089546ecd
fixing IL error when using floats ( #2147 )
...
* fixing IL error when using floats
* removing speical case for primitive types
2020-08-09 21:11:46 +01:00
James Frowen
e4a5ce795b
fix: Nested messages ( #2148 )
...
* test for nested messages
* fixing StackOverflow with nested types
2020-08-09 20:01:14 +02:00
James Frowen
fe3bebcc63
Making EnableDebugMode public ( #2152 )
2020-08-09 17:29:05 +01:00
James Frowen
ee9a600f66
Generated attribute tests ( #2149 )
...
* class to create test functions
* generated test folder
* generated attribute tests
* adding out function and long type
* generated test file
* using OneTimeSetUp to make tests run faster
2020-08-08 15:11:31 +01:00
James Frowen
ec54ee6d8c
fix: fixing unity crash on StackOverflowException ( #2146 )
...
StackOverflowException was causing unity to crash while running weaver
tests, using inner exception seems to fix that issue
2020-08-07 16:30:08 +01:00
James Frowen
ddc6139725
fix: fixing warning message for client attribute ( #2144 )
2020-08-07 13:03:46 +01:00
James Frowen
d46469a79c
fix: isServer false in OnDestroy ( #2101 )
...
* fix isServer false in OnDestroy
* making sure that OnDestroy doesn't call Destroy again
2020-08-06 17:55:35 +02:00
James Frowen
a124f3f439
fix: fixing cloud log not using logger ( #2141 )
2020-08-06 13:26:14 +01:00
Keir Smith
23b9fb0214
feat: Added Layer Weight to NetworkAnimator ( #2134 )
...
* Added Layer Weight to NetworkAnimator
Now NetworkAnimator is aware of each layer weight on it's references
Animator and will sync layer weights across the network.
* NetworkAnimator layers Float equality fix
* Update Assets/Mirror/Components/NetworkAnimator.cs
Co-authored-by: James Frowen <jamesfrowen5@gmail.com>
* Update Assets/Mirror/Components/NetworkAnimator.cs
Co-authored-by: James Frowen <jamesfrowen5@gmail.com>
* Remove GetLayerWeight check every incoming packet as is extern call
Co-authored-by: James Frowen <jamesfrowen5@gmail.com>
2020-08-05 23:54:46 +01:00
James Frowen
87a96d17ca
deleting telepathy tests ( #2136 )
2020-08-05 20:44:38 +02:00
James Frowen
fee9adfa63
Adding asmdef to telepathy ( #2137 )
...
* Adding asmdef to telepathy
mirror has to reference telepathy as it is the default transport
this also means that TelepathyTransport has to be in the mirror asmdef
* references telepathy in tests
* formatting asmdef
2020-08-05 12:40:10 +01:00
James Frowen
2998295e45
adding asmdef to websockets ( #2135 )
2020-08-05 12:09:00 +02:00
James Frowen
17838c5b52
removing 2nd null check ( #2128 )
...
if identity is not null then the game object is also not null
2020-08-05 12:08:20 +02:00
James Frowen
2b6a1bb792
adding test for NetworkServer.Destroy ( #2115 )
2020-08-05 12:07:40 +02:00
vis2k
0f09702062
Weaver types moved into WeaverTypes, and reduce some global state ( #2138 )
2020-08-05 12:07:11 +02:00
James Frowen
f1e5878ca1
Test for OnSpawn ( #2004 )
2020-08-04 11:55:42 +01:00
James Frowen
067c46fd60
fixing doc links ( #2139 )
2020-08-03 22:11:38 +01:00
James Frowen
4adaac8867
moving 2nd if inside 1st ( #2127 )
2020-08-03 20:37:32 +02:00
James Frowen
c63811ddc4
correctly error message so they are not misleading ( #2124 )
2020-08-03 20:36:20 +02:00
James Frowen
03fd6a5526
splitting on spawn into functions ( #2113 )
...
* making ApplySpawnPayload internal for tests
* splitting on spawn into functions
* renaming
2020-08-03 20:35:51 +02:00
James Frowen
7604e65c2c
fix: making triggers be called right away instead on owner ( #2125 )
...
* making triggers be called right away instead on owner
* only handling on server if it is not the host
2020-08-03 20:34:52 +02:00
James Frowen
da629e5f71
Formatting doc comments ( #2131 )
...
* making comments in NetworkServer doc comments
* making comments in NetworkIdentity doc comments
2020-08-03 20:33:42 +02:00
James Frowen
c3765c101d
moving FakeNetworkConnection to its own file ( #2132 )
2020-08-02 23:11:03 +01:00
James Frowen
3f027e0d0a
using memory transport in test ( #2129 )
...
telepathy fails this test sometimes
2020-08-02 23:00:14 +01:00
linjmeyer
3bdfd451cb
SSL/TLS version in Websockets now configurable ( #2121 )
2020-08-01 09:36:17 -05:00
Paul Pacheco
890ee6b58d
fix: auto fill serialize/deserialize for classes ( #2120 )
...
Note this method is being called in 3 places:
one in MessageClassProcessor and 2 in NetworkBehaviorProcessor.
The NetworkBehaviorProcess is really a don't care, this condition cannot happen since it would not be invoked unless the class extends from NetworkBehavior. In this case, it will always resolve.
but even if it does not resolve, they handle the null case gracefully by not calling the base method.
MessageClassProcessor also calls this method, and if it is null it does not call the base method. That is precisely the behavior we want to resolve #2117
so all 3 places are perfectly fine receiving null.
The only way to trigger the error was #2117
I renamed the method to make it clearer that this may not find the method in the parent class.
2020-08-01 08:46:12 -05:00
vis2k
0cb84baf97
Benchmark example missing NetworkManager reference fixed
2020-07-30 19:59:11 +02:00
vis2k
2effa7bc02
Update readme for 2018.4 LTS
2020-07-30 19:36:46 +02:00
vis2k
ce8d540a8f
2k NetworkTransforms renamed to Benchmark
2020-07-30 19:24:05 +02:00
vis2k
7de5400ad5
10k Benchmark removed because it's 2D, outdated and insignificant
2020-07-30 19:23:25 +02:00
vis2k
6f645c870c
Benchmark monster mesh changed to cube to reduce polygons
2020-07-30 19:21:50 +02:00
vis2k
0a554f5f6c
Remove warning
2020-07-30 19:12:15 +02:00
Anastasios Andronidis
92bc3c3150
Improve Telepathy debug messages ( #2106 )
2020-07-28 18:45:00 +01:00
James Frowen
70b7211cba
docs: updating cloud readme ( #2111 )
2020-07-28 00:41:45 +01:00
James Frowen
e136f48101
feat: Adding Custom Data and Custom Address fields to list server ( #2110 )
...
* whitespace
* adding doc comment
2020-07-27 17:31:56 +01:00
James Frowen
f913c64610
adding customData and customAddress ( #2108 )
2020-07-27 01:22:12 +01:00
francescoStrada
049ec99aa7
changing serverBroadcastListenPort variable access permissions to protected ( #2103 )
2020-07-23 11:12:36 +02:00
uwee
df16a7d3cc
fix: dont allow set of networkSceneName directly ( #2100 )
2020-07-19 16:58:35 +02:00
James Frowen
9497886ad4
fixing angularVelocity sync ( #2098 )
2020-07-16 01:29:24 +01:00
James Frowen
8e545ac468
fix: fixing cloud scripts not pinging api ( #2097 )
...
* adding logs to api updater
* fixing cloud api
2020-07-15 16:07:39 +01:00
uwee
e4cc85c413
fix: Misc code smells ( #2094 )
...
* fix: code smell - condensed if statement
* fix: code smell - dont throw generic Exception
2020-07-14 18:44:52 +02:00
uwee
12827f65a9
fix: add NetworkManager.StartClientUri test ( #2095 )
2020-07-14 18:44:28 +02:00
James Frowen
984eb73ea4
fix: register prefab error with same guid ( #2092 )
...
* tests for when newassetId is same as current
* stopping error if ids are the same
* invert if and adding comment
2020-07-13 19:40:11 +01:00
Paul Pacheco
a219ff2059
encapsulate method substitute naming ( #2091 )
...
* encapsulate method substitute naming
* This const is not used anywhere else, make it private
Co-authored-by: Paul Pacheco <paul.pacheco@aa.com>
2020-07-13 13:25:54 +01:00
James Frowen
18d695744f
fix: renaming call/invoke prefix for SyncEvent ( #2089 )
...
* renaming sync event
same reason as #2088
* removing un-used const
2020-07-13 06:29:24 -05:00
James Frowen
64f663fb5e
adding prefix to call command and rpc ( #2088 )
...
now that Cmd is not required "Call..." might collide with user functions
2020-07-13 05:49:27 -05:00
James Frowen
f1698e658c
removing code that isnt needed ( #2090 )
...
we use the original method name so we do not need to remove the prefix
2020-07-13 04:44:51 -05:00
James Frowen
ef47ee7a57
feat: Rigidbody example ( #2076 )
...
* adding example for NetworkRigidbody
* adding hud
* adding empty player so that scene objects spawn
* turning off debug logs
2020-07-13 01:04:51 +01:00
Paul Pacheco
ed40c2d210
feat: Sync Events no longer need Event prefix ( #2087 )
...
Instead of doing
```cs
[SyncEvent]
public event MySyncEventDelegate EventOnly;
```
You can now do
```cs
[SyncEvent]
public event MySyncEventDelegate Only;
```
We actually tried to remove them a while ago. The way the weaver worked
back then caused an infinite recursion.
Since the Command rewrite that allows virtuals, this is no longer
a problem. So we can drop this requirement.
Co-authored-by: Paul Pacheco <paul.pacheco@aa.com>
2020-07-12 17:27:44 -05:00
Paul Pacheco
eb93c34b33
feat: ClientRpc no longer need Rpc prefix ( #2086 )
...
Instead of doing
```cs
[ClientRpc]
public void RpcPepe() {}
```
You can now do
```cs
[ClientRpc]
public void Pepe() {}
```
We actually tried to remove them a while ago. The way the weaver worked
back then caused an infinite recursion.
Since the Command rewrite that allows virtuals, this is no longer
a problem. So we can drop this requirement.
Co-authored-by: Paul Pacheco <paul.pacheco@aa.com>
2020-07-12 16:50:01 -05:00
Paul Pacheco
d89ac9fb05
feat: TargetRpc no longer need Target prefix ( #2085 )
...
Instead of doing
```cs
[TargetRpc]
public void TargetPepe() {}
```
You can now do
```cs
[TargetRpc]
public void Pepe() {}
```
We actually tried to remove them a while ago. The way the weaver worked
back then caused an infinite recursion.
Since the Command rewrite that allows virtuals, this is no longer
a problem. So we can drop this requirement.
Co-authored-by: Paul Pacheco <paul.pacheco@aa.com>
2020-07-12 16:49:45 -05:00
Paul Pacheco
b6d1d09f84
feat: Commands no longer need Cmd prefix ( #2084 )
...
Instead of doing
```cs
[Command]
public void CmdPepe() {}
```
You can now do
```cs
[Command]
public void Pepe() {}
```
We actually tried to remove them a while ago. The way the weaver worked
back then caused an infinite recursion.
Since the Command rewrite that allows virtuals, this is no longer
a problem. So we can drop this requirement.
Co-authored-by: Paul Pacheco <paul.pacheco@aa.com>
2020-07-12 16:49:35 -05:00
James Frowen
110e8f162a
increasing max fails to 15, and ping interval to 20 ( #2081 )
...
ping will only stop if can not get success from cloud for 5 mins
2020-07-09 23:30:58 +01:00
James Frowen
f717945525
fix: not removing server if id is empty ( #2078 )
...
* logging error message
* not removing server if ID is empty
2020-07-07 21:20:08 +01:00
Walter Geisler
47740f0a46
Refactor TimeoutAuthenticator to pass through client/server start callbacks ( #2074 )
...
* Update TimeoutAuthenticator.cs
* Moved listener passthrough back to Awake()
* Remove white space above Awake()
* Remove all white space above awake
2020-07-06 16:06:37 +01:00
James Frowen
0506ad5ea1
fixing cloud tank example ( #2069 )
2020-07-06 09:37:30 +01:00
James Frowen
e7ca6eb7ef
tests for struct message with empty function ( #2067 )
2020-07-05 01:04:33 +01:00
James Frowen
3418fa2106
fix: Message base class not being Serialized if processed in the wrong order ( #2023 )
...
* finding all fields
* adding test for message with base
* undoing FindAllPublicFields
* adding tests for Inheritance with define order
* making sure that messages are processed in order
do not need to check if message has already been processed becuase
OnSerialize is only added/changed if it is missing or empty
* removing un-needed comments
* using recursion instead of loops
* remove white space
2020-07-05 01:04:14 +01:00
Paul Pacheco
264f9b8f94
perf: Use invokeRepeating instead of Update ( #2066 )
...
* perf: Use invokeRepeating instead of Update
If you have low frequency calls, InvokeRepeating is a lot faster than
Update(). Use InvokeRepeating for NetworkProximityChecker
* Fix indentation
Co-authored-by: Paul Pacheco <paul.pacheco@aa.com>
2020-07-04 13:41:16 -05:00
James Frowen
999c8b1c32
fixing doc comment
2020-07-03 22:53:30 +01:00
James Frowen
57bc80c9cd
adding clientAuthority to commands ( #2064 )
2020-07-03 16:31:42 +01:00
James Frowen
c278c004f6
updating readme for cloud list server ( #2058 )
2020-07-01 16:20:24 +01:00
James Frowen
b316b35d46
fix: weaver now processes multiple SyncEvent per class ( #2055 )
...
* weaver test for mutlitple events
* tests for multiple sync events in 1 class
* removing break so that multiple events will be proccessed
It seems like this break was here because unet used foreach CustomAttributes
but mirror uses GetCustomAttribute
2020-06-30 09:59:18 +02:00
James Frowen
c91308fb04
fix: sync events can not have the same name if they are in different classes ( #2054 )
...
* test for sync event with same name
* using full name instead of name
* fix test
2020-06-30 09:58:50 +02:00
James Frowen
d0bb9d57b0
sending if syncInterval is greater or equal to 0 ( #2053 )
2020-06-30 09:56:13 +02:00
MaZy
4ffff192a6
fix: If socket is undefined it will return false. See #1486 ( #2017 )
2020-06-28 18:10:17 -05:00
James Frowen
61d44b2d80
fix: Fallback and Multiplex now disable their transports when they are disabled ( #2048 )
...
* test to check if fallbacks disables other transport
* using ondisable to disable other transport
* fixing teardown
* adding test for Multiplex
* using ondisable to disable other transport
* fixing NSubstitute for 2019
2020-06-28 23:49:36 +01:00
James Frowen
ab1b92f74b
fix: addingNetwork rigidbody icon and AddComponentMenu attribute ( #2051 )
...
* adding icon
* adding attributes
* adding docs
* adding disclaimer at top of doc
2020-06-28 23:47:50 +01:00
James Frowen
0c30d3398a
fix: Network rigidbody fixes ( #2050 )
...
* using syncInterval for client auth
* only set sync var if change is greater than Sensitivity
* fixing client auth sync
* using currentVelocity
2020-06-28 23:46:43 +01:00
James Frowen
25285b1574
feat: Experimental NetworkRigidbody ( #1822 )
...
* NetworkRigidBody
2020-06-27 00:38:50 +01:00
Kyle
ba29119aa1
Missed one internal call that the NetworkManager uses ( #2044 )
2020-06-27 00:35:58 +01:00
Eunseop Shim
350ce47db3
Implement IReadOnlyDictionary for SyncDictionaries ( #2032 )
2020-06-26 13:21:54 +02:00
Kyle
d06ee6a21d
Kr/issue 2039 ( #2040 )
...
* Update NetworkClient.cs
* Update NetworkServer.cs
* Missed a call
2020-06-26 13:18:56 +02:00
James Frowen
78bd284b6f
fixing null ref ( #2043 )
2020-06-26 09:47:49 +01:00
James Frowen
e36449cb22
fix: changing namespace to match folder name ( #2037 )
...
* updating namespace
* updating example name spaces
2020-06-25 16:13:47 +01:00
James Frowen
7c9afca7c5
deleting old list server ( #2034 )
...
* deleting old list server
* fixing prefab name
2020-06-25 16:23:09 +02:00
James Frowen
18691dabe0
adding game name to api updater ( #2036 )
2020-06-25 12:14:50 +01:00
James Frowen
7d0e907b73
feat: More examples for Mirror Cloud Service ( #2029 )
...
* fixing pong spawn points
* renaming files and asmdef
* More Cloud examples
* Moving pong example to cloud folder
* Moving shared code to GUI folder
* Adding readme for examples
* Adding tank example
2020-06-25 01:58:47 +01:00
James Frowen
54a69bbc83
Fixing warning messages ( #2030 )
...
* disabling warning for empty method
* removing null propagation
null propagation in untiy can cause MissingReferenceException
2020-06-24 23:13:12 +02:00
James Frowen
b42c74bc40
adding doc comment for SpawnMessag ( #2027 )
2020-06-24 23:12:00 +02:00
James Frowen
f1fdc959dc
feat: adding demo for mirror cloud services ( #2026 )
...
* adding mirror list services
* fixing code smells
* removing runtime example folders
* removing matchmaking code till feature is ready
* fixing scene path
* updating readme to say where example is
2020-06-23 20:39:38 +02:00
James Frowen
065d320208
calling animator.enabled before calls to animator ( #2000 )
...
some functions don't need this check as the check is done before they are called
2020-06-21 12:09:24 +02:00
James Frowen
296f6f9cd8
Only setting last parameters values if they have changed ( #1999 )
...
* only setting last values if they have changed
* adding comment
2020-06-21 12:06:37 +02:00
James Frowen
f18f7a5c3d
making sure that trigger is called on the server ( #1998 )
2020-06-21 12:06:07 +02:00
James Frowen
3bea342257
rethrow error with stack ( #2013 )
...
this will help error be more useful
2020-06-21 11:54:11 +02:00
James Frowen
a05df81127
adding if before starting task ( #2021 )
2020-06-21 11:52:32 +02:00
uwee
36c0b65e8b
fixes broken ui for Tanks example ( #2015 )
2020-06-20 23:39:36 +01:00
James Frowen
4af72c3a63
fix: calling base method when the first base class did not have the virtual method ( #2014 )
...
* adding test for error
* adding test with multiple overrides
* calling methods in base type
* adding test for more than 1 override
2020-06-19 00:23:46 +02:00
Chris Langsenkamp
5032ceb000
fix: Clean up roomSlots on clients in NetworkRoomPlayer
2020-06-18 09:44:50 -04:00
Chris Langsenkamp
37338706f9
Remove redundant .transform
2020-06-17 17:35:32 -04:00
James Frowen
8c1ed40c40
adding check before telling clients ( #2010 )
...
* adding check before telling clients
* Update Assets/Mirror/Runtime/NetworkManager.cs
Co-authored-by: MrGadget <chris@clevertech.net>
2020-06-16 12:21:57 -04:00
James Frowen
76d49c1e99
faster write line ( #2009 )
2020-06-16 16:16:58 +01:00
Chris Langsenkamp
b41fca2d28
Changed to inline token injection
2020-06-16 08:29:59 -04:00
James Frowen
46239783f3
feat: adding log handler that sets console color ( #2001 )
...
* adding log handler that sets console color
* fixing stack trace log
* removing empty cases
* removing string.Format
2020-06-15 14:54:35 +02:00
James Frowen
5f0c7ceb52
moving spawn functions next to each other ( #2002 )
2020-06-14 17:33:32 +01:00
Chris Langsenkamp
fffd462df8
fix: Suppress warning
2020-06-13 13:25:07 -04:00
Chris Langsenkamp
23b545fc8a
suppress erroneous warning
2020-06-13 12:34:14 -04:00
James Frowen
5480a583e1
fix: Websockets Transport now handles being disabled for scene changes ( #1994 )
...
* fix: Websockets Transport now handles being disabled for scene changes
* Removed unused method
* Removed test warnings
* Changed back to await Task.Run
* adding queue to ClientJs
keeping standalone client without queue
dont need common class for now as that over complicates the fix
Co-authored-by: Chris Langsenkamp <chris@clevertech.net>
2020-06-13 12:21:13 -04:00
MrGadget
7e2b7338a1
feat: Experimental Network Transform ( #1990 )
...
* feat: Experimental Network Transform
* Removed lastClientSendTime and lastServerSendTime
2020-06-12 16:48:34 +02:00
MrGadget
b962d71944
breaking: Websocket Transport now requires full path to PFX ( #1989 )
...
* breaking: Websocket Transport now requires full path to PFX
* Added HelpURL
2020-06-12 09:38:45 -04:00
Chris Langsenkamp
1dc0d98374
fix: Replaced Icosphere with centered pivot
2020-06-12 09:19:02 -04:00
Chris Langsenkamp
9a42fe3342
fix: WebSockets: Force KeepAliveInterval to Zero
2020-06-12 08:24:13 -04:00
Chris Langsenkamp
285ec968c0
Fix: WebSockets: Force KeepAliveInterval to Zero
2020-06-11 23:07:21 -04:00
James Frowen
781e8070de
fixing using statments ( #1983 )
2020-06-10 21:56:44 +01:00
Chris Langsenkamp
ae3dc04fb9
fix: Removed unused variable
2020-06-10 12:57:46 -04:00
James Frowen
b92da91d7a
fix: Allowing overrides for virtual commands to call base method ( #1944 )
...
* adding override method that calls base
* trying to debug instruction for call to base
* extra tests
* adding tests for client and target Rpc
* adding fix for calls to base class
Since networkbehaviour parents are processed first we can just fix the
method when we see it in SubstituteMethod
2020-06-10 16:11:29 +02:00
James Frowen
2ce5880646
breaking: moving static code from NetworkBehaviour to its own class ( #1951 )
...
* moving static code from NetworkBehaviour to its own class
* Replacing calls in tests to use new RemoteCallHelper
* updating references to types in weaver
* adding version 15 defines
* renaming function
2020-06-10 16:10:54 +02:00
James Frowen
7e93030849
feat: adding script that displays ping ( #1975 )
...
* adding script that displays ping
* fixing style
* adding mirror icon
* Update Assets/Mirror/Components/NetworkPingDisplay.cs
Co-authored-by: MrGadget <chris@clevertech.net>
* adding DisallowMultipleComponent
* adding docs on NetworkPingDisplay
Co-authored-by: MrGadget <chris@clevertech.net>
2020-06-10 14:31:13 +01:00
James Frowen
3db57e5f61
fix: making weaver include public fields in base classes in auto generated Read/Write ( #1977 )
...
* adding test to check if data is sent
* test for generating writer for inherited class
* adding extension method for FindAllPublicFields
2020-06-10 15:12:36 +02:00
James Frowen
dfa2e7aff6
fixing typo ( #1976 )
2020-06-09 12:26:27 +01:00
James Frowen
e39b91efca
removing extra null check ( #1974 )
...
if transform is not null then gameObject will also be not null
2020-06-09 11:32:50 +02:00
Chris Langsenkamp
986975d65e
Set Tanks example to Round Robin
2020-06-08 10:02:19 -04:00
James Frowen
69e58cc870
checking this instead of this.gameobject ( #1973 )
2020-06-08 08:54:34 +02:00
James Frowen
927c4dede5
fix: Replacing ClearDelegates with RemoveDelegates for test ( #1971 )
...
* making ClearDelegates Obsolete
* returning hash from Registering function
* fixing tests
2020-06-08 08:54:00 +02:00
Chris Langsenkamp
14a851fde1
Removed unused variable
2020-06-07 20:12:31 -04:00
Chris Langsenkamp
745741e000
Refinements to player controllers in examples
2020-06-07 20:12:11 -04:00
Chris Langsenkamp
198b2bd605
Refined playercontroller in MultipleAdditiveScenes example
2020-06-07 14:27:38 -04:00
James Frowen
55736eba5e
breaking: adding option to receive NetworkConnectionToClient in Comand ( #1970 )
...
* moving exists check to its own function
* moving order and adding whitespace
* adding SenderConnection Attribute
* adding weaver tests for SenderConnection Attribute
* tests for sender connection
* updating valid method to work with sender connection
* using RemoteCallType in read write calls
* adding sender connection to CallCmd
* updating CmdDelegate
* adding NetworkConnection to invokeFunction
* updating old tests
* removing SenderConnectionAttribute
* typo
* adding version 14 defines
2020-06-07 11:25:21 +01:00
James Frowen
822b04155d
fix: Better errors when trying to replace existing assetid ( #1827 )
...
* allowing assetId to be set at runtime
* removing ignore from tests
* adding errors and warning for settings assetId
* adding tests for settings assetId
* not allowing assetId to be replaced
* fixing test
* giving error when old assetId was not empty
* moving test to runtime
moving base classes to common
* moving more tests to runtime
* changing tests to give error when assetid is changed
* removing un-needed check
* removing NewAssetId tests
2020-06-06 23:09:46 +02:00
James Frowen
fee522b1cf
making log warning ( #1969 )
2020-06-06 22:56:52 +02:00
vis2k
67c604959c
2k Demo: enable GPU Instancing for Monster & Player materials to reduce batches from 8k to 26 when drawing all 2k monsters
2020-06-06 11:06:11 +02:00
MrGadget
864fdd5fdc
feat: Add excludeOwner option to ClientRpc ( #1954 )
...
* WIP
* WIP
* WIP
* WIP
* feat: Add excludeOwner option to ClientRpc
* removed default value
* Fixed tests
* Update Assets/Mirror/Editor/Weaver/Processors/RpcProcessor.cs
Co-authored-by: James Frowen <jamesfrowendev@gmail.com>
* adding weaver test for exlude owner
* adding test for call to exclude owner
* adding comment back
* removing ClientRpcInfo
we don't need ClientRpcInfo as client rpc is only called server side
so we don't need to double check exlucde owner, weaver can handle it
* removing extra register
* fixing test compile errors
* Update Assets/Mirror/Tests/Editor/Weaver/WeaverClientRpcTests~/ClientRpcThatExcludesOwner.cs
* doc: fixed typos in readme
* doc: Updated ChangeLog
* doc: Updated docs for Command ignoreAuthority option
* doc: Updated ChangeLog
* fixing typo in comment (#1963 )
* Removed YouTube link. Link is changing soon. (#1962 )
* Removed YouTube link. Link is changing soon. (#1961 )
* Removed YouTube link. Link is changing soon. (#1960 )
* Removed YouTube link. Link is changing soon. (#1959 )
* Removed YouTube link. Links are changing. (#1958 )
* Removed YouTube link. Links are changing. (#1957 )
* Update NetworkBehavior.md (#1956 )
* fixed comment typo
* doc: Updated Migration guide example
Co-authored-by: James Frowen <jamesfrowendev@gmail.com>
Co-authored-by: FirstGearGames <firstgeargames@gmail.com>
2020-06-05 21:49:36 +02:00
Chris Langsenkamp
b4d0296434
Removed stray //
2020-06-05 02:24:56 -04:00
Chris Langsenkamp
1a1eec9c14
fixed comment typo
2020-06-03 10:34:51 -04:00
James Frowen
2444275401
fixing typo in comment ( #1963 )
2020-06-03 15:11:57 +01:00
James Frowen
e6311ecb37
adding better error message for ResolveMethod ( #1950 )
2020-05-31 19:35:22 +02:00
James Frowen
e736f41470
moving exists check to its own function ( #1948 )
...
* moving exists check to its own function
* moving order and adding whitespace
2020-05-31 19:35:06 +02:00
James Frowen
62257d8c4f
fix: better error for Command, ClientRpc and TargetRpc marked as abstract ( #1947 )
...
* weaver test for virtual and abstract commands
* adding error for abstract methods
* adding base class for command tests and renaming file
* adding tests for virutal commands
* renaming classes to make more sense
* removing whitespace
* adding tests for Client Target Rpc too
* fixing compile error
* fixing message and typo
* removing line
* renaming namespace and base class to be used by Rpc
* tests for calling Rpc
* tests for virtual rpc
* fixing typo
2020-05-30 19:17:29 +02:00
James Frowen
cace9ab840
Refactor weaver 4 ( #1946 )
...
* white space
* renaming parameter name
* renaming parameter name
* making comment look the same as the one in writeArguments
* removing NetworkBehaviourType2 to make code simplier
* whitesapce
2020-05-30 17:38:34 +02:00
James Frowen
b4acf7d9a2
feat: Adding onLocalPlayerChanged to ClientScene for when localPlayer is changed ( #1920 )
...
* adding onLocalPlayerChanged event
* Update Assets/Mirror/Runtime/ClientScene.cs
Co-authored-by: MrGadget <chris@clevertech.net>
Co-authored-by: MrGadget <chris@clevertech.net>
2020-05-30 15:45:49 +02:00
James Frowen
3a35b0e9de
adding extension methods ( #1938 )
2020-05-30 15:43:32 +02:00
James Frowen
26c02199ba
renaming function ( #1937 )
...
* renaming function
* adding more comments
2020-05-30 15:43:14 +02:00
James Frowen
b1e47d5b6a
adding RemoteCallType ( #1936 )
...
* adding RemoteCallType
* Update Assets/Mirror/Editor/Weaver/Processors/NetworkBehaviourProcessor.cs
2020-05-30 15:42:34 +02:00
James Frowen
7205d3a705
Clean up test scripts ( #1942 )
...
* fixing white space
* sorting using statements
2020-05-29 18:55:12 -04:00
James Frowen
3f9f3c8298
Clean up scripts ( #1941 )
...
* fixing white space
* sorting using statements
2020-05-29 18:54:56 -04:00
Chris Langsenkamp
e49313bfd2
Lowered Tanks example Projectile destroyAfter to 1
2020-05-29 13:58:34 -04:00
Chris Langsenkamp
d5a0bc740f
Added Projectile to NetworkManager's Spawnables list in Tanks example
2020-05-29 13:57:59 -04:00
Chris Langsenkamp
bf624fa917
Reset Tanks Projectile Prefab
2020-05-29 13:56:52 -04:00
MrGadget
3ace2c6eb6
feat: Adding ignoreAuthority Option to Command ( #1918 )
...
* Add ignoreAuthority to weaver
* Add ignoreAuthority to CommandAttribute
* Add NetworkConnection to handlers
* Pass conn parameter from OnCommandMessage
* Add ignoreAuthority to SendCommandInternal
Add NetworkConnection param to CmdDelegate
Add NetworkConnection param to InvokeCommand
Pass conn to InvokeHandlerDelegate
Pass conn to invoker.invokeFunction
* Update tests with optional NetworkConnection param
* adding commandInfo
* fixing test calls
* renaming arguments
* adding ignoreAuthority to register call
* weaver tests for ignore authority
* tests for command ignoreAuthority
* adding debug assert to make sure tests is running correct
* moving variables up
* removing un-needed code
* updating tests
Co-authored-by: James Frowen <jamesfrowendev@gmail.com>
2020-05-28 11:54:12 +02:00
Chris Langsenkamp
8721d05fff
Moved FinishLoadSceneServerOnly up to match call order
2020-05-27 22:57:41 -04:00
Chris Langsenkamp
7d9175dfc7
Moved GetStartPosition to correct region
2020-05-27 22:51:26 -04:00
James Frowen
9ae7fa2a8c
feat: adding OnRoomServerPlayersNotReady to NetworkRoomManager that is called when player ready changes and atleast 1 player is not ready ( #1921 )
...
* adding virtual function for Players not ready
* moving function calls to property
* making if check easier to read
* setting field
* making field private
* removed blank line
* Added override to template
* doc: Updated ChangeLog
Co-authored-by: Chris Langsenkamp <chris@clevertech.net>
2020-05-27 15:42:18 -04:00
James Frowen
64533ca4da
Fixing optional network connection ( #1934 )
...
* adding tests for optional NetworkConnection
* fixing validate to allow optional NetworkConnection
* fixing error message in test
2020-05-27 18:09:35 +01:00
Chris Langsenkamp
d9b7bb7357
fix: OnClientEnterRoom should only fire on clients
2020-05-27 12:15:52 -04:00
Chris Langsenkamp
0c3e079d04
feat: Added virtual SyncVar hook for index in NetworkRoomPlayer
2020-05-27 11:57:35 -04:00
James Frowen
52aa62af6d
Updating target rpc tests ( #1933 )
...
* fixing the TargetRpc Test class
moving SyncEvent Tests to their own folder
renaming tests to be readable
* removing meta file from csproj
* fixing typo
* sync event tests
* fixing typo
* fixing typo
* fixing errors in tests
* fixing name in test message
* error for first param not NetworkConnection for targetRpc
* adding error if no paremeters
2020-05-27 16:22:46 +01:00
James Frowen
210796cff8
moving lastMessageTime to other constructor ( #1924 )
...
making extra constrctor call empty one
2020-05-27 00:05:57 +02:00
James Frowen
59f8e9b794
renaming all ILProcessor to be called worker ( #1926 )
2020-05-27 00:04:18 +02:00
uwee
218faa85d5
Tank example fixes ( #1928 )
...
* move game state out of NetMan
* update scene for script movement
2020-05-27 00:03:58 +02:00
James Frowen
03486997fb
fix: no longer requires hook to be the first overload in a class ( #1913 )
...
* test for sync var hook order
* adding extension method
* allowing hook method to be in any order
* adding second hard to test functions
2020-05-24 16:05:50 +02:00
James Frowen
e9d9bae397
renaming arguments ( #1919 )
2020-05-24 14:11:10 +01:00
uwee
ee3e29de9c
Gamify Tanks Example ( #1906 )
...
* add health lives and score to Tank
* add damage and a source object to projectile
* update prefabs to use new vars
* add gamecontroller to manage state and UI
* update scene to use new gamecontroller and ui
* retag as player
* code cleanup
* replaced GameController with a custom NetMan
* removed lives and respawning. added state management
* scene and prefab updates
* fix billboarding for player names
* fix: cant win game when alone
* darker menu colors
2020-05-23 09:49:04 +02:00
Chris Langsenkamp
9af63b8ced
fixed typo
2020-05-23 02:53:45 -04:00
Chris Langsenkamp
90a0d366da
fix comment
2020-05-23 02:53:15 -04:00
Chris Langsenkamp
12c38c4715
NetworkManager:RegisterClientMessages can use RegisterHandler instead of ReplaceHandler.
2020-05-23 02:49:31 -04:00
James Frowen
1c2bb2c6a3
Tests for static syncvar hooks ( #1912 )
...
* tests for static hooks
* csproj
2020-05-21 10:40:53 +02:00
James Frowen
0b2dd5fd36
moving writing of syncvar hook to once place ( #1910 )
...
* moving writing of syncvar hook to once place
* fixing typo in comment
2020-05-21 10:40:36 +02:00
MrGadget
7d4c0a9cb6
feat: Use SortedDictionary for LogSettings ( #1914 )
...
* feat: Use SortedDictionary for LogSettings
* Remove manual sort
2020-05-21 10:39:48 +02:00
Chris Langsenkamp
6c8ff77bc1
Added headers to LogSettings window & component
2020-05-20 16:04:01 -04:00
Chris Langsenkamp
c7d8c0933d
feat: Prettify Log Names
2020-05-20 14:33:22 -04:00
James Frowen
efef55318c
deleting old files ( #1905 )
2020-05-20 10:58:22 -04:00
James Frowen
1b9e51b801
moving comment to right place ( #1911 )
2020-05-20 15:14:21 +01:00
James Frowen
f14639bc3d
Syncvar hook weaver tests ( #1909 )
...
* removing old sync var test
moving them to their own class
* weaver test for sync var hooks
* better error messages
2020-05-20 14:53:23 +01:00
James Frowen
e7c5558968
Syncvar hook tests ( #1908 )
...
* SyncVar hook tests
* moving tests for virtual sync hook
* white space and function names
2020-05-20 14:51:30 +01:00
Chris Langsenkamp
c45deb808e
fix: Fixed Capitalization
2020-05-19 10:54:50 -04:00
Chris Langsenkamp
0cf5f27421
Changed NetworkRoomPlayer to use virtual SyncVar hook
2020-05-19 10:31:27 -04:00
James Frowen
94795c50fb
Moving weaver comments ( #1904 )
...
* Moving weaver comments
* removing extra line
2020-05-19 14:07:57 +01:00
James Frowen
866808438a
splitting code into multiple functions ( #1903 )
2020-05-19 13:50:44 +01:00
Chris Langsenkamp
f989b0fb11
doc: fixed crefs in xml comments
2020-05-18 15:38:06 -04:00
Chris Langsenkamp
8a58c31b48
doc: fixed cref's in XML comments
2020-05-18 15:01:31 -04:00
James Frowen
db773caab4
showing sync settings for non visable syncvar ( #1899 )
2020-05-18 19:52:36 +01:00
Chris Langsenkamp
042b4e1965
feat: Improved RoomPayer template
2020-05-18 14:18:43 -04:00
James Frowen
63ad7ffd20
adding warning to connect ( #1874 )
...
warning when client tries to connnect when a connection already exists
2020-05-18 16:06:07 +02:00
James Frowen
73022c8bbc
Cleanup changes ( #1897 )
...
* renaming variable to be more clear
* stopping items from being included by default
2020-05-16 01:09:21 +01:00
James Frowen
fe8e0c2e0e
fixing typo ( #1895 )
2020-05-15 12:51:38 +01:00
James Frowen
55be68ba05
Cleaning up csproj
2020-05-15 12:11:43 +01:00
James Frowen
97ff37e526
adding csproj file to make it easier to edit weaver tests ( #1894 )
2020-05-15 11:40:46 +01:00
James Frowen
138bb40450
Adding tests and clean up logs ( #1891 )
...
* adding test for sync list with using a class
* adding length check to synclist tests
* adding clear test
fixing Contains check
* fixing index
2020-05-14 19:50:58 +01:00
James Frowen
f63483bda7
Adding active check to NetworkServer.SendToAll ( #1890 )
...
* adding active check to SendToAll
* fixing identical call
* removing regex
* removing ; at end of file
* fixing typo in error message
2020-05-14 19:11:47 +01:00
James Frowen
bd6cd2164d
making error easier to read in the code ( #1892 )
2020-05-14 19:07:32 +01:00
MrGadget
05c119f505
fix: Don't call RegisterClientMessages every scene change ( #1865 )
2020-05-14 13:40:57 +02:00
James Frowen
69b845183c
feat: Improved Log Settings Window Appearance ( #1885 )
...
* setting window min size
* using Layout scopes
* adding scroll bar
* setting label and field widths
2020-05-12 16:34:24 +01:00
James Frowen
37323d319b
settings lastMessageTime to current time ( #1879 )
2020-05-11 10:28:48 +02:00
James Frowen
d8aaf76fb9
feat: Creating method to replace all log handlers ( #1880 )
...
* adding ReplaceLogHandler to LogFactory
* property to get all loggers
2020-05-11 10:28:17 +02:00
James Frowen
30a610d4e3
Setting default log level to error ( #1882 )
...
These warning only used to be enabled when debugfilter was on
2020-05-11 10:27:53 +02:00
Devon Merner
eb7c87d15a
feat: add SyncList.RemoveAll ( #1881 )
...
* Added SyncList.RemoveAll and unit test.
* Added RemoveAllNone unit test for SyncList
* SyncList.RemoveAll cleanup
* RemoveAll no longer calls collections .Add
Unit tests for SyncList.RemoveAll now check clientSyncList.
2020-05-11 10:27:32 +02:00
Devon Merner
e9ea117e61
Added SyncList.AddRange and InsertRange ( #1883 )
2020-05-11 10:27:06 +02:00
uwee
381adaa8f2
add logger to all classes that have logging but no logger ( #1861 )
...
* add logger to all classes that have logging but no logger
have not updated all of the debugs in the classes yet as the logger implementation has still not been decided.
* add logger to all classes that were missed
* update logger refs in BasicAuthenticator
* update logger refs in TimeoutAuthenticator
* update logger refs in NetworkAnimator
* update logger refs in NetworkRoomManager
* update logger refs in NetworkRoomPlayer
* update logger refs in NetworkSceneChecker
* update logger refs in AdditiveNetworkManager
* update logger refs in ZoneHandler
* update logger refs in ChatWindow
* update logger refs in ListServer
* update logger refs in Reward
* update logger refs in Reward
* update logger refs in NetworkRoomPlayerExt
* update logger refs in LocalConnections
* update logger refs in MessagePacker
* update logger refs in NetworkBehaviour
* update logger refs in NetworkManager
* update logger refs in NetworkReader
* update logger refs in NetworkReaderPool
* update logger refs in NetworkServer
* update logger refs in NetworkTime
* update logger refs in NetworkWriter
* update logger refs in NetworkWriterPool
* update to use logger log enabled
* remove if logfilter debug as log is not concatenated
* add if logger enabled check to concatenated strings
* Update Assets/Mirror/Authenticators/BasicAuthenticator.cs
Co-authored-by: James Frowen <jamesfrowendev@gmail.com>
* suggested fixes
* remove unused logger
* changed to warning
Co-authored-by: James Frowen <jamesfrowendev@gmail.com>
2020-05-10 23:00:37 +01:00
James Frowen
a264583944
adding try catch to DestroyAllClientObjects ( #1862 )
2020-05-10 10:17:42 +02:00
James Frowen
1fbaf1ba23
Moving CleanupNetworkIdentities to NetworkServer ( #1867 )
...
* moving CleanupNetworkIdentities to NetworkServer
NetworkClient already cleans up spawned dictionary
* using GameObject.Destroy
* adding null check
* tests for NetworkServer.Shutdown
2020-05-10 10:14:18 +02:00
James Frowen
1cd31663a5
Creating LocalConnectionId constant ( #1869 )
...
Avoid using magic numbers
2020-05-10 10:13:43 +02:00
James Frowen
f5d02906c0
Removing host setup from networkserver test ( #1868 )
...
* Removing host setup
Only set up the minimum in order to test a feature
* moving to new file
* inverting if
* removing extra line
* fixing test for headless
2020-05-09 21:53:29 +01:00
James Frowen
b069a6ce27
clearing dictionary in test teardown ( #1871 )
2020-05-09 17:18:22 +01:00
James Frowen
11ed61aa61
adding namespace ( #1870 )
2020-05-09 17:18:14 +01:00
James Frowen
4c25122958
fix: Cleaning up network objects when server stops ( #1864 )
...
* destroying or disabling network objects when server stops
* adding clear after loop
* Update Assets/Mirror/Runtime/NetworkManager.cs
Co-authored-by: MrGadget <chris@clevertech.net>
* Update Assets/Mirror/Runtime/NetworkManager.cs
Co-authored-by: MrGadget <chris@clevertech.net>
* Update Assets/Mirror/Runtime/NetworkManager.cs
Co-authored-by: MrGadget <chris@clevertech.net>
2020-05-09 10:42:06 +01:00
Chris Langsenkamp
b4511a0637
fix: Prevent host client redundantly changing to offline scene
2020-05-09 01:28:30 -04:00
uwee
2108456021
Fix comments ( #1860 )
...
* fix ref to NetMan in Authenticator
* does not return
* added basic description of return conditions
* comment is 2 years old from HLAPI 2017.4 and no longer relevant
* remove empty whitespace
* Update Assets/Mirror/Runtime/NetworkConnection.cs
* Update Assets/Mirror/Runtime/NetworkServer.cs
* Update Assets/Mirror/Runtime/NetworkAuthenticator.cs
* Update Assets/Mirror/Runtime/NetworkServer.cs
* Update Assets/Mirror/Runtime/NetworkServer.cs
Co-authored-by: MrGadget <chris@clevertech.net>
2020-05-08 21:41:57 -04:00
James Frowen
ad782a59a7
adding assert extension method ( #1804 )
2020-05-09 00:24:05 +01:00
James Frowen
fd4357cd26
feat: LogSettings that can be saved and included in a build ( #1863 )
...
* Moving code that draws the log levels to its own class
this allows other scripts to use the same code to draw the log levels
* adding LogSettings to store the log levels
* adding GUI method to create LogSettings
* Creating Editor for LogSettings that uses LogLevelsGUI
* adding helper to find Existing LogSettings
* Adding field to LogLevelWindow to use LogSettings
* Adding LogSettings to drawer and save on changed check
* fixing field default value of null so that c# compiler doesnt complain
* loading existing settings into LogFactory when the editor starts
* component to load log settings in a build
* changing namespace
* Moving logging scripts to subfolder
* NetworkLogSettings editor
Makes the component use the same gui as the Window and ScriptableObject
* Making NetworkLogSettings find existing settings on Reset
reset is called when component is added
* adding attributes
* adding docs
* adding icon
* doc.
* documentation and images
* fixing image extension
* Update Assets/Mirror/Runtime/Logging/EditorLogSettingsLoader.cs
Co-authored-by: vis2k <info@noobtuts.com>
Co-authored-by: vis2k <info@noobtuts.com>
2020-05-08 23:51:21 +01:00
James Frowen
eed1ddc090
renaming player to ownerPlayer ( #1859 )
2020-05-08 00:04:57 +01:00
MrGadget
2c40c71557
Simplify 2K Example ( #1857 )
2020-05-07 13:29:33 +02:00
Chris Langsenkamp
b2f52d7892
fix: Removed unnecessary registration of player prefab in NetworkRoomManager
2020-05-07 04:45:03 -04:00
Chris Langsenkamp
38c8bb4dda
Removed stray leftover comment
2020-05-07 03:56:09 -04:00
Chris Langsenkamp
0be4e5b999
Fixed 2 typos
2020-05-07 03:41:15 -04:00
Chris Langsenkamp
3179f08e3d
fix: NetworkRoomManager.minPlayers is now protected so it's available for derived classes.
2020-05-07 02:41:58 -04:00
Chris Langsenkamp
fb927f8141
fix: Added ClientOnly check
2020-05-06 14:07:44 -04:00
James Frowen
53512cab35
Cleaning up some code ( #1854 )
...
* rename to validPrefabNetworkIdentity
* typo
* moving code to base class
* removing protected
2020-05-05 15:59:02 +01:00
vis2k
2d89f059af
perf: NetworkProximityChecker checks Server.connections instead of doing 10k sphere casts for 10k monsters. 2k NetworkTransforms demo is significantly faster. Stable 80fps instead of 500ms freezes in between. ( #1852 )
2020-05-05 09:54:11 +02:00
Chris Langsenkamp
201411d7f4
Fixed Observer Template
2020-05-05 00:37:21 -04:00
James Frowen
bd49fe4d9d
adding ignoreFailingMessages around error logging ( #1803 )
2020-05-04 18:14:42 +01:00
James Frowen
a88d2e6be1
tests for ClientScene.DestroyAllClientObjects ( #1850 )
...
* tests for ClientScene.DestroyAllClientObjects
* adding test for list being clear
* removing extra line
2020-05-04 17:15:56 +01:00
James Frowen
8b0958e24c
adding namespace ( #1851 )
2020-05-04 17:11:47 +01:00
vis2k
ecb10eb965
2k NetworkTransforms ( #1849 )
2020-05-04 17:52:00 +02:00
James Frowen
bb7765e0c1
Test cleanup ( #1847 )
...
* cleaning up objects after test
* test clean up
2020-05-04 13:10:22 +01:00
James Frowen
2c11cc8393
tests for ClientScene.PrepareToSpawnSceneObjects ( #1846 )
...
* tests for ClientScene.PrepareToSpawnSceneObjects
* removing line
2020-05-04 12:54:43 +01:00
James Frowen
64e52bf31e
Moving classes to their own files ( #1845 )
2020-05-04 10:59:38 +01:00
James Frowen
c9db7e3754
Moving Client scene tests to their own class per method ( #1843 )
...
* fixing comments
* adding extra lines
* moving tests to their own class per method
2020-05-04 10:33:32 +01:00
James Frowen
ca6fd99242
Clean up after breaking ( #1844 )
...
* adding new define to project settings
* Marking test for RemovePlayerMessage as Obsolete
2020-05-04 10:17:13 +01:00
James Frowen
54071da3af
fix: Improved error checking for ClientScene.RegisterPrefab with handler ( #1841 )
...
* test for RegisterPrefab with handler
* comments
* finishing tests and ignore some cases
* updating checks and log messages
* more tests
* removing test cases
2020-05-04 10:55:36 +02:00
Chris Langsenkamp
ed27578f91
Fixed comment
2020-05-03 12:29:14 -04:00
Chris Langsenkamp
477de07003
Updated ReadMe
2020-05-03 12:11:27 -04:00
Chris Langsenkamp
0cf92e9064
Reset Instances to default (3)
2020-05-03 12:11:08 -04:00
MrGadget
75f3975041
breaking: Eliminates RemovePlayerMessage As Security Risk ( #1835 )
...
* fix: Deprecate RemovePlayerMessage As Security Risk
* Updated PreprocessorDefine
* Updating for changes in master
* Updating for changes in master
* Removed the error flag so tests could still pass
2020-05-03 16:45:53 +02:00
MrGadget
2a08aac7cb
fix: Don't call RegisterClientMessages twice ( #1842 )
2020-05-03 16:43:00 +02:00
MrGadget
87c6ebc5dd
feat: Multiple Concurrent Additive Physics Scenes Example ( #1686 )
...
* Stop using sceneIds at runtime
* Multiple Additive Physics Scenes Example
* Remove Commented code
* Remove boilerplate code
* breaking: Network Visibility Component
* Revert changes to NetworkIdentity
* Updated scene lighting
* Don't rename spawned objects
* Simplified Physics Simulator
* Updated PhysicsSimulator
* Fixed camera restore
* moved subScenes.Clear up
* Updated Prefabs
* Updated Scenes
* Updated PhysicsSimulator
* Updated PlayerController
* Updated scoring to server authoritative
* Updated Main scene
* Updated Example to master
* Made subScenes readonly
* Restored old jump code
* Revert "Restored old jump code"
This reverts commit 6a986fb088
2020-05-03 16:42:28 +02:00
James Frowen
f4e2e1c153
Allowing tests cases to better call overloads ( #1838 )
...
* allowing tests cases to better call overloads
* fixing warning test cases
* adding comment
2020-05-03 14:32:09 +01:00
MrGadget
e3790c51eb
feat: Add NetworkServer.RemovePlayerForConnection ( #1772 )
...
* feat: Add NetworkServer.RemovePlayerForConnection
* Fixed Obsolete tag
* Added bool destroyServerObject and comments
* Making this a breaking change
* No longer a breaking change
* Added RemovePlayerForConnectionTest
* Debrecation with pragmas
* Splitting the PR
* Splitting PR's
* Updated tests
* splitting PR's
2020-05-03 15:22:32 +02:00
James Frowen
71ebcdc006
making fields readonly ( #1840 )
...
adding more comments to PrepareToSpawnSceneObjects
2020-05-03 15:13:57 +02:00
James Frowen
7de3c74614
adding enabled check to loops ( #1836 )
...
Message can disable transport so we need to check if it is still enabled
before checking the next message
2020-05-03 15:12:32 +02:00
James Frowen
ff4a576b13
Fixing code smell in clientscene ( #1839 )
...
* moving overloads next to each other
* moving function so that RegisterPrefab are together
* making if statment more readable
2020-05-03 11:29:42 +01:00
James Frowen
eeb4c4b5b4
making test case match others ( #1837 )
2020-05-03 10:55:39 +01:00
Chris Langsenkamp
d0e15b1378
Setting older obsoletes to errors for next release
2020-05-02 18:48:12 -04:00
James Frowen
a700d7afc3
Fixing runtime tests ( #1833 )
...
* adding assetId to prefab
* making sure NetworkManager is shutdown
* removing host set up for test that doesn't need it
* using OneTimeTearDown
* fixing performance test
2020-05-02 16:14:38 +01:00
James Frowen
2b5ad08260
adding ignore ( #1832 )
...
see ignore message
2020-05-02 15:26:21 +01:00
vis2k
d3dccd7a25
fix : #1659 Telepathy LateUpdate processes a limited amount of messages per tick to avoid deadlocks ( #1830 )
...
* fix : #1659 Telepathy LateUpdate processes a limited amount of messages per tick to avoid deadlocks
* Update Assets/Mirror/Runtime/Transport/TelepathyTransport.cs
Co-authored-by: James Frowen <jamesfrowendev@gmail.com>
* Update Assets/Mirror/Runtime/Transport/TelepathyTransport.cs
Co-authored-by: James Frowen <jamesfrowendev@gmail.com>
Co-authored-by: James Frowen <jamesfrowendev@gmail.com>
2020-05-02 15:24:42 +02:00
MrGadget
a6ab3527ac
fix: clear all message handlers on Shutdown ( #1829 )
2020-05-02 11:40:49 +02:00
James Frowen
d6a4d8fbf6
fixing showDebugMessages with new logger ( #1824 )
2020-05-02 11:25:50 +02:00
Chris Langsenkamp
ab3f353b33
fix: Wrong method names in ClientSceneTests
2020-05-02 00:02:37 -04:00
James Frowen
9f59e0c439
fix: Adding warning when adding prefab with RegisterPrefab if assetid already exists ( #1828 )
2020-05-02 01:36:59 +01:00
James Frowen
7f26329e2d
fix: Adding warning when adding handler with RegisterSpawnHandler if assetid already exists ( #1819 )
...
* adding test for warning for existing handler
* adding warning for existing handler
* adding error for prefab existing with assetId
2020-05-02 01:35:45 +01:00
James Frowen
a0aa4f9c14
fix: Improved error checking for ClientScene.RegisterPrefab ( #1823 )
...
* Tests for ClientScene.RegisterPrefab
* Improved error messages for ClientScene.RegisterPrefab
2020-05-02 01:29:55 +01:00
Chris Langsenkamp
5fddcc8525
Added braces
2020-05-01 14:06:17 -04:00
James Frowen
096ce20fbd
Tests client scene 5 ( #1818 )
...
* tests for ClientScene.UnregisterSpawnHandler
* splitting errors for handlers
* adding error for empty guid
* adding check to stop null handler inside lambda
2020-05-01 09:48:58 +02:00
Chris Langsenkamp
ffc276cb79
fix: Use ReplaceHandler instead of RegisterHandler in NetworkManager
2020-04-30 22:07:00 -04:00
James Frowen
fd929e2b6d
fixing syncmode not showing up in Inspector ( #1820 )
...
syncMode and syncInterval now show up in Inspector when only sync vars are used
2020-04-30 19:43:33 -04:00
James Frowen
63e61bcbf4
fixing error message ( #1805 )
...
LogError was incorrectly adding tag to message
2020-04-30 21:49:44 +01:00
James Frowen
8e7dec319a
adding method overloads for seting newAssetId ( #1806 )
...
RegisterPrefab(GameObject prefab) has the option to add new AssetId but
the versions that add custom spawn handlers did not have this option
2020-04-30 10:57:51 +02:00
James Frowen
9270765beb
fix: Fixing ClientScene UnregisterPrefab ( #1815 )
...
* adding error if prefab is null
* fixing prefab not being removed
2020-04-30 10:55:48 +02:00
James Frowen
66728cdeef
tests for ClientScene.UnregisterSpawnHandler ( #1816 )
2020-04-29 23:29:00 +01:00
James Frowen
4b2162f6a0
tests for ClientScene.ClearSpawners ( #1813 )
2020-04-29 17:10:25 +01:00
James Frowen
67df03cb8f
tests for ClientScene.UnregisterPrefab ( #1812 )
...
* making ClientScene dictionaries internal
* tests for ClientScene.UnregisterPrefab
* adding OneTimeSetUp for loading prefabs
2020-04-29 16:48:34 +01:00
James Frowen
bf59c6f32b
tests for ClientScene.GetPrefab ( #1811 )
2020-04-29 16:00:07 +01:00
James Frowen
877f4e9c72
feat: Adding ReplaceHandler functions to NetworkServer and NetworkClient ( #1775 )
...
* Replacing debug log with warning
Replacing a handler by mistake will lead to code not running when it is
expected to.
* adding ReplaceHandler methods
* improving warning messages
* using ReplaceHandler in networkManager
* fixing doc comments for RegisterHandler
* fixing doc comments for ReplaceHandler
* Update Assets/Mirror/Runtime/NetworkManager.cs
Co-Authored-By: MrGadget <chris@clevertech.net>
* improving doc comments
* improving doc comments for new code
* Update Assets/Mirror/Runtime/NetworkServer.cs
Co-Authored-By: MrGadget <chris@clevertech.net>
* Update Assets/Mirror/Runtime/NetworkClient.cs
Co-Authored-By: MrGadget <chris@clevertech.net>
Co-authored-by: MrGadget <chris@clevertech.net>
2020-04-29 11:27:28 +01:00
James Frowen
0844c495a1
renaming test assembly ( #1808 )
2020-04-28 19:21:50 +01:00
Justin Vitale
5295075e78
Fix summary mistake for connectionToServer ( #1807 )
2020-04-28 12:38:06 -04:00
Chris Langsenkamp
06bd1f87c4
Updated Example Scene Files
2020-04-28 01:41:57 -04:00
James Frowen
e32a9b6f0b
feat: Allowing Multiple Concurrent Additive Scenes ( #1697 )
...
* There's no need for handling scene ids at runtime.
* Adding tests for Instantiate On Scene object
* removing ExecuteInEditMode
none of our function do anything at edit time so removing this tag
* adding check to awake to stop Instantiate
* code style and comments
* using logger for new error
Co-authored-by: Chris Langsenkamp <chris@clevertech.net>
2020-04-27 18:50:41 -04:00
Chris Langsenkamp
e0d8c918cd
Added DisallowMultipleComponent where appropriate
2020-04-27 11:28:50 -04:00
Chris Langsenkamp
7f8476b2e9
Room Example Server Auth Scoring
2020-04-27 01:21:53 -04:00
James Frowen
6065afd9f6
adding counter since we might send less than connections.Count ( #1782 )
2020-04-27 00:23:06 -04:00
Chris Langsenkamp
267827b15a
remove privates
2020-04-26 16:28:38 -04:00
Chris Langsenkamp
0187b2082f
removed privates
2020-04-26 16:21:10 -04:00
Paul Pacheco
b3656a9edc
feat: ClientScene uses log window
2020-04-26 14:11:55 -05:00
Paul Pacheco
2e39e13c01
feat: NetworkIdentity use logger framework
2020-04-26 14:06:40 -05:00
Paul Pacheco
72154f1dad
feat: NetworkConnection to client and server use logger framework
2020-04-26 13:56:42 -05:00
Paul Pacheco
ec319a165d
feat: NetworkConnection uses logging framework
2020-04-26 13:53:55 -05:00
Paul Pacheco
8b4f1051f2
feat: NetworkServer uses new logging framework
2020-04-26 13:45:30 -05:00
Paul Pacheco
aea8db25c1
Each test file in a separate namespace ( #1785 )
...
* Each test file in a separate namespace
* Fix tests
2020-04-26 11:49:47 -05:00
James Frowen
0383df95ef
making mono cecil editor only ( #1783 )
2020-04-26 11:33:40 -05:00
MrGadget
f6545d4871
feat: NetworkServer.SendToReady ( #1773 )
...
* feat: NetworkServer.SendToReady
* Added ready check and default channel
* Changed to optional parameter
* Added shorthand overload SendToReady
* Added comment
2020-04-26 10:59:06 +02:00
MrGadget
34a76a2834
feat: Allow Multiple Network Animator ( #1778 )
2020-04-26 10:57:42 +02:00
Paul Pacheco
b3cbd5c2a1
Remove redundant check, can be done once in setup
2020-04-25 20:19:18 -05:00
Paul Pacheco
462a311fff
Remove redundant check, can be done once in setup ( #1781 )
...
* Remove redundant check, can be done once in setup
* Update Assets/Mirror/Tests/Editor/Weaver/WeaverNetworkBehaviourTests.cs
* Update Assets/Mirror/Tests/Editor/Weaver/WeaverTests.cs
Co-Authored-By: James Frowen <jamesfrowendev@gmail.com>
Co-authored-by: James Frowen <jamesfrowendev@gmail.com>
2020-04-25 19:53:29 -05:00
Paul Pacheco
bcd76c5bdc
feat: Improve weaver error messages ( #1779 )
...
feat: Improve weaver error messages
Weaver error messages are easier to read and always display
location of error
2020-04-25 19:06:08 -05:00
Chris Langsenkamp
d6d702a918
updated comment
2020-04-25 13:45:39 -04:00
Chris Langsenkamp
345da764b9
fixed comments
2020-04-25 13:32:02 -04:00
James Frowen
d6441e8772
Tests for enums ( #1774 )
...
* weaver test to make sure enums compile
* test for weaver generated and custom readwrite
2020-04-25 10:41:16 +02:00
Chris Langsenkamp
096a23217e
Updated comments
2020-04-24 13:39:58 -04:00
Chris Langsenkamp
9d36815271
fixed comments
2020-04-24 12:58:24 -04:00
Chris Langsenkamp
38ec9b7082
Renamed serverIdleTimeout to disconnectInactiveTimeout
2020-04-24 06:25:02 -04:00
James Frowen
e346885ff5
adding namespace to runtime tests ( #1769 )
2020-04-24 09:58:27 +01:00
James Frowen
1af5b4ed2f
fix: weaver syncLists now checks for SerializeItem in base class ( #1768 )
...
* tests for override in base class
* fixing overrides in base class
* moving check up so that typedef cant be null for the check
2020-04-24 09:30:18 +02:00
James Frowen
d4f834ac08
test for sync list using interface ( #1767 )
2020-04-23 21:51:33 +02:00
MrGadget
a2eb666f15
feat: Disconnect Dead Clients ( #1724 )
...
* feat: Disconnect Dead Clients
* Moved code to NetworkConnectionToClient
* Fixed type
* WIP
* Trying to solve the mystery of the Host
* Updated Example
* fixed comment whitespace
* Final Cleanup and Unit Test
* Removed extra warning
* Reverted change to scene file
* Changed to Play test, still not working
* Added NetworkServer.Update time loop
* Removed commented code
* fixed comment
* Filled in ServerDisconnect so it behaves as expected.
* fixed comment
* Renamed to bool IsClientAlive
* Should be greater than
* Added override that shouldn't be necessary.
* changed asserts per Paul
* Flipped < back
* Shortened test time
* Corrected comment
* Lost the 1
* Updated NetworkServerTest
* Update Assets/Mirror/Tests/Runtime/NetworkServerTest.cs
* Added bool checkInactiveConnections
* Tests for sync dictionary and sync set (#1753 )
* sync dictionary tests
* rename
* changing error message
* sync set tests
* silence unused method warning
* test class name matches file name
* test class name matches file name
* test class name matches file name
* test class name matches file name
* test class name matches file name
* test class name matches file name
* test class name matches file name
* Scope syncdict tests to their classes
* Scope synclists tests to their classes
* Scope syncset tests to their classes
* test class name matches file name
* Scope sample classes
* test class name matches file name
* fix: call the virtual OnRoomServerDisconnect before the base
* fixed name
* doc: Updated docs
* Moved serverIdleTimeout to NetworkManager
* fixed test to enable disconnectInactiveConnections
* Copied disconnectInactiveConnections & serverIdleTimeout to NetworkServer
Co-authored-by: James Frowen <jamesfrowendev@gmail.com>
Co-authored-by: Paul Pacheco <paulpach@gmail.com>
2020-04-23 21:50:35 +02:00
James Frowen
c1bacc345c
using MemoryTransport to make test more stable ( #1770 )
2020-04-23 17:41:15 +01:00
James Frowen
7f8733ce6a
feat: Exclude fields from weaver's automatic Read/Write using System.NonSerialized attribute ( #1727 )
...
* adding test class for NonSerialized
* checking for IsNotSerialized
2020-04-23 16:38:45 +02:00
Chris Langsenkamp
e6881ef007
fix: call the virtual OnRoomServerDisconnect before the base
2020-04-23 02:02:21 -04:00
Paul Pacheco
fb489c67e8
test class name matches file name
2020-04-22 20:58:22 -05:00
Paul Pacheco
2ad16332f3
Scope sample classes
2020-04-22 20:54:08 -05:00
Paul Pacheco
d0df3e8b90
test class name matches file name
2020-04-22 20:51:49 -05:00
Paul Pacheco
d8e5f0d023
Scope syncset tests to their classes
2020-04-22 20:45:45 -05:00
Paul Pacheco
a0689cd357
Scope synclists tests to their classes
2020-04-22 20:38:45 -05:00
Paul Pacheco
f218259be8
Scope syncdict tests to their classes
2020-04-22 20:11:21 -05:00
Paul Pacheco
6066ca2aa0
test class name matches file name
2020-04-22 19:50:55 -05:00
Paul Pacheco
c704bc123f
test class name matches file name
2020-04-22 17:56:41 -05:00
Paul Pacheco
94603d175a
test class name matches file name
2020-04-22 17:47:45 -05:00
Paul Pacheco
12ea5f25e0
test class name matches file name
2020-04-22 17:43:59 -05:00
Paul Pacheco
a2b6fb08f3
test class name matches file name
2020-04-22 17:42:25 -05:00
Paul Pacheco
dfffe26390
test class name matches file name
2020-04-22 17:40:32 -05:00
Paul Pacheco
5214b57db5
test class name matches file name
2020-04-22 17:35:39 -05:00
Paul Pacheco
95bb9cb0e3
silence unused method warning
2020-04-22 12:21:32 -05:00
James Frowen
1614c68629
Tests for sync dictionary and sync set ( #1753 )
...
* sync dictionary tests
* rename
* changing error message
* sync set tests
2020-04-22 18:54:09 +02:00
Chris Langsenkamp
cf6823acb5
fix: Removed NetworkServer.Listen because HostSetup does that
2020-04-22 06:39:46 -04:00
Chris Langsenkamp
984945e482
fix: Removed NetworkClient.Update because NetworkManager does it in LateUpdate
2020-04-22 06:34:34 -04:00
Chris Langsenkamp
bdec276282
fix: Add the transport first so NetworkManager doesn't add Telepathy in OnValidate
2020-04-22 06:32:26 -04:00
James Frowen
9bf816a014
feat: Allowing extra base types to be used for SyncLists and other SyncObjects ( #1729 )
...
* Tests for most uses of sync list
renaming classes for existing test files
* improving error message for Paramless constructor
* More tests for SyncLists
* updating error message
* ignore abstract classes
we dont need to process abstract classes because classes that
inherit from them will be processed instead
* check and error for syncList item being genric
* allowing extra base types for synclist
* checking for nested types in abstract classes
* test for nested types inside structs
2020-04-22 09:40:40 +02:00
uwee
ddd4b0b1fc
use HostSetup in tests ( #1761 )
2020-04-22 09:38:07 +02:00
uwee
262c1129dc
add test for NS Reset ( #1758 )
...
* add test for NS Reset
this code is depreciated but it should have a test as long as its in the code base
* typo
2020-04-21 23:49:46 +02:00
uwee
d996079042
remove empty if statement ( #1757 )
...
the current state is an untestable if statement. the if (!dont) is not pretty but the same logic is used later in the same file under Listen()
2020-04-21 23:49:11 +02:00
uwee
2f7053c6be
return bool to allow testing ( #1756 )
2020-04-21 23:48:42 +02:00
uwee
c2c1f86fe8
add HostSetup for tests ( #1755 )
2020-04-21 23:48:06 +02:00
uwee
c4bfb9d037
remove unused using ( #1754 )
2020-04-21 23:47:20 +02:00
James Frowen
2cf0fc71a7
Clean up sync object tests ( #1750 )
...
* cleaning up tests
* clearing dirty before test
2020-04-21 08:29:46 -05:00
uwee
3cf686f3b8
add base OnSetHostVisibility test ( #1749 )
...
* add base OnSetHostVisibility test
* fix code smells
2020-04-21 09:58:14 +02:00
MrGadget
2d006fe730
fix: Remove leftover AddPlayer methods now that extraData is gone ( #1751 )
2020-04-21 09:56:14 +02:00
James Frowen
58c89a3d32
fix: Allow sync objects to be re-used ( #1744 )
...
fixes #1714
2020-04-20 19:20:25 -05:00
Chris Langsenkamp
8798cd18ce
Updated NetworkManage template
2020-04-20 18:49:21 -04:00
Paul Pacheco
3dd709ac35
Remove MarkForReset ( #1747 )
...
* Remove MarkForReset
* Update Assets/Mirror/Runtime/NetworkIdentity.cs
* Update Assets/Mirror/Tests/Editor/NetworkServerTest.cs
2020-04-20 20:07:22 +02:00
Chris Langsenkamp
5d4bc47d46
fix: Use path instead of name in Room Example
2020-04-20 11:04:18 -04:00
Chris Langsenkamp
2a2f76c263
fix: Remove RoomPlayer from roomSlots on Disconnect
2020-04-20 11:02:45 -04:00
James Frowen
055a264660
adding return so that exception isnt throw after error ( #1746 )
2020-04-20 08:51:40 -05:00
Chris Langsenkamp
8e7bb44c3a
Updated docs, comments, template pursuant to renaming of OnNetworkDestroy
2020-04-20 09:42:16 -04:00
Paul Pacheco
d1695dd16f
feat: new virtual OnStopServer called when object is unspawned ( #1743 )
2020-04-20 10:36:03 +02:00
Paul Pacheco
86ac5ad40b
Rename OnNetworkDestroy to OnStopClient ( #1742 )
...
OnNetworkDestroy is not a good name, is it server? is it client?
you can't tell by the name.
Moreover, we have OnStartClient, API should be symetric so we should
have a corresponding OnStopClient.
Note this keeps backwards compatibility with an Obsolete for now
2020-04-20 10:35:34 +02:00
Chris Langsenkamp
e03c2a0ee1
restored 1bitpack_kenny metas
2020-04-19 17:32:51 -04:00
James Frowen
f17cea771e
using IsDerivedFrom instead of while loop ( #1739 )
2020-04-19 14:12:37 -05:00
James Frowen
a86d1cdfff
Adding error to network behaviour when generic sync object is used ( #1741 )
...
* test for using Generic SyncList
* adding error to network behaviour when generic sync object is used
* ignore generic classes
we can not process generic classes
we give error if a generic syncObject is used in NetworkBehaviour
2020-04-19 19:34:05 +02:00
James Frowen
a523d5f521
using if instead of try catch ( #1740 )
2020-04-19 19:33:30 +02:00
James Frowen
c25b1c6043
removing old test files ( #1738 )
2020-04-19 12:57:58 +01:00
James Frowen
f83093893e
Weaver error messages and tests for using interfaces ( #1737 )
...
* more tests for readwriters
* updating error message
* fixing error messages
2020-04-18 22:55:17 -05:00
Chris Langsenkamp
a6258d2d70
Remove and Ignore 1bitpack_kenney png.meta files.
2020-04-18 23:33:13 -04:00
James Frowen
f6e4068ebe
removing ignored test ( #1736 )
2020-04-19 00:53:39 +01:00
James Frowen
24469859e5
adding error to reader ( #1726 )
...
these checks are already in writer
2020-04-18 10:52:22 +02:00
James Frowen
5c56adc1dc
feat: default log level option ( #1728 )
...
Each class can specify default log levels when requesting the logger.
2020-04-17 18:11:44 -05:00
MrGadget
21acf66190
feat: NetworkMatchChecker Component ( #1688 )
...
* feat: NetworkMatchChecker Component
* Added docs
* feat: Use logger framework for NetworkClient (#1685 )
* Use logger framework for NetworkClient
* Update Assets/Mirror/Runtime/NetworkClient.cs
Co-authored-by: vis2k <info@noobtuts.com>
* breaking: NetworkVisbility component (#1681 )
* backup
* breaking: NetworkProximityCheck abstract class. Simplifies code, reduces complexity, improves performance because if 10k identities have 10 components each, we don't have to iterate 100k components each time we rebuild observers.
* update tests and checkers
* DisallowMultipleComponents
* fix tests
* split OnCheckObserver check
* fix tests
* syntax
* update comment
* renamed to NetworkVisibility
* forgot to remove comment
* breaking: Network Visibility Component
* changing namespaces of performance tests (#1689 )
* Updated to use NetworkVisibility
* Updated comments
* Updated OnCheckObserver and removed OnSetHostVisibility
* tests for OnCheckObserver
* adding check for empty guid
* tests for changing matchId
* RebuildObservers if player left a match
* Refactored to make it simpler
Co-authored-by: Paul Pacheco <paulpach@gmail.com>
Co-authored-by: vis2k <info@noobtuts.com>
Co-authored-by: James Frowen <jamesfrowendev@gmail.com>
2020-04-17 10:35:08 +02:00
MrGadget
cbc2a47729
fix: Don't destroy the player twice ( #1709 )
...
* fix: Don't destroy the player twice
* adding test
Co-authored-by: James Frowen <jamesfrowendev@gmail.com>
2020-04-17 10:34:17 +02:00
MrGadget
e5b728fed5
fix: Eliminate NetworkAnimator SetTrigger double firing on Host ( #1723 )
2020-04-17 00:53:46 +02:00
James Frowen
df7c671604
using MemoryTransport for ULocalConnectionPerformance ( #1720 )
2020-04-16 19:33:13 +02:00
James Frowen
db87c961b0
fixing TearDown and removing extra calls to shutdown ( #1722 )
2020-04-16 19:32:51 +02:00
James Frowen
3368026b2c
adding extra performance test for NetworkIdentity ( #1721 )
2020-04-16 10:52:24 +02:00
James Frowen
b1644ae481
feat: Weaver can now automatically create Reader/Writer for types in a different assembly ( #1708 )
...
* fix: serialize structs in other assemblies
fixes #1570
* removing check for type in another assembly
* fixing call to default constructor
* removing old tests that not longer apply
* fixing typo
* adding error when creating writer for unity base classes
* Test for Generating Reader and Writer functions
* removing old function
Co-authored-by: Paul Pacheco <paulpach@gmail.com>
2020-04-16 10:50:49 +02:00
James Frowen
58219c8f72
perf: Adding dirty check before update sync var ( #1702 )
...
* adding dirty check before update sync var
* Moving creating spawn payload to its own function
* updating tests
* adding tests for behaviour mask
* adding comment
* removing un-needed cast
2020-04-16 10:49:33 +02:00
James Frowen
17f8e9721a
re adding caching for OutputDirectory ( #1719 )
2020-04-15 14:06:18 -05:00
Paul Pacheco
93f7028e0d
split weaver test files by test class
2020-04-15 12:14:25 -05:00
Paul Pacheco
2b1aefab39
use logger framework instead of preprocessor
2020-04-15 11:33:48 -05:00
Paul Pacheco
e109ce3e87
paths should be combined, not added
2020-04-15 09:57:45 -05:00
Paul Pacheco
c483047486
Remove unused option
2020-04-15 09:14:44 -05:00
Devon Merner
d8c121695c
networkSceneName sets to empty on StopClient and StopServer. ( #1715 )
2020-04-15 11:31:27 +02:00
Devon Merner
0fe6328800
feat: Added SyncList.Find and SyncList.FindAll ( #1716 )
...
fixes #1710
2020-04-14 20:51:14 -05:00
James Frowen
6383e9884f
Moving weaver tests 2 ( #1706 )
...
* adding WeaverTestsBuildFromTestName
* removing event handlers on TearDown
2020-04-14 20:04:07 -05:00
James-Frowen Laptop2
239b7b762a
removing extra lines
2020-04-14 19:54:09 -05:00
James Frowen
c4d373984d
Moving weaver tests into their own classes
2020-04-14 19:53:45 -05:00
uwee
af2e732adb
docs: remove mention of networkPort from NetworkManager ( #1712 )
...
fixes #1711
2020-04-14 17:37:49 +02:00
James Frowen
6e081f3d40
NetworkIdentity ServerUpdate Performance test ( #1703 )
2020-04-14 11:13:21 +02:00
James Frowen
c66c5a6dcc
fix: Fixing SyncVars not serializing when OnSerialize is overridden ( #1671 )
...
* Adding SyncVar methods
this will allow SyncVars to still work if user overrides
OnSerialize as long as they call base.OnSerialize
* Adding tests for NetworkBehaviour OnSerialize
These tests make sure that weaver correctly create code for syncvar
* Update Assets/Mirror/Runtime/NetworkBehaviour.cs
* Update Assets/Mirror/Runtime/NetworkBehaviour.cs
* Update Assets/Mirror/Runtime/NetworkBehaviour.cs
* Update Assets/Mirror/Runtime/NetworkBehaviour.cs
* Update Assets/Mirror/Runtime/NetworkBehaviour.cs
* Update Assets/Mirror/Runtime/NetworkBehaviour.cs
* Update Assets/Mirror/Runtime/NetworkBehaviour.cs
* Update Assets/Mirror/Runtime/NetworkBehaviour.cs
* Update Assets/Mirror/Runtime/NetworkBehaviour.cs
* adding extra test
Co-authored-by: Paul Pacheco <paulpach@gmail.com>
Co-authored-by: vis2k <info@noobtuts.com>
2020-04-14 11:11:15 +02:00
Chris Langsenkamp
0e1aa1b305
Updated Netowork Observer template
2020-04-13 21:08:14 -04:00
MrGadget
4994193668
Make OnSetHostVisibility virtual with default functionality ( #1707 )
2020-04-13 20:05:08 -05:00
Chris Langsenkamp
cbe499e052
NetworkVisibility: Put methods in correct order
2020-04-13 20:17:07 -04:00
Chris Langsenkamp
6fec901a80
Updated Network Observer Template
2020-04-13 20:05:00 -04:00
James Frowen
eec45ff8fe
Adding changed check to PreprocessorDefine ( #1698 )
...
* Adding changed check to PreprocessorDefine
this stops ProjectSettings being marked as dirty each time the editor is opened
* Update PreprocessorDefine.cs
Co-authored-by: vis2k <info@noobtuts.com>
2020-04-13 10:14:04 +02:00
Chris Langsenkamp
8aabb54929
Don't rename spawned objects
2020-04-12 21:48:41 -04:00
Paul Pacheco
003597bc11
Remove commented out code
2020-04-12 11:06:13 -05:00
Paul Pacheco
b7cef180d4
Rename local variable for clarity
2020-04-12 11:06:13 -05:00
Paul Pacheco
61cf445395
Rename method for clarity
2020-04-12 11:06:13 -05:00
Paul Pacheco
78ff826684
Fix smells
2020-04-12 11:06:13 -05:00
Paul Pacheco
2a456a0161
Reduce cognitive complexity of Weave
2020-04-12 11:06:13 -05:00
Paul Pacheco
1a2af279ca
Remove unused method
2020-04-12 11:06:13 -05:00
Paul Pacheco
91920e0a6e
fix code smells
2020-04-12 11:06:13 -05:00
uwee
0e84e9dd4e
smell: reduce OnGUI complexity ( #1696 )
2020-04-12 16:48:25 +02:00
James Frowen
f8f939fd9c
Making ULocalConnectionPerformance test clean up new objects ( #1700 )
...
stops testPlayerPrefab was causing problems with OnPostProcessScene in other runtime tests
2020-04-12 13:44:45 +01:00
James Frowen
83d1648913
changing test namespace ( #1699 )
2020-04-12 13:18:05 +01:00
Chris Langsenkamp
9c3f5710eb
Updated docs and comments re: Network Visibility
2020-04-12 07:54:28 -04:00
James Frowen
18bd792a0b
Improving Performance Benchmark ( #1695 )
...
Taking measurements for frames and LateUpdate at same time.
2020-04-12 00:52:48 +01:00
James Frowen
9d24d45987
Adding defines to performance tests ( #1690 )
...
* adding defines
* adding versionDefines
2020-04-11 20:59:42 +02:00
James Frowen
24e2af098f
changing namespaces of performance tests ( #1689 )
2020-04-11 17:30:18 +01:00
Chris Langsenkamp
25ee8540f9
breaking: Network Visibility Component
2020-04-11 11:56:21 -04:00
vis2k
70ddf92a5c
breaking: NetworkVisbility component ( #1681 )
...
* backup
* breaking: NetworkProximityCheck abstract class. Simplifies code, reduces complexity, improves performance because if 10k identities have 10 components each, we don't have to iterate 100k components each time we rebuild observers.
* update tests and checkers
* DisallowMultipleComponents
* fix tests
* split OnCheckObserver check
* fix tests
* syntax
* update comment
* renamed to NetworkVisibility
* forgot to remove comment
2020-04-11 15:37:35 +02:00
Paul Pacheco
6e92bf5616
feat: Use logger framework for NetworkClient ( #1685 )
...
* Use logger framework for NetworkClient
* Update Assets/Mirror/Runtime/NetworkClient.cs
Co-authored-by: vis2k <info@noobtuts.com>
2020-04-11 13:21:14 +02:00
James Frowen
c0a82a86ea
Logger editor ( #1613 )
...
* window for mirror log levels
* applying suggestions
2020-04-10 13:20:05 -05:00
MrGadget
e7cfd5a498
fix: Check SceneManager GetSceneByName and GetSceneByPath ( #1684 )
...
* fix: Check SceneManager GetSceneByName and GetSceneByPath
* Fix example too.
2020-04-10 11:26:37 -05:00
Paul Pacheco
55e075c872
fix: stack overflow getting logger
2020-04-10 11:14:20 -05:00
Paul Pacheco
de87634ec5
Some extension methods for convenient migration
2020-04-10 11:11:51 -05:00
Paul Pacheco
f9328c771c
feat: logger factory works for static classes by passing the type
2020-04-10 10:51:42 -05:00
MrGadget
bc37497ac9
fix: Re-enable transport if aborting additive load/unload ( #1683 )
...
* fix: Re-enable transports if aborting additive load/unload
* Restore debug if's
2020-04-10 11:42:38 -04:00
James Frowen
95705a1545
Moving error check to when cache is created ( #1682 )
...
* Moving error check to when cache is created
* updating tests for new code behaviour
* Update Assets/Mirror/Runtime/NetworkIdentity.cs
Co-authored-by: vis2k <info@noobtuts.com>
2020-04-10 17:15:24 +02:00
vis2k
0b44ccee99
syntax
2020-04-10 10:06:37 +02:00
James Frowen
f0579835ca
perf: Increasing Network Writer performance ( #1674 )
...
* Increasing performance of network writer
* Using Array.Clear
renaming value to newLength
* Update Assets/Mirror/Tests/Editor/NetworkWriterTest.cs
Co-Authored-By: Paul Pacheco <paulpach@gmail.com>
* adding braces
* extracting EnsureCapacity method
* Update NetworkWriter.cs
Co-authored-by: Paul Pacheco <paulpach@gmail.com>
Co-authored-by: vis2k <info@noobtuts.com>
2020-04-10 09:45:09 +02:00
Chris Langsenkamp
c1fe2124d8
Removed SpawnWithClientAuthority from comments and docs
2020-04-09 16:51:41 -04:00
James Frowen
8ce65045c8
Benchmark performance test 2 - Idle benchmark ( #1662 )
...
* adding bool to stop health updating
* idle benchmark
* using FindObjectsOfType instead of static field
2020-04-09 09:40:37 +02:00
James Frowen
7e7ffcd892
Adding report to performance test readme
2020-04-08 16:24:39 +01:00
James Frowen
7a06815d75
adding static check before adding this arg ( #1668 )
2020-04-07 19:50:48 +02:00
James Frowen
60678d9bc7
adding readme ( #1672 )
2020-04-07 12:30:57 -05:00
James Frowen
4fc58be148
making network behaviour abstract ( #1669 )
2020-04-07 10:23:09 +02:00
James Frowen
17885a0da2
Adding comments to NetworkBehaviour ( #1670 )
2020-04-07 00:33:15 +01:00
James Frowen
f8dee1f1a1
removing unnecessary using ( #1667 )
2020-04-06 09:56:26 -05:00
James Frowen
75dc0af65f
Pipeline fix for performance tests ( #1666 )
...
* updating coverage manifest
* removing version tag
2020-04-06 09:42:47 -05:00
James Frowen
52e91e7d1e
Benchmark performance test ( #1661 )
...
* benchmark performance test
* adding hooks for performance test
* using hooks to measure time of Lateupdate
moving code to setup and teardown
2020-04-06 09:49:46 +02:00
Chris Langsenkamp
532555bbea
Put methods in call order
2020-04-04 12:03:08 -04:00
James Frowen
34415fe876
performance test for ULocalConnection ( #1655 )
2020-04-04 15:03:05 +02:00
James Frowen
3219fd4b51
performance test for NetworkWriter ( #1654 )
2020-04-04 15:02:48 +02:00
James Frowen
0157f9d909
adding performance test asmdef ( #1653 )
...
* adding performance test asmdef
* adding performance tests to packages
* fixing asmdef to work with 2018 and 2019
2020-04-04 14:21:53 +02:00
Paul Pacheco
84b2c8cf26
perf: Use continuewith to queue up ssl messages ( #1640 )
...
get rid of the complicated queue. Use Task.continuewith
also, apparently we have to flush or latency is really bad.
2020-04-03 07:24:07 -05:00
James Frowen
2ef8404f82
adding Category to weaver and Telepathy tests ( #1643 )
2020-04-02 18:50:42 +02:00
James Frowen
456fde07bc
removing cahced field ( #1641 )
2020-04-02 18:49:38 +02:00
James Frowen
4d5cee893d
perf: Adding buffer for local connection ( #1621 )
...
* Using writer for local connection
LocalConnectionBuffer
* removing assert
* fixing error and cleaning up code
* removing old queue
* tests for LocalConnectionBuffer
* removing field
* removing extra lines
* Update LocalConnections.cs
removing empty line
* adding comment for packet count
2020-04-02 18:49:09 +02:00
Chris Langsenkamp
caccebaa17
Updated example prefabs
2020-04-02 01:11:11 -04:00
Chris Langsenkamp
a6f98b09cf
Updated NetworkManager Script Template
2020-04-01 23:49:47 -04:00
Paul Pacheco
6591539c31
Remove unused local variable
2020-04-01 12:02:44 -05:00
Chris Langsenkamp
e420dcb6b6
Fixed comment in template
2020-04-01 05:33:16 -04:00
MrGadget
d2a58a4c25
fix: Destroyed NetMan due to singleton collision must not continue. ( #1636 )
...
* fix: Destroyed NetMan due to singleton collision must not continue.
* Added comment
* Added Comment
2020-04-01 11:29:35 +02:00
Paul Pacheco
f2ccb59ae6
feat: logging api ( #1611 )
...
* feat: logging api
Provide a ILogger (from unity framework) per class
it can track loggers per class and use Debug.unityLogger by default
* Logger field should never change
* Support loggers for static classes
Unfortunately we can't have generics with static classes.
Thus we can keep the loggers in a Dictionary instead indexed by name
if you need a logger for a static class, you can just do:
private static readonly ILogger logger = LogFactory.GetLogger(nameof(MyClass));
* Remove unused using
* Better tests by providing a mock handler
2020-04-01 11:27:51 +02:00
James Frowen
4fea1ee9b3
making singleton private set ( #1635 )
2020-04-01 01:11:45 +02:00
James Frowen
8087d3da7d
explicit type preference ( #1634 )
2020-03-31 22:57:47 +02:00
James Frowen
2617d65ad1
removing unnecessary this ( #1633 )
2020-03-31 22:57:27 +02:00
James Frowen
1e326ce6fe
removing unnecessary casts ( #1632 )
2020-03-31 22:56:54 +02:00
James Frowen
7dde2f80fe
removing and sort using ( #1631 )
2020-03-31 22:56:30 +02:00
James Frowen
f19e2d3aac
more formatting ( #1630 )
2020-03-31 22:55:58 +02:00
James Frowen
c6501aab06
formatting ( #1629 )
2020-03-31 12:15:30 -05:00
Chris Langsenkamp
7f208ffba9
Updated Comments
2020-03-30 22:28:59 -04:00
James Frowen
1ae038172a
perf: faster NetworkReader pooling ( #1623 )
...
* replacing stack with array for NetworkReaderPool
* Reader tests
2020-03-30 17:08:21 +02:00
James Frowen
f9335bb5f3
Finding WeaverAssembler path before running tests ( #1608 )
...
* Finding WeaverAssembler path before running tests
* using nameof
2020-03-30 14:45:36 +02:00
James Frowen
dcb618bfd6
fixing MissingReferenceException ( #1624 )
2020-03-29 21:39:18 -04:00
Paul Pacheco
deb286f0c2
refactor: simplify getting hook method
2020-03-29 14:25:07 -05:00
Paul Pacheco
518233cd7e
This is always true
2020-03-29 14:11:54 -05:00
Paul Pacheco
69fdbea892
Unused using
2020-03-29 14:11:54 -05:00
James Frowen
da2e61b30a
doc comments ( #1622 )
2020-03-29 11:41:21 -05:00
vis2k
254a49496f
NetworkWriterPool: add performance comment
2020-03-29 17:33:03 +02:00
vis2k
d865dddb4e
10k demo: deterministic health updates
2020-03-29 17:29:11 +02:00
James Frowen
4fa43a9471
perf: faster NetworkWriter pooling ( #1620 )
...
* using array in NetworkWriterPool instead of stack
* Using property
adding debug warning if pool is full
* adding tests for NetworkWriterPool
* Update NetworkWriterPool.cs
* Update NetworkWriterPoolTest.cs
Co-authored-by: vis2k <info@noobtuts.com>
2020-03-29 17:16:16 +02:00
Paul Pacheco
e96b687563
Revert "perf: faster NetworkWriter pooling ( #1616 )"
...
This reverts commit 5128b122fe
2020-03-28 19:04:06 -05:00
Paul Pacheco
96e690ef9c
Revert "Explain why 10"
...
This reverts commit e8cdb7569d
2020-03-28 19:03:53 -05:00
Paul Pacheco
e8cdb7569d
Explain why 10
2020-03-28 18:14:48 -05:00
James Frowen
e12f33d306
fixing MissingReferenceException ( #1619 )
2020-03-28 15:00:48 -04:00
James Frowen
5128b122fe
perf: faster NetworkWriter pooling ( #1616 )
...
Stack turned out to be slow way to pool NetworkWriters.
Replace them with an array
see #1614
2020-03-28 12:58:00 -05:00
Paul Pacheco
61163cacb4
perf: replace isValueType with faster alternative ( #1617 )
...
According to vis benchmark here https://github.com/vis2k/Mirror/issues/1614#issuecomment-605443808
isValueType is an expensive operation.
This microoptimization replaces isValueType for a faster (not so readable) alternative
2020-03-28 12:27:42 -05:00
Paul Pacheco
166b8c9467
perf: use byte[] directly instead of MemoryStream ( #1618 )
...
* perf: use byte[] directly instead of MemoryStream
* Optimize writing int32 and int64
* Update Assets/Mirror/Runtime/NetworkWriter.cs
Co-Authored-By: vis2k <info@noobtuts.com>
* Update Assets/Mirror/Runtime/NetworkWriter.cs
Co-Authored-By: vis2k <info@noobtuts.com>
* Update Assets/Mirror/Runtime/NetworkWriter.cs
* Start with bigger buffer
* Woops, should have double checked suggestion
* Removed invalid Test
We should not require NetworkWriter to behave in certain way when Position
is set to out of bounds.
That is an invalid use of NetworkWriter, so NW should be free to do any behavior
* smells
* Update NetworkWriter.cs
Co-authored-by: vis2k <info@noobtuts.com>
2020-03-28 18:17:53 +01:00
vis2k
a4bd6e7e66
Examples: added 10k monsters benchmark ( #1615 )
...
* scene and 1bit from kenney
* tilemap
* slice sprites
* name some
* create empty tile
* 2d cam
* monster prefab
* 100 monsters
* monster netid
* rename
* zoom cam, 10k monsters
* resave scene for sceneids
* Monster script
* add transparent textures for monsters
* replace monster sprite with transparent
* scripts
* mvoed into benchmarks folder
* player sprite
* tilemap background
* player prefab
* health update
2020-03-28 13:03:19 +01:00
Paul Pacheco
3fb7559561
remove redundant code block
2020-03-27 17:25:33 -05:00
Paul Pacheco
f56471085f
Fix typos in tests
2020-03-27 17:21:24 -05:00
Paul Pacheco
10813cb9eb
Reduce cognitive complexity of GenerateClassOrStructReadFunction
2020-03-27 17:14:39 -05:00
Paul Pacheco
ef80575787
Remove redundant code block
2020-03-27 17:06:59 -05:00
Paul Pacheco
6587c1f7b9
Better comment
2020-03-27 17:03:40 -05:00
Paul Pacheco
1f8b27e927
Remove unused using
2020-03-27 17:02:59 -05:00
Lymdun
5d76afbe29
perf: Remove redundant mask ( #1604 )
2020-03-27 11:34:56 +01:00
Paul Pacheco
dbe1365329
fix naming convention
2020-03-26 23:15:09 -05:00
Paul Pacheco
1d4eed77ed
Simplify getting methods
2020-03-26 19:28:17 -05:00
James Frowen
c6023c8275
unit test for IsActiveScene ( #1597 )
2020-03-27 00:22:46 +01:00
Paul Pacheco
c1cfc42181
perf: simplify and speed up getting methods in weaver
2020-03-26 17:35:15 -05:00
Paul Pacheco
ebc817028b
reduce cognitive complexity of CheckForHookFunction
2020-03-26 17:35:15 -05:00
Paul Pacheco
c6e8717909
simplify getting attribute fields
2020-03-26 17:35:15 -05:00
Chris Langsenkamp
5146e95fe0
Udpated scene file
2020-03-26 18:15:44 -04:00
vis2k
6151edc730
rename test
2020-03-26 21:27:47 +01:00
vis2k
e059b23a7f
NetworkManager.StopHost stops client, then server. Seems more consistent this way. ( #1602 )
2020-03-26 21:10:16 +01:00
vis2k
678ac68b58
fix : #1515 - StopHost now invokes OnServerDisconnected for the host client too ( #1601 )
...
* fix : #1515 - StopHost now invokes OnServerDisconnected for the host client too
* avoid NullReferenceException when calling StopHost without StartHost
* test WIP
* test
2020-03-26 20:54:53 +01:00
Paul Pacheco
c8a1a5e56f
feat: now you can assign scenes even if not in Editor ( #1576 )
...
* feat: now you can assign scenes even if not in Editor
Instead of using scene name, scenes are now identified by path.
This fixes a couple problems:
1) In the room example, now you can assign the scenes even if they have
not been added to the editor. This was a constant pain because if you
open the offlinescene, all the scenes got wiped. You had to add the
scenes to the editor and reassign them all again. With this PR you
will still need to add them to the editor, but they will remain
assigned.
2) It is possible for multiple scenes to have the same name, but it is
not possible for multiple scenes to have the same path. So this is
a more robust way to identify scenes
This also greatly simplifies the scene SceneDrawer
BREAKING CHANGE: You will need to reassign your scenes after upgrade
* Automatically fix properties that were using name
If you open a NetworkManager or other gameobject that uses a scene name
it now gets converted to scene path by the SceneDrawer
* Use get scene by name
* Scene can never be null
* Update Assets/Mirror/Examples/AdditiveScenes/Scenes/MainScene.unity
* Issue warning if we drop the scene
* Issue error if scene is lost
* Add suggestion on how to fix the error
* Keep backwards compatibility, check for scene name
* cache the active scene
* Update Assets/Mirror/Editor/SceneDrawer.cs
Co-Authored-By: James Frowen <jamesfrowendev@gmail.com>
* GetSceneByName only works if scene is loaded
* Remove unused using
Co-authored-by: James Frowen <jamesfrowendev@gmail.com>
2020-03-26 17:49:47 +01:00
vis2k
8c6ae0f8b4
fix : #1599 - NetworkManager HUD calls StopHost/Server/Client depending on state. It does not call StopHost in all cases. ( #1600 )
2020-03-26 17:34:16 +01:00
Paul Pacheco
7a6b854179
Simplify finding custom attributes
2020-03-26 09:52:39 -05:00
Paul Pacheco
d530d7a1e4
Lists are not needed anymore
2020-03-26 07:50:16 -05:00
Paul Pacheco
97fe7a0a01
Simplify adding substitute methods
2020-03-26 07:46:15 -05:00
Paul Pacheco
9c4d172664
reduce Cognitive complexity
2020-03-26 00:36:15 -05:00
Paul Pacheco
486b094b22
reduce Cognitive complexity
2020-03-26 00:33:04 -05:00
Paul Pacheco
559cf80755
parameter name matches base class
2020-03-26 00:25:35 -05:00
Paul Pacheco
910aeab4eb
fix smells
2020-03-26 00:24:20 -05:00
Paul Pacheco
3029467709
fix flaky test
2020-03-26 00:17:22 -05:00
Paul Pacheco
de768d142f
Remove redundant if
2020-03-25 05:02:04 -05:00
Paul Pacheco
62525a9b4b
Use List instead of yield return
2020-03-25 04:53:20 -05:00
Paul Pacheco
307807d68c
Use List instead of yield return
2020-03-25 04:53:20 -05:00
vis2k
ad39ddc92f
NetworkTransform rotation compression removed. Gets rid of endless discussions, optimizations and issues. Sending a quaternion is never going to fail. ( #1595 )
...
* NetworkTransform rotation compression removed. Gets rid of endless discussions, optimizations and issues. Sending a quaternion is never going to fail.
* keep empty file
* keep empty file
2020-03-25 10:18:07 +01:00
Chris Langsenkamp
ef2f6b45bc
Removed noisy warning and added reason in comments
2020-03-24 23:56:52 -04:00
Chris Langsenkamp
111ae51102
Room Example shows how to get Network Manager out of DontDestroyOnLoad
2020-03-24 22:04:54 -04:00
Chris Langsenkamp
d034ef616f
feat: Added Virtual OnRoomStopServer to NetworkRoomManager and Script Template
2020-03-24 22:02:01 -04:00
Paul Pacheco
8026f6dcac
unnest ifs
2020-03-24 20:17:03 -05:00
Paul Pacheco
0541b339ed
Merge ifs, fix smells
2020-03-24 20:14:43 -05:00
Paul Pacheco
9c917c582e
Remove unused using
2020-03-24 20:09:05 -05:00
Paul Pacheco
2a3470dfb4
Helpers should not be instantiated
2020-03-24 20:08:42 -05:00
Paul Pacheco
b740b2487b
this is not code
2020-03-24 20:07:30 -05:00
Paul Pacheco
260e37cbb2
Reduce cognitive complexity of OnCompilationFinished
2020-03-24 20:04:34 -05:00
Paul Pacheco
6f04ff77d7
Remove commented out code
2020-03-24 20:02:49 -05:00
Paul Pacheco
48cf45b8ce
Remove unused method
2020-03-24 20:01:55 -05:00
Paul Pacheco
f4bc7ca691
use same parameter name in override
2020-03-24 20:01:00 -05:00
Paul Pacheco
433818b440
Remove cognitive complexity of NetworkInformation
...
Split up large method,
Use static variables instead of fields
2020-03-24 19:58:39 -05:00
Chris Langsenkamp
85c4f1bcf1
Remove unused variable
2020-03-24 17:58:04 -04:00
vis2k
347cb5374d
fix : #1593 - NetworkRoomManager.ServerChangeScene doesn't destroy the world player before replacing the connection. otherwise ReplacePlayerForConnection removes authority form a destroyed object, causing all kidns of errors. The call wasn't actually needed. ( #1594 )
...
* fix : #1593 - NetworkRoomManager.ServerChangeScene destroys the world player after replacing the connection, not before. previously ReplacePlayerForConnection would operate on dead data.
* remove it entirely
2020-03-24 22:28:04 +01:00
Paul Pacheco
9a50fbd507
Remove redundant initialization
2020-03-24 15:59:17 -05:00
Paul Pacheco
9fe718e8d5
playerName -> PlayerName
2020-03-24 15:59:17 -05:00
Paul Pacheco
72de733a62
remove redundant initialization
2020-03-24 15:59:17 -05:00
Paul Pacheco
1be3333905
Move ResolveMethod together
2020-03-24 15:59:17 -05:00
Paul Pacheco
25b13f83c2
CheckDLLPath -> CheckDllPath
2020-03-24 15:59:17 -05:00
Paul Pacheco
f74abc8f86
UnityEngineDLLDirectoryName -> UnityEngineDllDirectoryName
2020-03-24 15:59:17 -05:00
Paul Pacheco
e83daa8c5c
drawSyncList -> DrawSyncList
2020-03-24 15:59:17 -05:00
MrGadget
c796116758
Remove Usage of LAN in HUD and Docs ( #1592 )
...
* Remove usage of LAN in HUD and docs
* Server + Client
* Host (Server + Client)
* HUD Image
2020-03-24 21:55:18 +01:00
Paul Pacheco
4c15fcf771
fix naming conventions
2020-03-24 15:25:54 -05:00
Paul Pacheco
6968234689
Reduce cognitive complexity of OnPostProcessScene
...
Fixes smell found by sonar qube
No code changes, just split into 2 functions
2020-03-24 15:20:42 -05:00
Paul Pacheco
e841aa9bf7
merge ifs
2020-03-24 15:10:32 -05:00
Paul Pacheco
9cc67938c3
remove redundant cast
2020-03-24 15:08:29 -05:00
Paul Pacheco
2d554d446e
Reduce cognitive complexity of RebuildObservers
...
Identified as a smell by sonar qube
No logic changes, just refactor the code into a separate functions
2020-03-24 14:52:19 -05:00
Chris Langsenkamp
f084706bdf
Scene meta update
2020-03-24 15:28:34 -04:00
Paul Pacheco
c69ae75d6a
simplify parameter change
2020-03-24 13:47:10 -05:00
Paul Pacheco
aba028e74b
Reduce cognitive complexity of NetworkRoomPlayer.OnGUI
...
fixes code smell in SQ, no behavior change, just split the method into
smaller methods
2020-03-24 12:52:02 -05:00
Paul Pacheco
102a8822b0
fix smell discard unused parameter
2020-03-24 12:52:02 -05:00
Paul Pacheco
e8c9d7951d
test that we cannot unpack the wrong message
2020-03-24 10:37:54 -05:00
Paul Pacheco
a7ab26fa7d
Simplify tests
2020-03-24 08:31:19 -05:00
Paul Pacheco
4a9dca3c1c
Simplify tests
2020-03-24 08:16:19 -05:00
Paul Pacheco
1362b80eb4
A test should only test one thing
2020-03-24 08:11:42 -05:00
Paul Pacheco
f6bb3a9f06
use Assert.Throws
2020-03-24 08:09:41 -05:00
Paul Pacheco
2714be3869
Remove unused using
2020-03-24 08:04:42 -05:00
Paul Pacheco
3321dd8a95
Move NSubstitute to common folder, It will be used in play mode tests
2020-03-24 08:03:22 -05:00
Paul Pacheco
19a17c15b9
MemoryTransport is only for tests
2020-03-24 08:01:39 -05:00
vis2k
9e26b26689
NetworkIdentity.isServer simplified via one flag instead of helper variable + netId check. When isServer is set in OnStartServer, netId is set to != 0 in any case, so the previous check was unnecessary. ( #1590 )
...
* NetworkIdentity.isServer simplified via one flag instead of helper variable + netId check
* simplify teardowns
* NetworkIdentityTests can set isServer directly now
* networkbehaviourtests simplified
* NetworkServerTests can set isServer directly now
* remove comment
2020-03-24 11:25:04 +01:00
vis2k
9d088bc942
fix #1484 : isServer state in NetworkIdentity is not dependent on NetworkServer.active anymore. Fixes a bug where isServer was already false in OnDestroy, but we sometimes still need it there to save a player etc. Also added a test to prevent it in the future. ( #1585 )
...
* fix #1484 : revert isServer simplifiy. Fixes a bug where isServer was already false in OnDestroy, but we need sometimes still need it there to save skillbars etc.
* update comment
2020-03-24 11:07:40 +01:00
vis2k
2f87f3cca7
Runtime tests setup
2020-03-24 10:52:14 +01:00
Paul Pacheco
613356a6d0
fix smell, call parameter the same as base method
2020-03-23 10:29:45 -05:00
Paul Pacheco
0beba4dd2b
fix smell, call parameter the same as base method
2020-03-23 10:28:49 -05:00
Paul Pacheco
f4a8692873
fix smell, keep parameter name in override
2020-03-23 10:27:51 -05:00
Paul Pacheco
bb655de71b
fix smell keep overloaded methods together
2020-03-23 10:26:25 -05:00
Paul Pacheco
3a73a11a55
fix smell, use pascal case
2020-03-23 10:22:06 -05:00
Paul Pacheco
effb05e732
fix smells
2020-03-23 10:21:45 -05:00
James Frowen
cf55333a07
fix: overriden hooks are invoked ( fixes #1581 ) ( #1584 )
...
* failing tests for virutal methods used by syncvar hook
* replacing Assert.fail to stop OnDeserialize failed error
* adding tests to make sure classes are set up correctly
* fix: call overriden hooks
Use a virtual call for hooks. fixes #1581
Co-authored-by: Paul Pacheco <paulpach@gmail.com>
2020-03-23 14:06:24 +01:00
James Frowen
c7c3ee4ab9
Tests for SyncLists that use structs ( #1583 )
2020-03-22 17:05:50 -05:00
Paul Pacheco
addf847675
Move comments to previous line ( #1579 )
...
* Move comments to the previous Lines
We have a mix of comments at on the previous line and at the end of
the line. We need to "pick one way and stick with it".
Per the C# code guidelines, comments go on the previous line. See here:
https://docs.microsoft.com/en-us/dotnet/csharp/programming-guide/inside-a-program/coding-conventions
This also makes pull requests more readable since comments are less
likely to wrap
There are no code changes here, just a search and replace for all comments
This also makes cloc counts more accurate as it can better determine
how many lines of comments vs code we have
* Update Assets/Mirror/Components/NetworkTransformBase.cs
* Update Assets/Mirror/Examples/ListServer/ListServer.cs
* Update Assets/Mirror/Tests/Editor/WeaverTests~/TestingScriptableObjectArraySerialization.cs
* Update Assets/Mirror/Tests/Editor/WeaverTests~/TestingScriptableObjectArraySerialization.cs
2020-03-21 19:31:10 +01:00
MrGadget
b627779acd
fix: Make SendToReady non-ambiguous ( #1578 )
2020-03-21 11:33:35 -05:00
James Frowen
ad10ca115e
Weaver test for adding guard code ( #1574 )
...
* Adding check to make sure weaver adds code
* tests for network behaviour
* marking methods as static
* adding comment to method body
* making Weaver internal
* replacing string
2020-03-21 16:03:48 +01:00
James Frowen
0eb180555d
Fixing exceptions ( #1569 )
...
* removing another use of serializedObject
breaks when target is null
* adding check if target is NetworkBehaviour
* moving check from OnInspectorGUI
2020-03-21 14:46:02 +01:00
MrGadget
3156504270
fix: Added LogFilter.Debug check in a few places ( #1575 )
2020-03-21 14:42:33 +01:00
Chris Langsenkamp
4d827cd9f6
fix: comment punctuation
2020-03-20 20:30:35 -04:00
Chris Langsenkamp
cedbd8fb7a
Make roomPlayerPrefab protected so it can be referenced in derived classes
2020-03-20 20:23:16 -04:00
Chris Langsenkamp
a8c4d6682e
Fixed Template
2020-03-20 19:22:38 -04:00
James Frowen
d9cc73eabe
moving code to its own class ( #1573 )
...
* moving code to its own class
* using code suggestions
2020-03-20 22:21:01 +01:00
Paul Pacheco
59687675c9
Fix sonarqube null warning
...
Once upon a time, connections could be null here. This is no longer
the case, connections always have something,
Even if they were null, this method would not work at all because
the conn.Send call at the bottom would throw NRE.
Therefore the null checks here are unnecesary
2020-03-20 08:01:33 -05:00
FirstGearGames
57eff86e3f
Change LogError to Log. Added more details. ( #1545 )
...
Since messages behave similar to events and given the process is not technically breaking, using LogError seems incorrect. Using Log, maybe LogWarning would be more appropriate. Added additional text to clarify why the user may be seeing that log entry.
2020-03-20 10:56:02 +01:00
James Frowen
e040e6dc85
Removing use of serialized object ( #1568 )
...
using serializedObject causes AgumentException if target is null
2020-03-19 21:56:34 -05:00
James Frowen
c7c3ea8e0f
Moving draw synclist to class ( #1566 )
...
creating SyncListDrawer
2020-03-19 21:32:00 -05:00
James Frowen
a520c0e41d
Simplifying get type ( #1567 )
...
* adding IsParameterControlledByCurve check
* Simplifying GetType
Adding Warning because target is only null is something has gone wrong
* removing serializedObject.update
we dont use any values from serializedObject so we dont need to call update
2020-03-19 21:31:08 -05:00
James Frowen
421832f650
Cleaning up network behaviour inspector ( #1565 )
...
split large method into smaller ones
2020-03-19 20:46:53 -05:00
James Frowen
cc4032e236
Adding header before sync list ( #1564 )
...
matches untiy's Header style
2020-03-19 20:04:48 -05:00
James Frowen
55107115c6
feat: SyncSet and SyncDictionary now show in inspector ( #1561 )
...
SyncSet and SyncDictionary now show in inspector
2020-03-19 20:02:51 -05:00
Paul Pacheco
6b0fa18e0f
Remove unused HideScriptField
2020-03-19 19:28:47 -05:00
Paul Pacheco
5571716749
Remove unused initialize field
2020-03-19 19:25:33 -05:00
James Frowen
b8c87d9053
fix: show private serializable fields in network behavior inspector ( #1557 )
...
* adding IsParameterControlledByCurve check
* Adding all visible syncvar fields to syncVarNames
old code only included public sync var fields
new code includes public and private fields with "SerializeField"
* adding comment
* adding method comment
Co-authored-by: Paul Pacheco <paulpach@gmail.com>
2020-03-19 18:52:31 -05:00
James Frowen
55767bb54d
Fixing syncs anything ( #1560 )
...
* adding IsParameterControlledByCurve check
* Fixing SyncsAnything
old code would not work with custom SyncObjects
2020-03-19 18:40:57 -05:00
James Frowen
98ecf7b647
Moving initialize code to onenable ( #1558 )
...
* adding IsParameterControlledByCurve check
* Moving Init code to OnEnable
the initialized bool is redundant
Co-authored-by: Paul Pacheco <paulpach@gmail.com>
2020-03-19 18:36:37 -05:00
James Frowen
b4ff4f2ce1
Using draw default inspector ( #1559 )
...
* adding IsParameterControlledByCurve check
* using DrawDefaultInspector
Now that SyncVar has a drawer this code is redundant
2020-03-19 18:29:55 -05:00
Chris Langsenkamp
e946c79194
fix: Fixed ClienRpc typos
2020-03-18 19:02:58 -04:00
James Frowen
cf8b979cce
adding IsParameterControlledByCurve check ( #1547 )
2020-03-18 17:30:16 +01:00
MrGadget
2d1b142276
fix: Prevent Double Call of NetworkServer.Destroy ( #1554 )
...
* fix: Prevent Double Call of NetworkServer.Destroy
* doc: Updated ChangeLog
* Extended comments and added LogWarning
2020-03-18 17:25:22 +01:00
James Frowen
35d7c9ddb4
adding PropertyDrawer for syncvar ( #1552 )
...
This fixing position of label with HeaderAttribute
This will also make sure that label is shown for all visable fields
2020-03-18 09:36:10 +01:00
Chris Langsenkamp
6f617f92e3
Added Tooltips and Headers to NetworkRoomManager and NetworkRoomPlayer
2020-03-17 23:47:57 -04:00
Chris Langsenkamp
a4ffcbe280
fix: Updated NetworkRoomPlayer inspector and doc and image
2020-03-17 19:22:53 -04:00
MrGadget
46c80bdc2e
Reverted 6431c28a ( #1553 )
2020-03-17 19:08:47 -04:00
vis2k
4faec29559
removed obsoletes ( #1542 )
...
* lobby
* networkroommanager
* networkanimatoreditor
* networkidentityeditor
* preprocessordefine
* clientscene
* customattributes
* localclient
* messages
* networkbehaviour
* networkclient
* networkconnection
* networkidentity
* networkmanager
* networkserver
* networkwriter
* syncdictionary
* synclist
* unetwork
* transport
* networkmessage
* remove leftover obsoletes
* NetworkServer
* NetworkManager
* NetworkRoomManager
* NetworkRoomManager
* AddPlayerMessage
* NetworkLobbyManager & NetworkLobbyPlayer
* PreprocessorDefine
* Removed usings
* Commented test class
* Restored NetworkMessage as empty file
* Removed SyncVarSTRUCT tests
* Removed SyncVarSTRUCT tests
Co-authored-by: Chris Langsenkamp <chris@clevertech.net>
leaving a few ones still in there:
addplayermessage
llapi because still useful
networkbehaviour.getrpchandler for networkprofiler
BREAKING CHANGE: removed obsoletes
2020-03-17 15:25:36 -05:00
Chris Langsenkamp
7bd137847d
Added Deprecated Comment
2020-03-17 11:03:00 -04:00
Paul Pacheco
658847b096
fix: Command and Rpc debugging information ( #1551 )
...
When replacing command and rpc methods, we now correctly move over
the debugging information.
Now you can put breakpoints in commands and Rpc
Should fix #1550
2020-03-16 18:50:14 -05:00
Paul Pacheco
0b84d4c5e1
fix: Report correct channel to profiler in SendToObservers
2020-03-15 11:54:39 -05:00
vis2k
20a2d09d07
fix: NetworkBehaviour.SyncVarNetworkIdentityEqual made protected again so that Weaver finds it again
2020-03-09 21:54:19 +01:00
vis2k
165a1dd94c
fix: NetworkBehaviour.SyncVarGameObjectEqual made protected again so that Weaver finds it again
2020-03-09 21:51:17 +01:00
vis2k
76dd0c83bf
syntax
2020-03-09 16:50:32 +01:00
vis2k
c928ef2353
syntax
2020-03-09 16:39:31 +01:00
vis2k
5801051a29
Weaver Helpers: remove unused AddSearchDirectoryHelper
2020-03-09 16:23:51 +01:00
vis2k
a26a0a39e2
syntax
2020-03-09 16:22:27 +01:00
vis2k
eb4ccd54b7
syntax
2020-03-09 16:21:36 +01:00
vis2k
83c8beac5e
NetworkClientTests: Send
2020-03-09 11:23:28 +01:00
vis2k
df0ec137d0
NetworkClientTests: DisconnectInHostMode
2020-03-09 11:12:22 +01:00
vis2k
53165d2096
NetworkClientTests: ConnectUri
2020-03-09 11:05:59 +01:00
vis2k
572866410f
Tests: MemoryTransport server connection id changed from 0 to 1 because 0 is reserved for localhost and will be rejected
2020-03-09 11:05:48 +01:00
vis2k
fe94b74009
Tests: MemoryTransport LateUpdate exposed so we can process messages
2020-03-09 11:05:19 +01:00
vis2k
f26ba488b8
NetworkClientTests: isConnected
2020-03-09 10:51:41 +01:00
vis2k
f9b8914e6d
NetworkClientTests: serverIp
2020-03-09 10:47:44 +01:00
Chris Langsenkamp
4b27388771
Removed StartHost from ScriptTemplate
2020-03-08 11:19:13 -04:00
Paul Pacheco
f1860e3db9
test: test for obsolete should also be obsolete
2020-03-08 09:12:10 -05:00
vis2k
b74ef10780
NetworkBehaviourTests: OnStartLocalPlayer
2020-03-07 20:50:55 +01:00
vis2k
d48ab55ede
NetworkBehaviourTests: OnStartClient
2020-03-07 20:50:01 +01:00
vis2k
ad0788fb95
NetworkBehaviourTests: OnNetworkDestroy
2020-03-07 20:48:42 +01:00
vis2k
35ab00f4eb
NetworkBehaviourTests: SerializeAndDeserializeObjectsAll
2020-03-07 20:42:52 +01:00
vis2k
d703072768
NetworkBehaviour.DeSerializeObjectsDelta made internal so it can be tested
2020-03-07 20:42:42 +01:00
vis2k
d5b7802ae3
NetworkBehaviourTests: SerializeAndDeserializeObjectsAll
2020-03-07 20:38:58 +01:00
vis2k
2ff53580ba
NetworkBehaviour: DeSerializeObjectsAll made internal so we can test it
2020-03-07 20:38:46 +01:00
vis2k
07530a301f
NetworkBehaviourTests: DirtyObjectBits
2020-03-07 20:31:30 +01:00
vis2k
a4e0b32713
NetworkBehaviour.DirtyObjectBits made internal so it can be tested
2020-03-07 20:31:19 +01:00
vis2k
f12048a5c8
NetworkBehaviourTests: ClearAllDirtyBitsClearsSyncObjectsDirtyBits
2020-03-07 20:21:06 +01:00
vis2k
81c86d3d80
NetworkBehaviourTests: ClearAllDirtyBitsClearsSyncVarDirtyBits
2020-03-07 20:15:57 +01:00
vis2k
258d3bed02
NetworkBehaviourTests: GetSyncVarNetworkIdentityOnClientNull
2020-03-07 18:57:06 +01:00
vis2k
29035aaa7e
NetworkBehaviourTests: GetSyncVarNetworkIdentityOnClient
2020-03-07 18:56:54 +01:00
vis2k
c84cbe38de
NetworkBehaviourTests: GetSyncVarNetworkIdentityOnServerNull
2020-03-07 18:56:45 +01:00
vis2k
ed71ab0824
NetworkBehaviourTests: GetSyncVarNetworkIdentityOnServer
2020-03-07 18:56:34 +01:00
vis2k
b81a48ff36
NetworkBehaviourTests: SetSyncVarNetworkIdentityZeroNetId
2020-03-07 18:54:04 +01:00
vis2k
abcecf1eaf
NetworkBehaviourTests: SetSyncVarNetworkIdentityNull
2020-03-07 18:53:56 +01:00
vis2k
356a054109
NetworkBehaviourTests: SetSyncVarNetworkIdentityWithValidObject
2020-03-07 18:53:47 +01:00
vis2k
006d3d5660
NetworkBehaviourTests: GetSyncVarGameObjectOnClientNull
2020-03-07 18:36:47 +01:00
vis2k
01a16581b3
NetworkIdentityTests: GetSyncVarGameObjectOnClient
2020-03-07 18:35:26 +01:00
vis2k
8acdd76699
NetworkBehaviourTests: GetSyncVarGameObjectOnServerNull
2020-03-07 18:31:28 +01:00
vis2k
c6c1a36559
NetworkBehaviourTests: GetSyncVarGameObjectOnServer
2020-03-07 18:29:54 +01:00
vis2k
f51e587c67
remove old empty Telepathy.dll + meta file. This causes a confusing 'failed to parse meta file' warning in Unity 2019.3, and we don't need it anymore anyway. UNET never had Telepathy.
2020-03-07 18:02:44 +01:00
vis2k
7006313aad
NetworkBehaviourTests: SetSyncVarGameObjectZeroNetId
2020-03-07 18:00:12 +01:00
vis2k
9ff2a60e7a
NetworkBehaviourTests: SetSyncVarGameObjectWithoutNetworkIdentity
2020-03-07 17:57:04 +01:00
vis2k
be422c9fda
NetworkBehavourTests: SetSyncVarGameObjectNull
2020-03-07 17:40:45 +01:00
vis2k
ab8da21853
tests: syncInterval 0 for isdirty to work
2020-03-07 17:40:37 +01:00
vis2k
87eecc5d3f
clean up too
2020-03-07 17:38:16 +01:00
vis2k
971a499a82
NetworkBehaviourTests: SetSyncVarGameObjectWithValidObject
2020-03-07 17:36:42 +01:00
vis2k
9687168ea4
NetworkBehaviourTests: SyncVarNetworkIdentityEqualUnspawnedIdentityZeroNetIdIsTrue
2020-03-07 14:55:22 +01:00
vis2k
e4e540c602
NetworkBehaviourTests: SyncVarNetworkIdentityEqualUnspawnedIdentity
2020-03-07 14:55:20 +01:00
vis2k
a9f83bb8bc
NetworkBehaviourTests: SyncVarNetworkIdentityEqualValidIdentityWithSameNetId
2020-03-07 14:55:18 +01:00
vis2k
1408e8de42
NetworkBehaviourTests: SyncVarNetworkIdentityEqualValidIdentityWithDifferentNetId
2020-03-07 14:55:16 +01:00
vis2k
c9a3a0dceb
NetworkBehaviourTests: SyncVarNetworkIdentityEqualNull
2020-03-07 14:55:14 +01:00
vis2k
f9c9e140f5
NetworkBehaviourTests: SyncVarNetworkIdentityEqualZeroNetIdNullIsTrue
2020-03-07 14:55:11 +01:00
vis2k
cdf86ee3c8
NetworkBehaviour.SyncVarNetworkIdentityEqual made internal so it can be tested. will be made static soon anyway.
2020-03-07 14:55:09 +01:00
vis2k
a67db0df86
NetworkBehaviourTests: SyncVarGameObjectEqualUnspawnedGOZeroNetIdIsTrue
2020-03-07 14:45:54 +01:00
vis2k
b400f4a04a
NetworkBehaviourTests: SyncVarGameObjectEqualUnspawnedGO
2020-03-07 14:45:51 +01:00
vis2k
5506503da4
NetworkBehaviourTests: SyncVarGameObjectEqualValidGOWithSameNetId
2020-03-07 14:45:49 +01:00
vis2k
a3ae46f8f4
NetworkBehaviourTests: SyncVarGameObjectEqualValidGOWithDifferentNetId
2020-03-07 14:45:47 +01:00
vis2k
46a13a2c2a
NetworkBehaviourTests: SyncVarGameObjectEqualZeroNetIdAndGOWithoutIdentityComponentIsTrue
2020-03-07 14:45:45 +01:00
vis2k
8edad03328
NetworkBehaviourTests: SyncVarGameObjectEqualZeroNetIdNull
2020-03-07 14:45:43 +01:00
vis2k
08f426970a
NetworkBehaviourTests: SyncVarGameObjectEqualWithoutIdentityComponent
2020-03-07 14:45:41 +01:00
vis2k
949ce8288c
NetworkBehaviourTests: SyncVarGameObjectEqualNull
2020-03-07 14:45:39 +01:00
vis2k
fa707832a9
NetworkBehaviour.SyncVarGameObjectEqual made internal so we can test it. We will make this static soon anyway.
2020-03-07 14:45:37 +01:00
vis2k
7c4ea0d08b
NetworkBehaviour.GetRpcHandler renamed to GetDelegate
2020-03-07 14:01:57 +01:00
vis2k
bf1ac3279b
improve previous test
2020-03-07 13:58:52 +01:00
vis2k
3acdd97fee
NetworkBehaviourTests: GetRpcHandler
2020-03-07 13:56:09 +01:00
vis2k
cdd7055b66
clean up last test too
2020-03-07 13:50:45 +01:00
vis2k
00ef376f2d
NetworkBehaviourTests: RegisterDelegate improved
2020-03-07 13:48:20 +01:00
vis2k
f22188ff0b
NetworkBehaviourTests: RegisterDelegateDoesntOverwrite
2020-03-07 13:43:35 +01:00
vis2k
7071794e46
NetworkBehaviour.InvokeDelegate: fix error message saying the same function twice instead of the new function
2020-03-07 13:43:27 +01:00
vis2k
88640c9d89
NetworkBehaviour.RegisterDelegate: improve syntax
2020-03-07 13:43:00 +01:00
vis2k
ab1211b287
NetworkBehaviourTests: InvokeSyncEvent
2020-03-06 16:29:23 +01:00
vis2k
05c2a13e02
NetworkBehaviourTests: SendEventInternal
2020-03-06 16:27:46 +01:00
vis2k
8e9bcac4f6
NetworkBehaviourTests: InvokeRPC
2020-03-06 10:41:48 +01:00
vis2k
3c4b2fd9d8
NetworkBehaviourTests: SendTargetRPCInternal
2020-03-06 10:39:07 +01:00
vis2k
7656a833c9
NetworkBehaviourTests: SendRPCInternal
2020-03-06 09:52:15 +01:00
vis2k
644626294b
NetworkBehaviourTests: InvokeCommand
2020-03-05 21:45:24 +01:00
vis2k
92835cfc12
NetworkBehaviourTests: clear up delegates
2020-03-05 21:43:37 +01:00
vis2k
342f5b8b98
NetworkBehaviourTests: SendCommandInternal
2020-03-05 21:43:31 +01:00
vis2k
85dab627ef
NetworkIdentityTests: clear up delegates
2020-03-05 21:43:14 +01:00
vis2k
b91ed1aead
NetworkServerTests: clear up delegates
2020-03-05 21:43:10 +01:00
vis2k
1bdd6a80b2
NetworkBehaviourTests: SendCommandInternal improved
2020-03-05 16:01:42 +01:00
vis2k
faa78493b9
NetworkBehaviourTests: SendCommandInternal
2020-03-05 15:47:26 +01:00
vis2k
b330a9c6b3
accidentally merged this one
2020-03-05 14:31:12 +01:00
vis2k
e37e2ff2fc
NetworkBehaviourTests: InitSyncObject
2020-03-05 13:42:45 +01:00
vis2k
cdea476212
NetworkBehaviourTests: HookGuard
2020-03-05 13:40:26 +01:00
vis2k
c4060df00b
NetworkBehaviourTests: OnCheckObserverTrueByDefault
2020-03-05 13:26:24 +01:00
vis2k
43909bb40e
NetworkBehaviourTests: ComponentIndex
2020-03-05 13:20:31 +01:00
vis2k
eb977896f8
NetworkIdentityTests: HasIdentitysConnectionToClient
2020-03-05 12:59:04 +01:00
vis2k
892215cfe3
NetworkIdentityTests: HasIdentitysConnectionToServer
2020-03-05 12:58:55 +01:00
vis2k
d396857148
NetworkBehaviourTests: HasIdentitysNetId
2020-03-05 12:42:03 +01:00
vis2k
6fffb051d1
NetworkBehaviourTests: HasNoAuthorityByDefault
2020-03-05 12:24:39 +01:00
vis2k
f326520d31
NetworkBehvaviourTests: simplify
2020-03-05 12:21:29 +01:00
vis2k
be6696032f
NetworkIdentityTests: IsClientOnly
2020-03-05 12:19:48 +01:00
vis2k
8f9064a923
NetworkBehaviourTests: IsServerOnly
2020-03-05 10:09:08 +01:00
vis2k
15915f573e
NetworkBehaviourTests preparations
2020-03-04 23:54:22 +01:00
vis2k
1d120a9d80
NetworkIdentity.RebuildObserver: move observers code above host visibility code
2020-03-04 18:38:17 +01:00
vis2k
d9ea5fdcf2
NetworkIdentityTests: RebuildObserversReturnsIfNull
2020-03-04 17:21:56 +01:00
vis2k
37e783f625
NetworkIdentityTests: RebuildObserversAddRemoveAndVisListTest that tests a full add/remove observers workflow
2020-03-04 17:17:21 +01:00
vis2k
0093a2cfe1
NetworkConnection.visList made internal so we can test RebuildObservers fully. It's a complex function and we need to be 100% sure that visList behaviour is correct.
2020-03-04 17:16:59 +01:00
vis2k
290561167d
NetworkIdentityTests: RebuildObserversAddsReadyComponentConnectionsIfImplemented
2020-03-04 14:55:34 +01:00
vis2k
a5f495a774
fix: NetworkIdentity.RebuildObservers: added missing null check for observers coming from components that implement OnRebuildObservers. Previously this caused a NullReferenceException.
2020-03-04 14:55:27 +01:00
vis2k
26c0c03fd8
NetworkIdentityTests: RebuildObserversSetsHostVisibility
2020-03-04 14:34:07 +01:00
vis2k
1ddb9ae075
add comment
2020-03-04 13:21:18 +01:00
vis2k
0f110eb4b7
NetworkIdentity.RebuildObservers: put conn null/ready checks into one line
2020-03-04 13:20:39 +01:00
vis2k
4ba456439a
NetworkIdentity.RebuildObservers: improve comments to explain what happens
2020-03-04 13:15:56 +01:00
vis2k
dbfd1830d3
NetworkIdentity.RebuildObservers: syntax improved
2020-03-04 13:14:26 +01:00
vis2k
1133fe4e25
forgot to remove comment
2020-03-04 09:23:23 +01:00
vis2k
8e6f5ba89c
NetworkIdentityTests: RebuildObserversDoesNotAddServerConnectionsIfImplemented
2020-03-04 09:22:04 +01:00
vis2k
9c09c26a5c
fix: SendToObservers missing result variable
2020-03-04 09:20:28 +01:00
vis2k
66d858e631
NetworkIdentityTests: RebuildObserversAddsReadyServerConnectionsIfNotImplemented
2020-03-04 09:17:47 +01:00
Paul Pacheco
9c81c9b2eb
refactor: SendToObserver returns void ( #1539 )
...
We calculate a bool out of SendToObserver, but it is not clear what it is
and we don't use the result at all. So just simplify things.
2020-03-04 08:52:17 +01:00
vis2k
549c729a07
NetworkIdentityTests: AddAllReadyServerConnectionsToObservers
2020-03-03 23:43:20 +01:00
vis2k
a5602011dd
rename to be 100% obvious
2020-03-03 23:31:44 +01:00
vis2k
66d3e8ddf7
NetworkIdentity.RebuildObservers code split into AddAllServerConnectionsToObservers helper function
2020-03-03 23:29:47 +01:00
vis2k
d6a93275f9
NetworkIdentity.RebuildObservers: result renamed to rebuildOverwritten because that's what it's for
2020-03-03 23:22:49 +01:00
vis2k
6eedd2405c
NetworkIdentity.GetNewObservers: result renamed to rebuildOverwritten because that's what it's for
2020-03-03 23:22:37 +01:00
vis2k
15a47ca19c
NetworkIdentityTests: RebuildObserversOnlyAddsOwnPlayerIfReady
2020-03-03 23:05:41 +01:00
vis2k
3e8c6089b0
NetworkIdentityTests: RebuildObserversAddsOwnReadyPlayer
2020-03-03 23:05:41 +01:00
Paul Pacheco
60226797ac
tests: Fix tests
...
CI/CD pipeline runs in headless mode, so this check is invalid
2020-03-03 15:43:25 -06:00
Paul Pacheco
108c83a43a
refactor: use NUnit idiomatic constraints
...
Why?
Suppose you have this:
```cs
Assert.That(manager.networkAddress == "localhost");
```
and suppose it fails, it will give you:
"Expected True, but got False"
which does not give you anything useful.
Suppose you have this instead:
```cs
Assert.That(manager.networkAddress, Is.EqualTo("localhost"));
```
Suppose it fails, now it will give you a much more useful error message:
"Expected 'localhost' but got 'xxxxx'"
It makes debugging tests a lot easier.
2020-03-03 15:39:25 -06:00
vis2k
fb9c55bf6e
NetworkIdentityTests cleaned up
2020-03-03 22:37:13 +01:00
vis2k
b2a094930f
syntax
2020-03-03 22:27:27 +01:00
vis2k
a302306dd1
NetworkIdentityTests: GetNewObserversFalseIfNoComponents test
2020-03-03 22:24:13 +01:00
vis2k
102484b811
NetworkIdentityTests: GetNewObserversClearsHashSet test
2020-03-03 22:24:13 +01:00
vis2k
260ca9a491
NetworkIdentityTests: GetNewObservers test
2020-03-03 22:24:13 +01:00
vis2k
01f5fb4a94
NetworkIdentity.RebuildObservers: GetNewObservers code split into separate function
2020-03-03 22:24:13 +01:00
Paul Pacheco
e00e8195bb
Simplify
2020-03-03 10:40:57 -06:00
vis2k
4bc1c3eb20
NetworkIdentityTests HandleEvent tests invalid component index / function hash too
2020-03-03 13:19:09 +01:00
vis2k
bbcc3599ef
NetworkIdentityTests HandleRpc tests invalid component index / function hash too
2020-03-03 13:19:03 +01:00
vis2k
b9dab2ca7a
NetworkIdentityTests HandleCommand tests invalid component index / function hash too
2020-03-03 13:18:55 +01:00
vis2k
ea54890dca
NetworkIdentityTests: HandleCommand/Rpc/SyncEvent tests improved
2020-03-03 13:15:54 +01:00
vis2k
6cdb9a3d8b
NetworkIdentityTests: HandleSyncEvent
2020-03-03 13:08:58 +01:00
vis2k
0f362ec1cf
NetworkIdentityTests: HandleRPC
2020-03-03 13:06:20 +01:00
vis2k
598766764c
typo
2020-03-03 13:03:25 +01:00
vis2k
0b257fbd3a
NetworkIdentityTests: HandleCommand
2020-03-03 13:02:44 +01:00
vis2k
bd9747e735
NetworkReader/WriterTest: benchmark doesn't need to run each time, takes at least 6s together.
2020-03-03 12:15:07 +01:00
uwee
67462553fb
test add NetworkManagerTests ( #1537 )
...
* test add NetworkManagerTests
not complete and 1 does not reliably work
* fix broken client test
* remove incomplete test for NG
* added more state checking
* shutdown state test
* add startposition tests
2020-03-03 09:28:28 +01:00
Lymdun
ca166bd95f
Improve LocalConnectionTest ( #1538 )
2020-03-02 22:41:27 +01:00
vis2k
e9d4f04da5
typo
2020-03-02 15:55:01 +01:00
vis2k
7df6e79b61
NetworkIdentityTests: AssignAndRemoveClientAuthority improved
2020-03-02 15:54:47 +01:00
vis2k
4b6affb523
NetworkIdentityTests: AssignAndRemoveClientAuthority test improved
2020-03-02 15:50:32 +01:00
vis2k
eb958ae182
NetworkIdentity.AssignClientAuthority: null check first. more obvious error message and easier to test.
2020-03-02 15:50:13 +01:00
vis2k
66a9127b96
NetworkIdentityTests: AssignAndRemoveClientAuthority
2020-03-02 15:40:26 +01:00
vis2k
9c8d6f3cb1
NetworkIdentityTests: ServerUpdate
2020-03-02 13:28:10 +01:00
vis2k
97a5a1211d
add comment
2020-03-02 12:13:23 +01:00
vis2k
b787274732
forgot to save
2020-03-02 12:07:56 +01:00
vis2k
5a1bfdf1a4
NetworkIdentity.MirrorUpdate renamed to ServerUpdate because that's what it does
2020-03-02 12:06:12 +01:00
vis2k
de4a7107a6
NetworkIdentityTests: Reset
2020-03-02 11:44:36 +01:00
vis2k
e43ed3e09d
NetworkIdentityTests: ClearAllComponentsDirtyBits
2020-03-02 11:14:27 +01:00
vis2k
f9fdca3598
NetworkIdentityTests: ClearDirtyComponentsDirtyBits test improved
2020-03-02 11:09:16 +01:00
vis2k
eac93e1a27
NetworkIdentityTests: ClearDirtyComponentsDirtyBits
2020-03-02 11:07:07 +01:00
uwee
df430e1bfc
Test coverage for NetworkTransformChild ( #1536 )
...
* Test coverage for NetworkTransformChild
* add missing meta file
* applied codacy suggestions
2020-03-02 09:44:39 +01:00
uwee
05a44b9c6f
adds missing addplayertest ( #1530 )
...
* adds missing addplayertest
code is set to depreciate but should still be covered until then.
* remove json file from commit
opps
* updated to include suggestions from Codacy
2020-03-02 09:43:10 +01:00
Paul Pacheco
22636c9a6c
Disable telepathy tests until they are fixed ( #1534 )
2020-03-02 09:40:04 +01:00
vis2k
65645dd266
NetworkIdentity: AssignClientAuthority moved above RemoveClientAuthority
2020-03-01 12:05:46 +01:00
vis2k
508e253bb1
NetworkIdentityTests: AddObserver
2020-03-01 12:02:25 +01:00
vis2k
8cd50cf9f2
NetworkIdentityTests: make sure that calling OnStartClient twice will return early
2020-03-01 11:54:23 +01:00
vis2k
90cece63dc
NetworkIdentityTests: ClearObservers
2020-03-01 11:54:02 +01:00
vis2k
d9036a6a79
CustomAttributeTests: use channels enum
2020-03-01 11:41:25 +01:00
uwee
b440130647
adds test coverage for CustomAttribute ( #1531 )
2020-03-01 11:13:48 +01:00
vis2k
3bc38d8938
copy paste error
2020-02-28 16:56:38 +01:00
vis2k
4357752f91
NetworkIdentityTests: OnNetworkDestroy
2020-02-28 16:55:22 +01:00
vis2k
6b35bf0133
NetworkIdentity.OnNetworkDestroy moved upwards and catches exceptions now too
2020-02-28 16:55:14 +01:00
vis2k
62c5cf4b14
fix error log
2020-02-28 16:54:55 +01:00
vis2k
5ed5f84409
fix: NetworkIdentity.OnStartLocalPlayer catches exceptions now too. fixes a potential bug where an exception in PlayerInventory.OnStartLocalPlayer would cause PlayerEquipment.OnStartLocalPlayer to not be called
2020-02-28 16:33:59 +01:00
vis2k
4926bb818a
add comments
2020-02-28 16:32:48 +01:00
vis2k
fc7d2e8df6
NetworkIdentity: OnStartLocalPlayer moved next to OnStartClient
2020-02-28 16:31:39 +01:00
vis2k
1c356bff44
NetworkIdentity: remove redundant OnUpdateVars function
2020-02-28 16:26:05 +01:00
vis2k
782848094b
NetworkIdentityTests: OnStartLocalPlayer
2020-02-28 16:23:14 +01:00
vis2k
bbaad910f7
NetworkIdentityTests: OnDeserializeSafelyShouldDetectAndHandleDeSerializationMismatch
2020-02-28 16:10:48 +01:00
vis2k
fe7c1c7f50
improve previous test
2020-02-28 15:43:01 +01:00
vis2k
0df42ebf75
NetworkIdentityTests: OnSerializeAllSafelyShouldDetectTooManyComponents
2020-02-28 15:41:34 +01:00
vis2k
bfe09ab141
NetworkIdentityTests: OnSerializeAndDeserializeAllSafely
2020-02-28 15:35:37 +01:00
vis2k
a5269b4261
NetworkIdentityTests: OnCheckObserver
2020-02-28 11:58:51 +01:00
vis2k
f21b80b8b0
NetworkIdentityTests: OnSetHostVisibilityCallsComponentsAndCatchesExceptions
2020-02-27 10:23:44 +01:00
vis2k
cd4e39729e
NetworkIdentityTests: NotifyAuthorityCallsOnStartStopAuthority
2020-02-27 10:19:16 +01:00
vis2k
44addfa336
NetworkIdentityTests: rename
2020-02-27 10:10:54 +01:00
vis2k
47b1aa7400
NetworkIdentityTests: OnStopAuthorityComponentExceptionIsCaught
2020-02-27 10:10:07 +01:00
vis2k
b62487cf87
NetworkIdentity.OnStopAuthority made internal for consistency with OnStartServer/OnStartClient, and so that we can test it
2020-02-27 10:08:45 +01:00
vis2k
e87c1d6a26
add comments
2020-02-27 10:08:36 +01:00
vis2k
85aae6482d
NetworkIdentityTests: OnStartAuthorityComponentExceptionIsCaught
2020-02-27 10:06:56 +01:00
vis2k
0965283c53
NetworkIdentity.OnStartAuthority made internal for consistency with OnStartServer/OnStartClient, and so that we can test it
2020-02-27 10:06:46 +01:00
vis2k
6183cae611
NetworkIdentityTests: OnStartClient test makes sure that OnStartClient was called exactly once
2020-02-27 10:05:07 +01:00
vis2k
f6c8e0e89e
NetworkIdentityTests: OnStartServer test makes sure that OnStartServer was called exactly once
2020-02-27 10:04:58 +01:00
vis2k
617bd0a175
NetworkIdentity.OnStartClient: added comment
2020-02-27 09:53:24 +01:00
vis2k
53499f031f
NetworkIdentityTests: OnStartClientComponentExceptionIsCaught
2020-02-27 09:53:24 +01:00
Paul Pacheco
59faa81926
fix: build in IL2CPP ( #1524 )
...
The weaver generated code now builds properly under IL2CPP
fixes #1519
fixes #1520
2020-02-26 18:02:14 -06:00
vis2k
ae451e6fe0
NetworkIdentityTests: OnStartServerInHostModeSetsIsClientTrue to make sure that isClient is true in OnStartServer if in host mode. we fixed the bug recently, now we have a test too
2020-02-26 22:08:47 +01:00
vis2k
6f3c286a62
Tests: MemoryTransport for easier testing
2020-02-26 21:56:55 +01:00
vis2k
89859c9fd4
NetworkIdentityTests: OnStartServerComponentExceptionIsCaught
2020-02-26 20:01:21 +01:00
vis2k
1b624f12e0
add comment
2020-02-26 19:55:27 +01:00
vis2k
42c0128f18
NetworkIdentityTests: OnValidateSetupIDsSetsEmptyAssetIDForSceneObject
2020-02-26 19:42:01 +01:00
vis2k
a0f798f65f
NetworkIdentityTests: SetSceneIdSceneHashPartInternal
2020-02-26 19:34:35 +01:00
vis2k
12d2c68301
NetworkIdentityTest: make sure that it's added to sceneId dict too
2020-02-26 19:25:20 +01:00
vis2k
8ca4deb61d
NetworkIdentityTests: AssignSceneID
2020-02-26 19:23:32 +01:00
vis2k
4b430d98f7
NetworkIdentityTests: RemoveObserverInternal
2020-02-26 19:12:34 +01:00
vis2k
4d2c81e12e
NetworkIdentityTests: SetClientOwner test to make sure the previous commit's bug doesn't happen again
2020-02-26 18:30:55 +01:00
vis2k
548db52fdf
fix: NetworkIdentity.SetClientOwner: overwriting the owner was still possible even though it shouldn't be. all caller functions double check and return early if it already has an owner, so we should do the same here.
2020-02-26 18:30:30 +01:00
vis2k
1a9625ee4a
NetworkIdentity.SetClientOwner: improve error message
2020-02-26 18:28:57 +01:00
vis2k
4269cfe43c
NetworkIdentityTests: cleanup spawned dict too
2020-02-26 18:19:11 +01:00
vis2k
ebe12b6cdb
NetworkIdentityTest: GetSetAssetId
2020-02-26 18:15:14 +01:00
vis2k
22ee387470
NetworkIdentityTests: proper GameObject cleanup
2020-02-26 18:12:45 +01:00
vis2k
66776a744d
NetworkServer.UnSpawn test
2020-02-26 17:40:07 +01:00
vis2k
29fe487954
NetworkIdentity.IsMarkedForReset helper function to check reset state
2020-02-26 17:39:57 +01:00
vis2k
8a05826ca4
NetworkServerTest.SpawnObject: make sure that it doesn't touch non-scene-objects
2020-02-26 17:30:19 +01:00
vis2k
708d7838d6
NetworkServerTest: SpawnObjects
2020-02-26 17:20:35 +01:00
vis2k
d4d524dad2
fix: NetworkServer.SpawnObjects: return false if server isn't running
2020-02-26 17:16:38 +01:00
vis2k
cdfc1752f2
NetworkServerTest: ValidateSceneObject
2020-02-26 17:08:36 +01:00
vis2k
e409ed8f48
NetworkServer.ValidateSceneObject made internal so it can be tested and reused if needed
2020-02-26 17:01:31 +01:00
vis2k
1be758b12b
syntax
2020-02-26 17:01:10 +01:00
vis2k
c8fbea387d
update comment
2020-02-26 16:57:09 +01:00
vis2k
bba4ebd154
NetworkServerTest: CommandTest tries invalid netid and command without authority too
2020-02-26 10:27:36 +01:00
vis2k
038e3c1969
NetworkServerTest: HideForConnection
2020-02-26 10:14:42 +01:00
vis2k
9bdfb676e3
NetworkServerTest: ShowForConnection
2020-02-26 10:11:00 +01:00
vis2k
5cdf02b258
NetworkServerTest: GetNetworkIdentity
2020-02-25 22:25:47 +01:00
vis2k
67a2a85cb9
NetworkServer.GetNetworkIdentity made internal so it can be tested and reused in other places if needed
2020-02-25 22:25:39 +01:00
vis2k
e7c9dc4f6e
NetworkServerTest: SendToClientOfPlayer
2020-02-25 22:13:58 +01:00
vis2k
c2afc05692
NetworkServerTest: RegisterUnregisterClearHandlerTest
2020-02-25 22:07:44 +01:00
vis2k
212af3fc9d
NetworkServerTest: RegisterHandlerTest
2020-02-25 22:01:48 +01:00
vis2k
d4f21c0818
remove unused var
2020-02-25 11:53:04 +01:00
vis2k
48bdc68906
NetworkServerTest: SendToAllTest
2020-02-25 11:35:15 +01:00
vis2k
4596b19dd9
fix: SendToReady sends to that exact connection if it is detected as local connection, instead of falling back to the .localConnection field which might be something completely different.
2020-02-25 11:14:26 +01:00
vis2k
4b90aafe12
fix: SendToAll sends to that exact connection if it is detected as local connection, instead of falling back to the .localConnection field which might be something completely different.
2020-02-25 11:13:59 +01:00
vis2k
4267983139
fix: SendToObservers sends to that exact connection if it is detected as local connection, instead of falling back to the .localConnection field which might be something completely different.
2020-02-25 11:13:38 +01:00
vis2k
a497803de0
NetworkServerTests: use call counts instead of bools to make sure that it's called exactly once
2020-02-25 11:00:35 +01:00
vis2k
69bb1574f0
NetworkServerTest: ActivateHostSceneCallsOnStartClient
2020-02-25 10:36:40 +01:00
vis2k
f378333000
NetworkServer.ActivateLocalClientScene renamed to ActivateHostScene because that's what it really does. It does NOT do something for every local client on a client. Only for a host.
2020-02-25 10:31:30 +01:00
vis2k
5efaa4af1a
CommandMessageCallsCommandTest: use two components to make sure that the correct one is used by the command
2020-02-24 15:44:05 +01:00
vis2k
1315bd3dde
CommandMessageCallsCommandTest: proper usage of weaver generated command code (static!)
2020-02-24 15:40:06 +01:00
vis2k
6d2b4eb102
remove comment
2020-02-24 15:37:31 +01:00
vis2k
e6b12133d1
remove comment
2020-02-24 15:35:46 +01:00
vis2k
3eb1e8968c
add comment
2020-02-24 15:35:16 +01:00
vis2k
02c31d0805
NetworkServerTest: CommandMessageCallsCommandTest to run a full command through our pipeline
2020-02-24 15:31:53 +01:00
vis2k
e9c6f6f2a9
NetworkBehaviour.GetMethodHash made internal for tests
2020-02-24 15:31:53 +01:00
vis2k
e6cd2e2280
NetworkBehaviour.RegisterRpc/Command/EventDelegate made public for tests. internal won't work because they are called from outside assemblies like NetworkTransform. protected won't work because then we can't test them from the outside.
2020-02-24 15:31:53 +01:00
vis2k
31af385a70
NetworkBehaviour.ClearDelegates added for tests
2020-02-24 15:31:53 +01:00
vis2k
215e973903
NetworkServerTest: ReadyMessageSetsClientReadyTest
2020-02-24 14:46:58 +01:00
vis2k
dc29106370
NetworkServerTest.TearDown rests state
2020-02-24 14:32:41 +01:00
vis2k
ea0b20636b
NetworkServerTest: SetAllClientsNotReadyTest
2020-02-24 14:31:30 +01:00
vis2k
012c053597
NetworkServerTest: SetClientReadyAndNotReadyTest
2020-02-24 11:26:19 +01:00
vis2k
3bd947a973
NetworkServerTest: OnDataReceivedInvalidConnectionIdTest
2020-02-24 11:17:53 +01:00
vis2k
e49f4e0aff
NetworkServerTest: OnDataReceivedTest
2020-02-24 11:14:11 +01:00
vis2k
ad0d20144a
NetworkServerTests: ConnectDuplicateConnectionIdsTest
2020-02-24 10:51:04 +01:00
vis2k
9c325abbd8
NetworkServerTests: OnConnectedOnlyAllowsGreaterZeroConnectionIdsTest
2020-02-24 10:48:39 +01:00
vis2k
47a4ac7ff7
NetworkServerTest: SetLocalConnectionTest checks overwrite too
2020-02-24 10:43:19 +01:00
Paul Pacheco
f0a993c106
fix: properly detect NT rotation ( #1516 )
2020-02-23 20:46:06 +01:00
MrGadget
8417465413
Make StartHost Not virtual ( #1513 )
2020-02-23 14:40:06 +01:00
vis2k
1cce3164b9
NetworkServerTest: DisconnectAllTest
2020-02-23 11:43:08 +01:00
vis2k
357ad0ffb6
add comment
2020-02-23 11:40:47 +01:00
vis2k
a57a46764e
NetworkServerTest: DisconnectAllConnectionsTest
2020-02-23 11:40:01 +01:00
vis2k
fe1b158b22
NetworkServerTest: RemoveLocalConnectionTest
2020-02-23 11:36:14 +01:00
vis2k
ad0442be02
NetworkServerTest: RemoveConenctionTest
2020-02-23 11:30:58 +01:00
vis2k
8b16c7c343
NetworkServerTest: AddConnectionTest tests duplicate too
2020-02-23 11:29:08 +01:00
vis2k
12faf65d18
NetworkServerTest: AddConnectionTest
2020-02-23 11:25:20 +01:00
vis2k
a0d6a02a99
NetworkServer.Reset made obsolete
2020-02-23 11:20:42 +01:00
vis2k
5de22d2ff2
NetworkServerTests: ShutdownCleanupTest improved
2020-02-23 11:18:54 +01:00
vis2k
45ba9a9939
syntax
2020-02-23 11:17:40 +01:00
vis2k
7b6f1326eb
NetworkServertest: LocalClientActiveTest
2020-02-23 11:17:17 +01:00
vis2k
1e198e4bcc
remove unnecessary assert
2020-02-23 11:16:05 +01:00
vis2k
7333cc8f46
NetworkServerTest: SetLocalConnectionTest
2020-02-23 11:15:03 +01:00
vis2k
ec23c1fc58
NetworkServerTests: ShutdownCleanupTest
2020-02-23 11:13:11 +01:00
vis2k
ab98846566
NetworkServerTest: ConnectionsDictTest
2020-02-23 11:06:35 +01:00
vis2k
933ce4a3d5
NetworkServerTests: DisconnectMessageHandlerTest
2020-02-23 11:02:05 +01:00
vis2k
77929e9aa0
NetworkServerTests: ConnectMessageHandlerTest
2020-02-23 11:00:16 +01:00
vis2k
b1ff0757ee
NetworkServerTest: MaxConnectionsTest
2020-02-23 10:58:07 +01:00
vis2k
f750d77a8c
NetworkServerTests: IsActiveTest
2020-02-23 10:19:38 +01:00
Chris Langsenkamp
e1d1d41ed6
fix: Room example to use new override
2020-02-23 02:43:53 -05:00
Chris Langsenkamp
b5dfcf45bc
feat: Added NetworkConnection to OnRoomServerSceneLoadedForPlayer
2020-02-22 18:46:47 -05:00
Chris Langsenkamp
b39b4ffc62
Removed extraneous blank line
2020-02-22 17:40:58 -05:00
MrGadget
f53b12b2f7
feat: Cosmetic Enhancement of Network Manager ( #1512 )
...
* Cosmetic enhancement to Network Manager
* Removed region block
2020-02-22 20:25:46 +01:00
Chris Langsenkamp
8487be877d
Added missing blank line
2020-02-20 19:45:27 -05:00
MrGadget
8bf6690312
Remove Redundant Set of mode = Offline ( #1510 )
...
* Remove redundant code
* Removed blank line
2020-02-20 19:19:28 +01:00
MrGadget
b33515ba8f
Rearranged StartHost methods ( #1506 )
...
* Rearranged StartHost methods
* Added braces
* Moved and added comments.
* moved finishStartHostPending per Vis2k request
2020-02-20 12:58:58 +01:00
MrGadget
b8bcd9ad25
fix: Add missing channelId to NetworkConnectionToClient.Send calls ( #1509 )
...
* fix: Add missing channelId to NetworkConnectionToClient.Send calls
* Updated ChangeLog
* Added braces
* Found one more
2020-02-20 09:51:03 +01:00
MrGadget
61fdd892d9
fix: return & continue on separate line ( #1504 )
...
* fix: return & continue on separate line
* Update Assets/Mirror/Runtime/Transport/Telepathy/Server.cs
2020-02-17 16:48:41 +01:00
MrGadget
ecc0659b87
feat: Check for client authority in NetworkAnimator Cmd's ( #1501 )
2020-02-15 16:18:01 +01:00
MrGadget
8b359ff6d0
feat: Check for client authority in CmdClientToServerSync ( #1500 )
2020-02-15 08:33:14 +01:00
MrGadget
7bb80e3b79
feat: NetworkSceneChecker use Scene instead of string name ( #1496 )
...
* NetworkSceneChecker use Scene instead of string name
* Added comment
2020-02-15 08:32:34 +01:00
MrGadget
4c4a52bff9
fix: Host Player Ready Race Condition ( #1498 )
2020-02-15 08:32:12 +01:00
Chris Langsenkamp
1662c5a139
fix: Fixed NetworkRoomManager Template
2020-02-14 00:45:04 -05:00
Chris Langsenkamp
853e5ab7d7
Simplified Additive example code
2020-02-12 20:09:37 -05:00
Chris Langsenkamp
e467921377
fixed obsolete comment
2020-02-11 11:55:22 -05:00
Chris Langsenkamp
79708d94a2
breaking: bump version to 10
2020-02-11 09:39:06 -05:00
MrGadget
0e80e1996f
feat: Block Play Mode and Builds for Weaver Errors ( #1479 )
...
* WIP first draft
* Much closer now
* Whoop! There it is!
* Added comment
* Restore Player
* Moved WeaveFailed back where it was
* Restore delegate wireup
* Moved the delegate wireup and added comments
* Formatted comment and error message
* Added comment
* Use a separate session bool
* Code formatting
* Delete Mirror.Editor.asmdef
* Add Debug
* No WeaveExistingAssemblies
* Revert "No WeaveExistingAssemblies"
This reverts commit 50d4790ee4185b403361f7647cce3f
2020-02-10 23:23:34 +01:00
MrGadget
bb55baa679
feat: Disposable PooledNetworkReader / PooledNetworkWriter ( #1490 )
...
* Inherit IDisposable
* using NetworkWriter from pool
* Remove Recycles
* Add comments to Recycle
* Add comments to Recycle
* using NetworkReader from pool
* Unity doesn't like the simplified form
* combined usings
* Updated Reader / Writer Tests
* wip
* Disposable NetworkReaderPool:NetworkReader
* uncomment NetworkDiagnostics.OnReceive
* Removed unnecessary constructor
* Implemented NetworkWriterPool : NetworkWriter
* code cleanup
* Separated classes: PooledNetworkReader / PooledNetworkWriter
* Removed blank line
* Update Assets/Mirror/Tests/Editor/NetworkReaderTest.cs
* Test restored
Co-authored-by: Paul Pacheco <paulpach@gmail.com>
2020-02-10 22:26:55 +01:00
Chris Langsenkamp
436d8fe831
fixed xml comment
2020-02-10 16:18:11 -05:00
Chris Langsenkamp
745aea8f9a
Added Deprecated dates to Obsoletes
2020-02-10 16:14:22 -05:00
Paul Pacheco
0f10c72744
feat: supports scriptable objects ( #1471 )
...
* feat: supports scriptable objects
Now you can pass scriptable objects in commands, rpcs and syncvars
For example:
```cs
class Weapon: ScriptableObject
{
public string name;
public string description;
public int damage;
...
}
class Player : NetworkBehaviour
{
[SyncVar]
Weapon equipped;
...
}
```
Scriptable objects will be created in the client using
ScriptableObject.CreateInstance. If users want something else
they can provide a custom serializer (that has not changed)
* fix: remove scriptableobject error Tests
The test that checks that scrscriptableobjects give error is no
longer valid
2020-02-09 20:16:13 +01:00
Chris Langsenkamp
ab6a03b9fa
remove SerializeField attribute
2020-02-08 21:08:38 -05:00
Chris Langsenkamp
831db2f033
Updated comments
2020-02-08 21:07:39 -05:00
Chris Langsenkamp
6431c28a12
OnEnable is safer than Awake
2020-02-08 21:02:22 -05:00
MrGadget
90d92fc0cf
Add headless check to Discovery ( #1485 )
2020-02-07 12:13:09 +01:00
vis2k
9f7c30c1ac
fix #1475 : isClient is true in OnDestroy on host/client mode again. Reverts commit d00c95bb55 ( #1483 )
...
* fix #1475 : isClient is true in OnDestroy on host/client mode again. Reverts commit d00c95bb55
2020-02-07 10:14:54 +01:00
Chris Langsenkamp
c06ea6b6c8
Fix comment
2020-02-06 11:51:38 -05:00
vis2k
3568dc356c
NetworkIdentityTests: HostMode isLocalPlayer check added
2020-02-06 13:16:13 +01:00
vis2k
85e9a0aa13
NetworkIdentityTests: HostMode isServer/isClient/isLocalPlayer test added
2020-02-06 12:42:19 +01:00
vis2k
09ec344821
NetworkIdentityTests: OnStartServer isServer/isClient/isLocalPlayer test added
2020-02-06 12:36:36 +01:00
MrGadget
58df3fd6d6
feat: Added Read<T> Method to NetworkReader ( #1480 )
...
* Added Read<T> Method
* Renamed to ReadMessage
2020-02-06 11:39:39 +01:00
MrGadget
02e4245f3d
BREAKING: Rename NetworkWriter Write<T>to WriteMessage ( #1482 )
2020-02-06 11:38:54 +01:00
Chris Langsenkamp
1c58891e32
Formatted comment and error message
2020-02-05 10:29:49 -05:00
Chris Langsenkamp
86a2c6f52c
Added comments for WeaveFailed
2020-02-05 10:15:09 -05:00
Chris Langsenkamp
4108b79340
Code cleanup
2020-02-05 00:53:14 -05:00
Chris Langsenkamp
34fc52bd50
Added empty AddComponent attribute
2020-02-04 15:05:57 -05:00
Chris Langsenkamp
c7e269d0c5
Removed extraneous comment
2020-02-04 14:55:42 -05:00
vis2k
f614bc8f3a
Icon updated for transparent border
2020-02-04 20:53:48 +01:00
Paul Pacheco
36980f4a34
Refactor: Rename method to avoid confussion ( #1477 )
2020-02-03 10:00:58 -06:00
Paul Pacheco
d0b0bc92bc
fix: weaver support array of custom types ( #1470 )
...
* WIP
* Proposed Rearrange
* Rearrange Code
* Unit test for PR
* unit test
* unit test
* Update TestingScriptableObjectArraySerialization.cs
Improving code
* Update TestingScriptableObjectArraySerialization.cs
* Remove blank lines
* remove blank space
* Remove leftover log
Co-authored-by: MrGadget <chris@clevertech.net>
Co-authored-by: Uchiha I_A_H_I <jkaran.sharma101@gmail.com>
2020-02-03 14:00:37 +01:00
Paul Pacheco
1736bb0c42
fix: call callback after update dictionary in host ( #1476 )
...
When the callback for SyncDictionary is called in the server
for set or add
it is getting called before the syncdictionary is updated.
In the client this happens after.
Example:
```cs
public void OnScoreUpdatedCallback(ScoreSyncDict.Operation op, uint ident, int score)
{
if (op == ScoreSyncDict.Operation.OP_SET)
Debug.Log($"The value in the dictionary is {scoreDict[ident]}");
}
```
In host mode this prints the previous value. In client mode this prints the current value. This PR fixes this problem and makes both print the current value
2020-02-02 20:29:31 -06:00
Chris Langsenkamp
c2e7466c43
Updated Preprocessor defines
2020-02-02 15:18:49 -05:00
Chris Langsenkamp
c827216a66
Restructured prefabs in examples
2020-02-02 14:55:49 -05:00
MrGadget
eee969201d
Renamed localEulerAnglesSensitivity ( #1474 )
...
BREAKING CHANGE: localEulerAnglesSensitivity renamed to localRotationSensitivity
2020-02-02 13:35:07 -06:00
Chris Langsenkamp
8816ce5d03
Add headers for inspector
2020-02-02 13:53:25 -05:00
MrGadget
7c1b5ab5f8
Add Header to NetworkBehaviourInspector ( #1473 )
2020-02-02 13:40:30 -05:00
MrGadget
9257112c65
feat: Implemented NetworkReaderPool ( #1464 )
...
* Implement NetworkReaderPool
* Reset Position
* Debug logging removed
* SetBuffer methods internal
* Edited comment
2020-02-01 14:05:09 +01:00
Chris Langsenkamp
d0e493ac92
Updated ScriptTemplates
2020-01-31 21:25:38 -05:00
Chris Langsenkamp
a28ccbb477
Allow Room Manager Additional GamePlay Scenes
2020-01-31 21:18:01 -05:00
Chris Langsenkamp
1433d369c8
Applied Mirror Icon to Discovery components
2020-01-30 15:40:23 -05:00
MrGadget
28212aa8d7
Message Tests ( #1463 )
...
* Added UpdateVarsMessageTest
* commit staged
* Added SpawnMessageTest
* Delete MessageTests.cs
* Updated SpawnMessageTest
* Updated SpawnMessageTest
* Updated SpawnMessageTest
* Added RemovePlayerMessageTest
* Added ReadyMessageTest
* Added ObjectSpawnStartedMessageTest
* Added ObjectSpawnFinishedMessageTest
* Added ObjectHideMessageTest
* Added ObjectDestroyMessageTest
* Added NotReadyMessageTest
* Added DisconnectMessageTest
* Added ConnectMessageTest
* Added NetworkPingMessageTest
* Updated NetworkPingMessageTest
* Added NetworkPongMessageTest
* Updated ErrorMessageTest
* Tests in alphabetic order
2020-01-30 09:42:05 +01:00
MrGadget
e44ca7f334
BasicAuthenticatorTest ( #1459 )
...
* First Draft
* Second Draft
* Third Draft
* First 2 tests that work
2020-01-29 20:44:30 +01:00
vis2k
93a9eb8339
Disable two telepathy tests that sometimes fail in Unity's mono version
2020-01-29 20:29:21 +01:00
vis2k
d0d77b661c
fix: Telepathy reverted to older version to fix freezes when calling Client.Disconnect on some platforms like Windows 10
2020-01-29 20:20:18 +01:00
Paul Pacheco
e75b45f888
feat: LAN Network discovery ( #1453 )
...
* Fix typo
* Updated Changelog
* first commit
* Add example for discovery
* NetworkDiscovery component should be added
* fixed UI
* Fix some warnings
* refactor: network discovery reimplemented
* Remove unused GUIstyle
* Fix namespaces
* Just send to the broadcast address
* Fix indentation
* Log errors in ClientListen
* Code formatting cleanup, HelpURL's fixed, comments revised. (#38 )
* Transport can now provide server uri
* work with any transport by passing uri
* Move discovery initialization to start
* feat: Discovery can now be easily customized per game
* Use generics to simplify api
* Renamed ServerInfo -> ServerResponse
* Rename method
* Moved up one folder
* Move ServerId to NetworkDiscovery
* tests now reference Mirror.Discovery
* Cleaned up blank space
* Disable GUID apparently fixes it
* Use UnityEvents for ease of use
* Remove noisy log
* remove blank spaces
* Process request receives the client endpoint
* use consistent name for parameters
* Remove white space
* Keep it minimalistic, we don't need age or totalPlayers
* Comment non obvious property
* Don't break transports
* Documentation and image
* Code formatting
* removed privates
* Added Range attribute
* Rename ActiveDiscoverySecondInterval
* Revised NetworkDiscovery doc
* Swapped field order (Cosmetics)
* Added ScriptTemplate
* Update ProjectSettings/ProjectVersion.txt
* Updated ScriptTemplate
* Updated xml comment and ScriptTemplate
* Updated ScriptTemplate
* Improve xmldocs
* Improve xmldocs
* Remove leftover comment
* Renamed event
* Moved discovery inside components
* Keep parameter names consistent
* Provide a guide for network discovery
* XML Comments and ScriptTemplate
* Moved Credits
* fixed template
* Removed comment
* removed comment
* xml comments and template
* fixed method name
* fixed method and template
* removed semicolon
* fixed template
* fixed method and template
* fixed template
* fixed template
* Fix copypasta error
* Show error if no url is available
Network Discovery now shows an error if the transport does not support
providing Url
* Grammar fix
* Extended Template
* fixed template
* Added guide link to template
* New image
* Update NetworkDiscovery.md
* Updated Guid Doc and Template
* fixed bullets
* Remove unnecessary using
* Make it like Mirror's
* Update ScriptTemplates Image & Zip
* Removed from Deprecations
* Updated ChangeLog
* Updated ChangeLog
* Update NetworkDiscovery.md
Remove last line...this was copied to the paragraph above the code block
Co-authored-by: MrGadget <chris@clevertech.net>
2020-01-29 09:56:29 +01:00
MrGadget
9621b0bd30
Update PreprocessorDefines ( #1456 )
...
* Update PreprocessorDefines
* Removed 8
* Update PreprocessorDefine.cs
2020-01-29 09:53:39 +01:00
MrGadget
d52aa7e173
Prevent AddPlayer after Additve Scene operation ( #1458 )
2020-01-28 22:54:46 +01:00
Paul Pacheco
b916064856
breaking: Transports can now provide their Uri ( #1454 )
...
* Fix typo
* Updated Changelog
* first commit
* Add example for discovery
* NetworkDiscovery component should be added
* fixed UI
* Fix some warnings
* refactor: network discovery reimplemented
* Remove unused GUIstyle
* Fix namespaces
* Just send to the broadcast address
* Fix indentation
* Log errors in ClientListen
* Code formatting cleanup, HelpURL's fixed, comments revised. (#38 )
* Transport can now provide server uri
* work with any transport by passing uri
* Move discovery initialization to start
* feat: Discovery can now be easily customized per game
* Use generics to simplify api
* Renamed ServerInfo -> ServerResponse
* Rename method
* Moved up one folder
* Move ServerId to NetworkDiscovery
* tests now reference Mirror.Discovery
* Cleaned up blank space
* Disable GUID apparently fixes it
* Use UnityEvents for ease of use
* Remove noisy log
* remove blank spaces
* Process request receives the client endpoint
* use consistent name for parameters
* Remove white space
* Keep it minimalistic, we don't need age or totalPlayers
* Comment non obvious property
* Don't break transports
* Documentation and image
* Code formatting
* removed privates
* Added Range attribute
* Rename ActiveDiscoverySecondInterval
* Revised NetworkDiscovery doc
* Swapped field order (Cosmetics)
* Added ScriptTemplate
* Update ProjectSettings/ProjectVersion.txt
* Updated ScriptTemplate
* Updated xml comment and ScriptTemplate
* Updated ScriptTemplate
* Improve xmldocs
* Improve xmldocs
* Remove leftover comment
* Renamed event
* Moved discovery inside components
* Keep parameter names consistent
* Provide a guide for network discovery
* XML Comments and ScriptTemplate
* Moved Credits
* fixed template
* Removed comment
* removed comment
* xml comments and template
* fixed method name
* fixed method and template
* removed semicolon
* fixed template
* fixed method and template
* fixed template
* fixed template
* Fix copypasta error
* Show error if no url is available
Network Discovery now shows an error if the transport does not support
providing Url
* breaking: Make server uri mandatory
BREAKING CHANGE: Make the server uri method mandatory in transports
Co-authored-by: MrGadget <chris@clevertech.net>
2020-01-28 22:50:52 +01:00
MrGadget
a706ef72e2
Make the Dictionary public ( #1457 )
2020-01-28 08:49:50 +01:00
MrGadget
a7efb13e29
feat: Mirror Icon for all components ( #1452 )
...
* Apply Icon
* Assigned Icons
* Assigned Icons
* Updated ChangeLog
2020-01-27 18:00:27 +01:00
vis2k
ab7c28ea91
Telepathy Tests added
2020-01-27 14:53:43 +01:00
vis2k
4007423db2
fix: Telepathy updated to latest version. Threads are closed properly now.
2020-01-27 14:43:00 +01:00
vis2k
ef7993cac1
MessageTests: SyncEventMessageTest
2020-01-27 14:32:31 +01:00
vis2k
8d272a4107
MessageTests: RpcMessageTest
2020-01-27 14:32:31 +01:00
vis2k
0b2965af1c
MessageTests: CommandMessageTest
2020-01-27 14:32:31 +01:00
MrGadget
49529db347
Restore Empty NetworkIdentityEditor ( #1455 )
2020-01-27 09:18:41 +01:00
vis2k
1a08f1b95d
NetworkWriterTests: benchmark test so it's easier to check performance after changes
2020-01-26 13:12:39 +01:00
Paul Pacheco
0c2556ac64
feat: network writer and reader now support uri
2020-01-25 16:16:14 -06:00
MrGadget
71c0d3b2ee
feat: Network Scene Checker Component ( #1271 )
...
* Create Network Scene Checker Component
* Move objects to subscene in client
* Remove OnStartClient
* Rewritten with static dictionary
* Updated doc
* renamed image
* Replaced image
* fixed image name
* Changed to short-circuit return in Update
* Changed to using string for key since additive scenes may be unloaded
* Added null check
* Removed commented line
* Update Assets/Mirror/Components/NetworkSceneChecker.cs
Co-Authored-By: vis2k <info@noobtuts.com>
* Moved initializer to declaration
* Removed [Scene, SerializeField]
Co-authored-by: vis2k <info@noobtuts.com>
2020-01-25 15:48:47 -05:00
Chris Langsenkamp
e58f84758e
set port to 7777
2020-01-25 00:38:21 -05:00
MrGadget
dde8c5d0c5
Remove m_sceneId ( #1310 )
...
* Remove m_sceneId
* remove commented code
* copied comment from removed field
* made it full public
* Added FormerlySerializedAs
* Added HideInInspector
* Updated example
2020-01-24 22:33:55 +01:00
Chris Langsenkamp
a82fe9191f
Fixed Additive Scene Visualizer
2020-01-24 12:34:08 -05:00
MrGadget
c84b00336d
Fix GetSceneIdenity name typo ( #1450 )
2020-01-23 11:46:03 -06:00
vis2k
84fc240d00
NetworkReaderTest: stopwatch not needed, Unity already shows the time
2020-01-23 15:56:16 +01:00
vis2k
2f7a67e3f9
NetworkReaderTest: benchmark test so it's easier to check performance after changes
2020-01-23 15:51:52 +01:00
Paul Pacheco
0ed8550c02
refactor: Move Editor tests to Tests/Editor ( #1449 )
2020-01-22 21:35:10 +01:00
vis2k
b5a4988331
FallbackTransportTest from paul
2020-01-22 11:55:56 +01:00
vis2k
9d7513925f
NetworkReaderTest to reach 100% NetworkReader coverage
2020-01-22 09:51:06 +01:00
vis2k
e798ac45de
MessagePackerTest: cover UnpackMessage non generic version
2020-01-22 09:46:30 +01:00
vis2k
5736dd8d05
MessagePackerTest: cover FormatException case
2020-01-22 09:30:09 +01:00
Chris Langsenkamp
17af872f99
Use conn instead of NetworkClient
2020-01-21 21:44:15 -05:00
Chris Langsenkamp
f778b4c399
Removed unnecessary using
2020-01-21 17:35:57 -05:00
Chris Langsenkamp
71bd09417c
Removed MonoBehaviour inheritance
2020-01-21 17:23:14 -05:00
Chris Langsenkamp
388a338cfa
Removed commented code
2020-01-21 17:16:08 -05:00
MrGadget
c147caf30c
Added ErrorMessage Test ( #1448 )
2020-01-21 23:01:34 +01:00
Chris Langsenkamp
cbbe82e4d1
Make roomSlots work correctly for clients
2020-01-20 20:04:09 -05:00
vis2k
15c77c6926
NetworkTransform.SerializeIntoWriterTest
2020-01-20 11:02:11 +01:00
vis2k
875f19e030
Mirror.Tests asmdef references Mirror.Components asmdef
2020-01-20 10:54:59 +01:00
Chris Langsenkamp
eef97e9a52
Code cleanup
2020-01-19 23:34:53 -05:00
Chris Langsenkamp
c57c01a47a
Updated Script Templates
2020-01-19 16:45:12 -05:00
MrGadget
268753c3bd
fix: Fix Room Slots for clients ( #1439 )
...
* Fix Room Slots for clients
* Removed change to ServerChangeScene
2020-01-19 11:39:26 +01:00
MrGadget
cb4be4df78
Set AllPlayersready false in the Room scene ( #1440 )
2020-01-19 11:38:59 +01:00
MrGadget
e4c498312e
Reorder properties with headers ( #1437 )
2020-01-17 12:09:08 +01:00
MrGadget
f69f1743c5
feat: Add Sensitivity to NetworkTransform ( #1425 )
...
* Add Sensitivity to NetworkTransform
* Removed commented lines
* Made them floats
* Tooltips
* Added comments
* Update NetworkTransformBase.cs
Co-authored-by: vis2k <info@noobtuts.com>
2020-01-16 09:06:25 +01:00
Chris Langsenkamp
bafe3b28fd
Freshen Example Appearance
2020-01-13 22:05:08 -05:00
vis2k
2186f3c7d7
clean up Pong folder
2020-01-13 17:34:55 +01:00
vis2k
cb3d9f0d08
fix: Telepathy works on .net core again
2020-01-13 17:27:44 +01:00
Paul Pacheco
0c047f9227
Remove latin placeholder text in chat window ( #1430 )
2020-01-12 17:07:57 -06:00
Paul Pacheco
42a2f9b853
fix: Decouple ChatWindow from player ( #1429 )
2020-01-12 16:53:14 -06:00
MrGadget
a0c96f8518
fix: StopHost with offline scene calls scene change twice ( #1409 )
...
* Separate StopHostClient
* Added comments
* move comment
* add comment
* Changed to loadingSceneAsync check
* Update Assets/Mirror/Runtime/NetworkManager.cs
Co-authored-by: vis2k <info@noobtuts.com>
2020-01-12 00:12:46 +01:00
MrGadget
29c96b6bc0
made handlers private ( #1426 )
2020-01-11 21:38:09 +01:00
MrGadget
c30e4a9f83
feat: NetworkAnimator warns if you use it incorrectly ( #1424 )
...
* Added warnings to NetworkAnimator
* Updated ChangeLog
* pauls suggestions
2020-01-11 10:35:58 -06:00
MrGadget
f858f4d703
Rename WeaveExisingAssemblies to fix spelling ( #1423 )
2020-01-10 19:07:59 -06:00
MrGadget
dffdf02be5
feat: Network Animator can reset triggers ( #1420 )
2020-01-10 18:33:10 -06:00
MrGadget
7d472f21f9
perf: Use NetworkWriterPool in NetworkAnimator ( #1421 )
2020-01-10 18:10:06 -06:00
MrGadget
a4578458a1
perf: Use NetworkWriterPool in NetworkTransform ( #1422 )
2020-01-10 18:09:27 -06:00
vis2k
b9f52fdb46
breaking: fix : #1151 - assign SyncVars before calling the Hook. Hook now passes old and new value instead of changing it from new value to old value, as this would break all SyncVar Hook projects silently. ( #1416 )
...
* test
* new docs
* adjust CheckForHookFunction to expect two hooks
* update example
* update example
* update example
* update test
* update example
* SyncVar.set: store value in oldValue variable
* SyncVar.set: pass old value to hook too
* TODO
* SyncVar deserialize store value in oldValue variable (for simple types)
* SyncVar deserialize: pass old value to hook too (for simple types)
* add test for GameObject type
* fix comment
* SyncVar deserialize: set value before calling hook
* add TODO
* SyncVar.set: set value before calling hook
* replace tests
* GO test
* SyncVar deserialize: move oldvalue code higher up so it applies to GO/NI too
* syntax
* SyncVar deserialize: pass oldValue to hook (GO/NI types)
* SyncVar deserialize: set netid before calling hook (GO/NI types)
* update comment
* update comment
* update comment
* shorter
* comment, TODO
* put oldValue code into separate cases again
* fix SyncVarEqual comparing the same two __goNetId values
* get rid of tmpValue
* fix weaver tests
* remove TODO
* SyncVar deserialize simple types: get rid of tmpValue here too
* remove tests
2020-01-10 16:17:13 +01:00
vis2k
a1649dfb25
remove outdated comment
2020-01-10 12:36:18 +01:00
vis2k
49d93d814c
NetworkClient.Shutdown calls Client.Disconnect as suggested in #923
2020-01-10 12:34:42 +01:00
vis2k
260cb49698
NetworkServer.Shutdown: add comment on why we call Transport.ServerStop, not Shutdown as suggested in #923
2020-01-10 12:30:01 +01:00
vis2k
fd7dc5e226
fix : #723 - NetworkTransform teleport works properly now
2020-01-09 09:15:47 +01:00
vis2k
2d59de801f
fix #923 : move NetworkManager.OnApplicationQuit Transport Shutdown code into Transport.OnApplicationQuit. Fixes a potential bug where the Transport wouldn't be shut down if someone doesn't use the NetworkManager.
2020-01-09 08:32:25 +01:00
vis2k
76a514aeec
syntax
2020-01-09 08:32:20 +01:00
vis2k
651e709785
fix #1407 : Check EnterPlayModeSettings and disable if needed for 2019.3 support ( #1415 )
...
* fix #1407 : Check EnterPlayModeSettings and disable if needed for 2019.3 support
* add reference
2020-01-09 08:03:47 +01:00
vis2k
a3ffd1264c
fix : #1278 - only call initial state SyncVar hooks on clients if the SyncVar value is different from the default one. ( #1414 )
...
* move comment
* add comment
* fix : #1278 - only call initial state SyncVar hooks on clients if the SyncVar value is different from the default one.
* initialState test for an if
* !initialstate
* getting there
* closer
* works but incompatible stack heights message
* better comments
* better
* not needed
* syntax
* rename
* incompatible stack height fixed
* update comment
* remove first todo
* SAVE PROGRESS
* compare go/ni too
* whitespace
* update comments
2020-01-08 16:58:46 +01:00
vis2k
32abb70ae9
add comment
2020-01-08 13:27:11 +01:00
vis2k
aafe387899
add comment
2020-01-08 12:16:58 +01:00
vis2k
a71ecdba4a
fix : #1380 - NetworkConnection.clientOwnedObjects changed from uint HashSet to NetworkIdentity HashSet for ease of use and to fix a bug where DestroyOwnedObjects wouldn't find a netId anymore in some cases.
2020-01-08 11:32:29 +01:00
vis2k
a2173d37db
NetworkConnection.DestroyOwnedObjects clears the hashset afterwards
2020-01-08 11:04:57 +01:00
vis2k
43030ac917
NetworkConnection.DestroyOwnedObjects to move code out of NetworkServer
2020-01-08 11:04:17 +01:00
Chris Langsenkamp
6111021252
meta file
2020-01-08 01:34:09 -05:00
vis2k
228b32e1da
fix : #1241 - Telepathy updated to latest version. All tests are passing again. Thread.Interrupt was replaced by Abort+Join.
2020-01-07 20:55:34 +01:00
vis2k
2dc13e9666
Merge pull request #1404 from vis2k/NetTransAuthority
...
fix: Use hasAuthority instead of isLocalPlayer
2020-01-07 16:24:27 +01:00
Chris Langsenkamp
3d3436c80a
Renamed and added comment
2020-01-07 10:17:44 -05:00
vis2k
28803b90de
Merge pull request #1405 from vis2k/NetAnimClientAuthCheck
...
fix: Check clientAuthority in NetworkAnimator
2020-01-06 15:15:37 +01:00
vis2k
25277e00ad
Merge pull request #1406 from vis2k/Remove-DDOL-Escape
...
Remove DDOL escape
2020-01-06 15:15:07 +01:00
vis2k
bfe90857bb
Log is enough for now
2020-01-06 12:51:01 +01:00
vis2k
474a9480a5
ConnectHost moved into FinishStartHost
2020-01-06 12:36:03 +01:00
vis2k
3eb11c9a2d
FinishLoadScene uses new NetworkManager.mode. This way the host connection doesn't need to be connected before changing host server's online scene. This makes everything easier.
2020-01-06 12:35:56 +01:00
vis2k
b9c9a3c350
NetworkManager.mode to simplify FinishLoadScene afterwards
2020-01-06 12:35:49 +01:00
Chris Langsenkamp
5a728ac4e6
Remove DDOL escape
2020-01-06 06:04:08 -05:00
Chris Langsenkamp
00149f3a2d
Fixed comment
2020-01-06 04:27:43 -05:00
Chris Langsenkamp
847d02cfda
Add clientAuthority check
2020-01-05 20:01:42 -05:00
Chris Langsenkamp
7b1761ea1e
Add clientAuthority check
2020-01-05 19:56:33 -05:00
MrGadget
039cf5af22
Use hasAuthority instead of isLocalPlayer
...
This allows non-player objects that have been assigned authority to the client to be moved around by the client and their positions updated from that client appropriately when clientAuthority is also true.
2020-01-05 18:50:13 -05:00
vis2k
7776049526
ConnectHost moved into FinishStartHost
2020-01-05 20:42:41 +01:00
vis2k
f33d90a4ca
FinishLoadScene uses new NetworkManager.mode. This way the host connection doesn't need to be connected before changing host server's online scene. This makes everything easier.
2020-01-05 20:38:18 +01:00
vis2k
1fe1ca730c
NetworkManager.mode to simplify FinishLoadScene afterwards
2020-01-05 20:35:00 +01:00
vis2k
ccb45a6215
FinishLoadSceneHost doesn't call OnClientSceneChanged if the scene changed because of a StartHost call. fixes a bug where AddPlayer was called twice in mrgadget's simple scenes example.
2020-01-05 20:30:22 +01:00
vis2k
df9c29a6b3
fix: FinishLoadSceneHost calls FinishStart host which now calls StartHostClient AFTER server online scene was loaded. Previously there was a race condition where StartHostClient was called immediately in StartHost, before the scene change even finished. This was still from UNET.
2020-01-05 19:49:26 +01:00
vis2k
4f169b021d
add comment
2020-01-05 19:26:14 +01:00
vis2k
fadcd46eff
add more comments
2020-01-05 19:14:44 +01:00
vis2k
5029bc5253
StartHost: add comment on what StartHostClient does
2020-01-05 19:14:02 +01:00
vis2k
7f7658ad75
add comment
2020-01-05 19:12:34 +01:00
vis2k
f7500a2a82
OnClientConnect: explain clientLoadedScene flag
2020-01-05 19:04:46 +01:00
vis2k
af878bd915
Merge pull request #1388 from paulpach/privatehandler
...
refactor: this should not be accessible
2020-01-03 09:49:06 +01:00
vis2k
654979aa3c
Merge pull request #1387 from vis2k/UpdateRoomExample
...
Room Example: NetworkManager moved to Offline scene
2020-01-03 09:48:40 +01:00
vis2k
217f880191
Merge pull request #1389 from paulpach/privatevislist
...
fix: it is not safe to modify this outside this class
2020-01-02 10:35:28 +01:00
Paul Pacheco
ae3860f51b
refactor: use save parameter name as overriden method
2020-01-01 20:28:43 -06:00
Paul Pacheco
addbd91fbd
Fix floating point comparison
2020-01-01 20:28:43 -06:00
Paul Pacheco
480350d413
refactor: avoid unused private warning
2020-01-01 20:28:43 -06:00
Paul Pacheco
bd7e27c662
refactor: remove unnecesary base.
2020-01-01 20:22:03 -06:00
Paul Pacheco
12c10a3896
refactor: reuse authentication expiration
2020-01-01 20:11:50 -06:00
Paul Pacheco
12de543aa4
fix: move NetworkStreamExtension in a namespace
2020-01-01 20:02:37 -06:00
Paul Pacheco
7ce95c5cea
fix: null reference exception
2020-01-01 19:59:07 -06:00
Paul Pacheco
bc7a961e4d
fix: it is not safe to modify this outside this class
2020-01-01 19:56:56 -06:00
Paul Pacheco
663773c3fc
refactor: this should not be accessible
2020-01-01 19:55:20 -06:00
Paul Pacheco
33493a0137
fix: potential null reference exception with debug logging
2020-01-01 19:34:55 -06:00
Paul Pacheco
2668b17162
fix: move listserver classes into package
2020-01-01 19:09:37 -06:00
Paul Pacheco
f02d3174db
fix: list server logs properly when disconnected
2020-01-01 19:07:48 -06:00
Paul Pacheco
a438216458
refactor: Remove double semicolon
2020-01-01 15:33:52 -06:00
Chris Langsenkamp
97871e23c2
Updated ReadMe
2020-01-01 15:56:40 -05:00
Chris Langsenkamp
147ddab13e
NetworkManager moved to Offline scene
2020-01-01 15:46:36 -05:00
Chris Langsenkamp
f64cf6e3db
Update Prefabs & Scenes to Master
2020-01-01 12:34:30 -05:00
vis2k
c2d817259b
NetworkManager.FinishLoadScene: split into host/server/client functions to prepare for further improvements
2020-01-01 13:34:34 +01:00
vis2k
5d68ef2c28
update comment
2020-01-01 12:49:59 +01:00
vis2k
11586a4177
explain StartHost
2020-01-01 12:18:07 +01:00
vis2k
9d9625b42f
explain StartServer
2020-01-01 12:16:01 +01:00
Paul Pacheco
05ce317714
refactor: cleanup code format using dotnet-format
2019-12-31 23:14:17 -06:00
Paul Pacheco
1d20a27879
Follow naming convention for private variable
2019-12-31 22:23:20 -06:00
Paul Pacheco
c90bbaa66b
Follow naming convention for private variable
2019-12-31 22:23:08 -06:00
Paul Pacheco
c31e7c8202
Follow naming conventions
2019-12-31 22:18:24 -06:00
Paul Pacheco
cfc280a527
Don't use deprecated methods in test
2019-12-31 21:27:48 -06:00
Paul Pacheco
e8ca3401d0
Don't use deprecated methods in test
2019-12-31 21:24:07 -06:00
Chris Langsenkamp
f117bdb9fc
Filled in missing summary comments
2019-12-31 09:54:03 -05:00
vis2k
588117e6d4
add comment
2019-12-31 15:39:08 +01:00
vis2k
c4e3c2debf
ServerChangeScene: disable Transport before sceneload call. it's cleaner this way.
2019-12-31 15:34:24 +01:00
vis2k
a603a55ed5
syntax
2019-12-31 15:33:41 +01:00
vis2k
0ed0c077fb
remove empty line
2019-12-31 15:28:33 +01:00
vis2k
21045466bf
NetworkManager.ConnectLocalClient renamed to StartHostClient for consistency with StartClient (it does almost the same as StartClient)
2019-12-31 12:09:21 +01:00
vis2k
97fd6b5d7e
NetworkManager.StartHost: OnStartClient call moved into ConnectLocalClient for consistency with StartClient functions
2019-12-31 12:07:22 +01:00
vis2k
0b0c1edad2
update log message
2019-12-31 12:06:20 +01:00
vis2k
668d6a063d
NetworkManager.ConnectLocalClient moved higher near StartClient because it's similar
2019-12-31 12:06:09 +01:00
vis2k
a472edd14c
NetworkClient.SetupLocalConnection renamed to ConnectHost for consistency with NetworkClient.Connect (it does almost the same anyway)
2019-12-31 11:10:10 +01:00
vis2k
b36c347200
call OnStartHost AFTER SetupServer
2019-12-31 11:02:21 +01:00
vis2k
ed260cfb18
add comments
2019-12-31 10:24:21 +01:00
vis2k
23b5b50155
Call SetupLocalConnection after SetupServer to prepare for local connection removal, where a real connection can only connect to the server after it was started, not before.
2019-12-31 10:24:10 +01:00
vis2k
07a85309e0
StartHost calls SetupServer + scene change + spawnobjects manually
2019-12-31 10:14:42 +01:00
vis2k
539fe69585
StartServer code mostly moved into SetupServer
2019-12-31 10:11:20 +01:00
vis2k
a8d3e0c998
move log message above
2019-12-31 09:41:05 +01:00
vis2k
e54728d1cc
NetworkManager.StartServer changed to void because it always returned true
2019-12-31 09:40:53 +01:00
vis2k
9969cc1c08
NetworkServer.Listen changed to void because it always returned true
2019-12-31 09:32:51 +01:00
vis2k
8787910d34
add comment
2019-12-31 09:30:29 +01:00
vis2k
2971345f37
NetworkManager.StartServer: scene change check moved into IsServerOnlineSceneChangeNeeded
2019-12-31 09:26:13 +01:00
Paul Pacheco
39817fcf00
docs: refer to the correct RegisterHandler method
2019-12-30 13:17:40 -06:00
Chris Langsenkamp
3a17699c23
Cleared Spawn Prefabs - not needed
2019-12-30 13:15:21 -05:00
vis2k
892acf272c
explain SetupLocalConnection order properly
2019-12-30 18:47:24 +01:00
vis2k
cfe9520f7c
add comments
2019-12-30 17:37:44 +01:00
Chris Langsenkamp
53b160e480
Update NetworkBehaviour Template
2019-12-30 09:47:44 -05:00
vis2k
3e28b10dcb
syntax
2019-12-30 13:33:02 +01:00
vis2k
d712cd0303
fix: NetworkTransform clientAuthority works again via clientAuthority option that is configurable in inspector. this had to be fixed after we removed local authority.
2019-12-30 11:09:18 +01:00
vis2k
e8015dfc80
typos
2019-12-30 09:12:24 +01:00
vis2k
87376ae3af
SendTargetRPCInternal: disallow all connections to server, not just the local client one
2019-12-29 22:07:47 +01:00
vis2k
53aa0bcc19
improve comments
2019-12-29 21:42:42 +01:00
vis2k
ee1807c85c
remove empty line
2019-12-29 21:36:07 +01:00
Paul Pacheco
7258823a3c
Test that OnStartServer is propagated by NI
2019-12-27 19:20:01 -06:00
Julien Heimann
3c0bc28228
feat: generate serializers for IMessageBase structs ( #1353 )
...
* Allow Weaver to add bodies to IMessageBase structs with empty de/serialize methods
* Update Assets/Mirror/Editor/Weaver/Processors/MessageClassProcessor.cs
Co-Authored-By: Paul Pacheco <paulpach@gmail.com>
* applied suggested changes
* adjusted empty method check
* Update Assets/Mirror/Editor/Weaver/Processors/MessageClassProcessor.cs
formatting
Co-Authored-By: vis2k <info@noobtuts.com>
Co-authored-by: Paul Pacheco <paulpach@gmail.com>
Co-authored-by: vis2k <info@noobtuts.com>
2019-12-27 10:12:28 -06:00
MrGadget
b34ae51965
Replace License.txt ( #1360 )
2019-12-26 09:51:56 -06:00
vis2k
4cc4279d7d
fix : #1359 . Revert "Destroy objects owned by this connection when disconnecting ( #1179 )"
...
This reverts commit 8931944005
2019-12-26 13:43:02 +01:00
MrGadget
8e77da3424
Call OnClientConnect in FinishLoadScene ( #1357 )
2019-12-26 10:07:37 +01:00
MrGadget
ba3f855c98
Add Meta Files ( #1358 )
2019-12-26 10:07:08 +01:00
Paul Pacheco
d7a58d25d4
fix: destroy owned objects ( #1352 )
...
* fix: destroy owned objects
fix #1346
Broken in PR #1206
alternative to #1351
* fix nre
* Simplify
2019-12-23 19:25:16 -06:00
Paul Pacheco
d83efbbd8d
Test connect and send
2019-12-23 19:06:14 -06:00
Paul Pacheco
e7abf4e7c7
Test transport events
2019-12-23 18:06:00 -06:00
Paul Pacheco
fe39459181
Test ClientSend
2019-12-23 17:44:03 -06:00
Paul Pacheco
ad115af845
Test ClientDisconnect
2019-12-23 17:37:50 -06:00
Paul Pacheco
947c473a3d
Test ClientConnected
2019-12-23 17:23:58 -06:00
Paul Pacheco
3e0802607a
Test connecting with uri
2019-12-23 16:44:40 -06:00
Paul Pacheco
1eff4ed4e6
Test connect
2019-12-23 16:36:13 -06:00
Paul Pacheco
caece9ecde
Fully initialize multiplex for testing
2019-12-23 16:29:40 -06:00
Paul Pacheco
a132a9c47a
Test available method
2019-12-23 16:26:25 -06:00
Paul Pacheco
c6af3c39f7
Add NSubstitute
2019-12-23 16:19:03 -06:00
Paul Pacheco
b55cf957a8
refactor: move ninja websocket in it's own assembly
2019-12-23 16:03:09 -06:00
Paul Pacheco
885e1f4c73
test: Mocking library for testing ( #1350 )
...
* Include mocking libraries
* reimported nsubstitute dlls
* Only include as part of test assemblies
2019-12-23 14:51:20 -06:00
Paul Pacheco
9f2dca56f0
refactor: compatibility with 2019.3
2019-12-23 13:40:16 -06:00
Paul Pacheco
a800064d8a
test: Test packing floats into ushort
2019-12-23 12:52:39 -06:00
Paul Pacheco
ad2bee222a
test: removing pair test
2019-12-23 12:25:14 -06:00
Paul Pacheco
f12fa2f51a
test: Simplify tests
2019-12-23 12:21:50 -06:00
Paul Pacheco
60cfea0d14
test: copyto tests
2019-12-23 11:37:53 -06:00
MrGadget
abd2af9001
Made loadingSceneAsync public ( #1349 )
2019-12-23 08:32:15 +01:00
MrGadget
58f573729f
Allow Custom Scene Handling ( #1329 )
2019-12-22 19:59:35 +01:00
MichalPetryka
3d94f4b6c7
Remove trailing whitespace and fix encodings ( #1342 )
2019-12-22 11:58:52 +01:00
vis2k
307f129bd7
remove trailing whitespaces
2019-12-22 11:13:18 +01:00
vis2k
4c6805cf86
update comment
2019-12-22 11:12:45 +01:00
vis2k
45a8e6367b
Telepathy updated to latest version
2019-12-22 09:33:26 +01:00
vis2k
93d3511266
add comment
2019-12-22 09:24:31 +01:00
vis2k
54498403a5
fix: potential exploits / out of sync issues where clients with different transports might see different game states because of different max message sizes when using FallbackTransport. ( #1331 )
2019-12-22 09:18:51 +01:00
Paul Pacheco
9926472d98
feat: Chat example ( #1305 )
...
* Add chat example
* Update Assets/Mirror/Examples/Chat/Scripts/ChatNetworkManager.cs
Co-Authored-By: MrGadget <chris@clevertech.net>
* Update Assets/Mirror/Examples/Chat/Scripts/Player.cs
Co-Authored-By: MrGadget <chris@clevertech.net>
* Update Assets/Mirror/Examples/Chat/Scripts/ChatWindow.cs
Co-Authored-By: MrGadget <chris@clevertech.net>
* Update Assets/Mirror/Examples/Chat/Scripts/Player.cs
Co-Authored-By: MrGadget <chris@clevertech.net>
* Update Assets/Mirror/Examples/Chat/Scripts/Player.cs
Co-Authored-By: MrGadget <chris@clevertech.net>
* Update Assets/Mirror/Examples/Chat/Scripts/Player.cs
Co-Authored-By: MrGadget <chris@clevertech.net>
* Change package to chat
* Update Assets/Mirror/Examples/Chat/Scripts/ChatNetworkManager.cs
Co-Authored-By: MrGadget <chris@clevertech.net>
* Update Assets/Mirror/Examples/Chat/Scripts/ChatNetworkManager.cs
Co-Authored-By: MrGadget <chris@clevertech.net>
* Update Assets/Mirror/Examples/Chat/Scripts/ChatNetworkManager.cs
Co-Authored-By: MrGadget <chris@clevertech.net>
* Update Assets/Mirror/Examples/Chat/Scripts/ChatNetworkManager.cs
Co-Authored-By: MrGadget <chris@clevertech.net>
* Update Assets/Mirror/Examples/Chat/Scripts/ChatWindow.cs
Co-Authored-By: MrGadget <chris@clevertech.net>
* UI FIxes
* Lighting
* Fixed ScrollView
* Fixed username assignment
* removed commented line
* Layout refinement
* remove empty lines
Co-Authored-By: MrGadget <chris@clevertech.net>
* fixed which element was enabled
* Strip unprintable characters
* reverted ASCI filter
Co-authored-by: MrGadget <chris@clevertech.net>
2019-12-21 13:22:02 -06:00
vis2k
b3127beb89
fix: MultiplexTransport GetMaxMessageSize NullReferenceException when called on server. And fixes potential exploits / out of sync issues where clients with different transports might see different game states because of different max message sizes. ( #1332 )
2019-12-21 08:09:33 -06:00
MrGadget
9a0127aadc
Remove usings ( #1327 )
...
* Removed extraneous usings
* Removed extraneous usings
* Removed extraneous usings
2019-12-21 10:26:22 +01:00
MrGadget
ea4fc93159
Add return to ClientConnect(Uri) ( #1326 )
2019-12-20 21:46:52 +01:00
MrGadget
0e705d4aa0
Remove all extraneous blank lines ( #1325 )
2019-12-20 21:46:16 +01:00
MrGadget
b479b8ee51
Put the return back in ClientConnect ( #1324 )
2019-12-20 21:16:45 +01:00
MrGadget
1be4de3f63
Adjust cameras for server view ( #1318 )
2019-12-19 08:06:00 +01:00
Chris Langsenkamp
a5d369f96c
fixed comment
2019-12-18 16:53:09 -05:00
MrGadget
abf5cdcf36
feat: Add roomPlayer parameter to OnRoomServerCreateGamePlayer ( #1317 )
...
* Adds roomPlayer parameter to OnRoomServerCreateGamePlayer
* fixed template
2019-12-17 10:16:14 +01:00
vis2k
6fb8a32f5b
remove NetworkIdentityEditor because it's not really needed after removing local player authority (which required special checks to only show one option at a time). Also fixes #1289 ( #1309 )
2019-12-16 08:50:47 +01:00
Paul Pacheco
a2e17108b6
display the whole connection
2019-12-13 08:03:15 -06:00
Paul Pacheco
dbe064393a
fix: error when there are no network behaviors ( #1303 )
...
Use the lazy network behaviors cache everywhere, so this can never be null
2019-12-12 20:28:31 -06:00
MrGadget
ca4ff9b6b2
Fix Delayed Disconnect ( #1302 )
2019-12-12 20:02:23 -06:00
MrGadget
3684033f6a
Restore clientAuthorityCallback ( #1298 )
2019-12-12 19:31:11 -06:00
MrGadget
c6678eb3f1
No point in calling this here ( #1300 )
2019-12-12 19:30:40 -06:00
MrGadget
a18d6b5eaa
Unused field ( #1299 )
2019-12-12 19:11:20 -06:00
Paul Pacheco
e4a701ed4e
feat: fallback transport now supports uri ( #1296 )
2019-12-10 17:13:32 +01:00
Paul Pacheco
c206f9ad97
feat: Multiplex based on url ( #1295 )
...
If the multiplex transport receives an url for connection,
try all the underlying transports until it finds a suitable one
For example, let's say you configure a multiplex transport with telepathy and websocket, if you try:
```cs
NetworkManager.StartClient("tcp4://host:port");
```
then the multiplex transport will use telepathy.
if we pass:
```cs
NetworkManager.StartClient("ws://host:port");
```
then the multiplex transport will select websocket
2019-12-10 07:36:42 +01:00
Paul Pacheco
7865a840b6
feat: LLAPI transport can receive port from uri ( #1294 )
...
* feat: LLAPI transport can receive port from uri
* Refactor to use the original method
2019-12-09 21:52:50 +01:00
Paul Pacheco
c8ad118d50
feat: websocket can receive port in url ( #1287 )
...
* feat: websocket can now receive port and encryption setting from uri
* check for ws or wss scheme
2019-12-09 16:52:39 +01:00
Paul Pacheco
06946cf37f
feat: telepathy can now receive port from uri ( #1284 )
...
* feat: telepathy can receive port from uri
* Use configured port if the url does not have one
* use tcp4 as scheme for telepathy
* don't change default port
* Update TelepathyTransport.cs
* Update TelepathyTransport.cs
2019-12-08 19:48:26 +01:00
vis2k
e766f7b511
Update list server header text
2019-12-08 09:08:35 +01:00
Tor Esa Vestergaard
a0425e4e84
fix: Draw SyncVar label for Unity objects inline ( #1291 )
...
* SyncVar label for Unity objects is now drawn inline instead of on the next line
* Made syncVarIndicatorContent static
Did it since there's no need to have that allocation per editor instance.
2019-12-07 14:29:14 +01:00
MrGadget
c8aabd246a
Fix Inspector Refresh ( #1290 )
2019-12-07 09:20:31 +01:00
MrGadget
7843b12f7f
Make startPositionIndex public ( #1288 )
...
* Make startPositionIndex public
startPositions is a public list, so the index should be too.
* Update NetworkManager.cs
* Update NetworkManager.cs
2019-12-06 06:55:38 +01:00
Paul Pacheco
f9d34d5863
feat: Mirror now supports message inheritance ( #1286 )
...
* test: child messages should serialize parent's data
* feat: Mirror now supports inheritance for messages
2019-12-05 11:21:42 -06:00
Paul Pacheco
7e4023246b
fix: Don't set asset id for scene objects
...
Fixes this warning:
```
SetDynamicAssetId object already has an assetId <68fb15ce5f2e7eb44a8ac123d853b91a>
UnityEngine.DebugLogHandler:Internal_Log(LogType, String, Object)
UnityEngine.DebugLogHandler:LogFormat(LogType, Object, String, Object[])
UnityEngine.Logger:Log(LogType, Object)
UnityEngine.Debug:LogError(Object)
Mirror.NetworkIdentity:set_assetId(Guid) (at D:\Unity\Projects\TestUmmorpg\Assets\uMMORPG\Plugins\Mirror\Runtime\NetworkIdentity.cs:165)
Mirror.ClientScene:ApplySpawnPayload(NetworkIdentity, SpawnMessage) (at D:\Unity\Projects\TestUmmorpg\Assets\uMMORPG\Plugins\Mirror\Runtime\ClientScene.cs:470)
Mirror.ClientScene:OnSpawn(SpawnMessage) (at D:\Unity\Projects\TestUmmorpg\Assets\uMMORPG\Plugins\Mirror\Runtime\ClientScene.cs:529)
Mirror.<>c__DisplayClass35_0`1:<RegisterHandler>b__0(NetworkConnection, SpawnMessage) (at D:\Unity\Projects\TestUmmorpg\Assets\uMMORPG\Plugins\Mirror\Runtime\NetworkClient.cs:400)
Mirror.<>c__DisplayClass7_0`1:<MessageHandler>b__0(NetworkMessage) (at D:\Unity\Projects\TestUmmorpg\Assets\uMMORPG\Plugins\Mirror\Runtime\MessagePacker.cs:163)
Mirror.NetworkConnection:InvokeHandler(Int32, NetworkReader, Int32) (at D:\Unity\Projects\TestUmmorpg\Assets\uMMORPG\Plugins\Mirror\Runtime\NetworkConnection.cs:271)
Mirror.NetworkConnection:TransportReceive(ArraySegment`1, Int32) (at D:\Unity\Projects\TestUmmorpg\Assets\uMMORPG\Plugins\Mirror\Runtime\NetworkConnection.cs:325)
Mirror.NetworkClient:OnDataReceived(ArraySegment`1, Int32) (at D:\Unity\Projects\TestUmmorpg\Assets\uMMORPG\Plugins\Mirror\Runtime\NetworkClient.cs:149)
UnityEngine.Events.InvokableCall`2:Invoke(ArraySegment`1, Int32)
UnityEngine.Events.UnityEvent`2:Invoke(ArraySegment`1, Int32)
Mirror.TelepathyTransport:ProcessClientMessage() (at D:\Unity\Projects\TestUmmorpg\Assets\uMMORPG\Plugins\Mirror\Runtime\Transport\TelepathyTransport.cs:79)
Mirror.TelepathyTransport:LateUpdate() (at D:\Unity\Projects\TestUmmorpg\Assets\uMMORPG\Plugins\Mirror\Runtime\Transport\TelepathyTransport.cs:106)
```
2019-12-05 05:15:43 -06:00
Paul Pacheco
00b51364ac
improve warning message
2019-12-05 05:12:44 -06:00
Paul Pacheco
7c3622cfae
feat: new way to connect using uri ( #1279 )
...
* feat: new way to connect using uri
* set the host name when starting by url
2019-12-05 11:57:24 +01:00
Paul Pacheco
0e1bc8110f
fix: ReplacePlayer now calls OnStartLocalPlayer ( #1280 )
...
* fix: ReplacePlayer now calls OnStartLocalPlayer
fixes #962
* fix: replace player cannot steal another player
2019-12-04 14:54:50 -06:00
MrGadget
b23cfc739d
Fix ServerChangeScene ( #1281 )
2019-12-04 14:49:33 -06:00
MrGadget
555d0d9cc0
Add true for keepAuthority ( #1277 )
2019-12-03 08:49:11 +01:00
vis2k
13e2dcccd9
breaking: SyncList.Callback passes old and new entries instead of only passing one entry which is sometimes the old, sometimes the new entry. This is more consistent and it's very useful to know the previous value in a hook for OP_SET and OP_DIRTY. ( #1273 )
...
* feature: SyncList.Callback passes old and new entries instead of only passing one entry which is sometimes the old, sometimes the new entry. This is more consistent and it's very useful to know the previous value in a hook for OP_SET and OP_DIRTY.
* update tests
* update docs
2019-12-03 08:35:41 +01:00
vis2k
97e838b932
SyncDictionary: remove unused OP_DIRTY operations
2019-12-03 08:17:55 +01:00
vis2k
4b9dcbf9f4
SyncList: remove unused OP_DIRTY operations
2019-12-03 08:16:44 +01:00
vis2k
c5079ada6c
remove SyncDictionary.Dirty function because it's unused and we removed it for SyncList already too ( #1272 )
2019-12-03 08:12:12 +01:00
Paul Pacheco
ad724fe23c
fix: replace player (remove authority by default) ( #1261 )
...
* fix: remove authority properly in replace player
This is an alternative to #1257
Now the user can pass a parameter to ReplacePlayer to indicate
that the old player should remain attached to the connection.
Note the user could simply pass true and then call RemoveAuthority themselves
which was the approach in #1257
Personally I would prefer #1257 , but this is at least better than
master because authority is removed the proper way.
* Update NetworkServer.cs
2019-12-03 08:11:39 +01:00
MrGadget
8012972b0e
Removed non-implemented overload ( #1276 )
2019-12-03 08:01:52 +01:00
vis2k
1eae07fa2c
remove unused SyncList.Dirty function
2019-12-02 11:50:18 +01:00
MrGadget
7898dc2347
Restore Room Player Authority ( #1267 )
2019-12-02 08:48:27 +01:00
MrGadget
1ed12dba79
Require Network Transform ( #1269 )
2019-12-02 06:41:07 +01:00
MrGadget
42a4a7cb00
Add Return button to Room Manager ( #1268 )
...
* Add Return button to Room Manager
* Simplified GUI
* Fixed height
2019-12-02 06:40:55 +01:00
MrGadget
cddef72b41
Move scoring to PlayerScore ( #1266 )
2019-12-02 06:40:11 +01:00
MrGadget
e6f8f3c46f
Improve Turn and Jump ( #1265 )
2019-12-02 06:39:56 +01:00
Paul Pacheco
8899d20712
fix: Additive scene can respawn objects safely ( #1270 )
...
* fix: Additive scene can respawn objects safely
* Update Assets/Mirror/Runtime/NetworkIdentity.cs
Co-Authored-By: MrGadget <chris@clevertech.net>
2019-12-01 22:48:08 -06:00
Paul Pacheco
c753089478
fix: don't call OnStartLocalPlayer twice ( #1263 )
2019-12-01 09:55:57 -06:00
Paul Pacheco
4d373c5071
fix: call OnStartClient only once in room ( #1264 )
2019-12-01 09:55:38 -06:00
Paul Pacheco
2195fee81c
fix: set authority when replacing the player
2019-11-30 07:09:06 -06:00
Paul Pacheco
c58ead16a6
Remove unused method
2019-11-29 23:10:25 -06:00
MrGadget
e8841a3c1d
Merge pull request #1259 from paulpach/fix2clients
...
fix: issue with more than 1 client
2019-11-29 19:58:07 -05:00
Paul Pacheco
095b54752a
isClient is already true, so make sure to initialize the objects
2019-11-29 18:23:46 -06:00
Paul Pacheco
ab73fbcf7a
Simplify isServer ( #1258 )
2019-11-29 18:06:44 -06:00
Chris Langsenkamp
55dabf2755
Updated Templates
2019-11-29 18:44:55 -05:00
Paul Pacheco
4816f0ead1
Spawn host objects via spawn, just like clients ( #1248 )
...
* Spawn host objects works via messages just like clients
* fix spawning local player
* Do not call OnStartClient twice
2019-11-29 17:25:32 -06:00
Paul Pacheco
b8618d356f
Revert "fix: replacing the player does not mean giving up authority ( #1254 )"
...
This reverts commit a2c273ecd1
2019-11-29 16:04:06 -06:00
Paul Pacheco
fb26d0023f
fix: isLocalPlayer is true during OnStartClient for Player ( #1255 )
...
related to #1250 but for client mode.
Before:
```
Void Awake() hasAuthority=False isClient=False isLocalPlayer=False
Void OnStartClient() hasAuthority=True isClient=True isLocalPlayer=False
Void OnStartAuthority() hasAuthority=True isClient=True isLocalPlayer=False
Void OnStartLocalPlayer() hasAuthority=True isClient=True isLocalPlayer=True
Void Start() hasAuthority=True isClient=True isLocalPlayer=True
```
After:
```
Void Awake() hasAuthority=False isClient=False isLocalPlayer=False
Void OnStartClient() hasAuthority=True isClient=True isLocalPlayer=True
Void OnStartAuthority() hasAuthority=True isClient=True isLocalPlayer=True
Void OnStartLocalPlayer() hasAuthority=True isClient=True isLocalPlayer=True
Void Start() hasAuthority=True isClient=True isLocalPlayer=True
```
2019-11-29 15:40:38 -06:00
Paul Pacheco
a2c273ecd1
fix: replacing the player does not mean giving up authority ( #1254 )
2019-11-29 15:02:55 -06:00
Paul Pacheco
9acde20b0a
fix: isLocalPlayer works in host mode onStartServer ( #1253 )
...
See #1250
Before:
```
Void Awake() hasAuthority=False isClient=False isLocalPlayer=False
Void OnStartServer() hasAuthority=False isClient=False isLocalPlayer=False
Void OnStartClient() hasAuthority=False isClient=True isLocalPlayer=False
Void OnStartAuthority() hasAuthority=True isClient=True isLocalPlayer=True
Void OnStartLocalPlayer() hasAuthority=True isClient=True isLocalPlayer=True
Void Start() hasAuthority=True isClient=True isLocalPlayer=True
```
after
```
Void Awake() hasAuthority=False isClient=False isLocalPlayer=False
Void OnStartServer() hasAuthority=False isClient=False isLocalPlayer=True
Void OnStartClient() hasAuthority=False isClient=True isLocalPlayer=True
Void OnStartAuthority() hasAuthority=True isClient=True isLocalPlayer=True
Void OnStartLocalPlayer() hasAuthority=True isClient=True isLocalPlayer=True
Void Start() hasAuthority=True isClient=True isLocalPlayer=True
```
Note it is not possible to fix Awake because it gets called before we
have any chance of setting any property
2019-11-29 14:34:07 -06:00
Paul Pacheco
d00c95bb55
fix: isClient now reports true onStartServer in host mode ( #1252 )
2019-11-29 14:10:46 -06:00
Paul Pacheco
2f19c7ca89
fix: hasAuthority is now visible in all overrides ( #1251 )
...
See #1250
Before:
```
Void Awake() hasAuthority=False isClient=False isLocalPlayer=False
Void OnStartServer() hasAuthority=False isClient=False isLocalPlayer=False
Void OnStartClient() hasAuthority=False isClient=True isLocalPlayer=False
Void OnStartAuthority() hasAuthority=True isClient=True isLocalPlayer=True
Void OnStartLocalPlayer() hasAuthority=True isClient=True isLocalPlayer=True
Void Start() hasAuthority=True isClient=True isLocalPlayer=True
```
After:
```
Void Awake() hasAuthority=False isClient=False isLocalPlayer=False
Void OnStartServer() hasAuthority=True isClient=False isLocalPlayer=False
Void OnStartClient() hasAuthority=True isClient=True isLocalPlayer=False
Void OnStartAuthority() hasAuthority=True isClient=True isLocalPlayer=True
Void OnStartLocalPlayer() hasAuthority=True isClient=True isLocalPlayer=True
Void Start() hasAuthority=True isClient=True isLocalPlayer=True
```
2019-11-29 13:09:46 -06:00
Paul Pacheco
7aa7815754
fix: Call hooks when initializing objects OnStartServer on host ( #1249 )
2019-11-29 15:12:06 +09:00
Paul Pacheco
7119dd15f8
fix: Do not call InternalAddPlayer twice ( #1246 )
2019-11-28 13:47:31 -06:00
MrGadget
4c0fb9ba34
Simplified Spawner ( #1244 )
2019-11-28 10:35:23 -06:00
MrGadget
d0c0f394f7
Auto Assign Character Controller ( #1245 )
2019-11-28 10:34:18 -06:00
MrGadget
d963e29d95
Made RandomColor a Separate Component ( #1240 )
...
* Made RandomColor a separate component
* Adjusted Prefab
* Simplified OnValidate
* Reverted unrelated changes
2019-11-28 09:42:46 -06:00
Chris Langsenkamp
c89ba52e3d
Change to using Color32
2019-11-27 21:32:25 -05:00
Paul Pacheco
a282c32394
clearer comment
2019-11-27 18:18:59 -06:00
Paul Pacheco
9a2ff84440
space in comment
2019-11-27 18:17:32 -06:00
Paul Pacheco
888e46c685
fix: OnSetHostVisibility can now check if it has authority
2019-11-27 17:53:30 -06:00
vis2k
d2075002ca
improve comment
2019-11-25 19:15:04 +09:00
vis2k
91fc3c25db
remove trailing whitespace
2019-11-25 19:11:55 +09:00
vis2k
ba88ca6ab5
explain the special case in RebuildObservers
2019-11-25 19:11:47 +09:00
Chris Langsenkamp
fad50818bf
Added AddComponentMenu empties and namespace
2019-11-24 14:35:19 -05:00
Chris Langsenkamp
37e5b49f28
Removed extraneous comments
2019-11-24 09:46:41 -05:00
Chris Langsenkamp
210540b669
Fixed Obsolete comment
2019-11-24 08:38:47 -05:00
Paul Pacheco
3b9414f131
perf: spawn with client authority only takes 1 message ( #1206 )
...
* perf: spawn with client authority only takes 1 message now
* Fix javadocs and warning
* Rename parameters
* Make sure we spawn players with authority
2019-11-24 10:22:43 +09:00
Paul Pacheco
5b04836bb2
fix: spawnwithauthority works again in host mode
2019-11-24 10:16:15 +09:00
Paul Pacheco
92d0df7b39
feat: SyncToOwner now works with authority ( #1204 )
...
* WIP redoing authority
* Local client also handles authority
* Remove unused callback
* Update Assets/Mirror/Runtime/NetworkIdentity.cs
Co-Authored-By: MrGadget <chris@clevertech.net>
* Update Assets/Mirror/Runtime/NetworkIdentity.cs
Co-Authored-By: vis2k <info@noobtuts.com>
* Rename pendingOwner
* Update Assets/Mirror/Runtime/NetworkIdentity.cs
Co-Authored-By: vis2k <info@noobtuts.com>
* Update Assets/Mirror/Runtime/NetworkIdentity.cs
Co-Authored-By: vis2k <info@noobtuts.com>
* Update Assets/Mirror/Runtime/NetworkIdentity.cs
Co-Authored-By: vis2k <info@noobtuts.com>
* Update Assets/Mirror/Runtime/NetworkIdentity.cs
Co-Authored-By: vis2k <info@noobtuts.com>
2019-11-23 15:07:00 +09:00
Paul Pacheco
24d8368b38
refactor: reuse connectionToClient for authority ( #1200 )
...
* refactor: reuse connectionToClient for authority
* Fix compilation issue
* Make PR easier to read
* Better error message
* Update Assets/Mirror/Runtime/NetworkIdentity.cs
Co-Authored-By: MrGadget <chris@clevertech.net>
2019-11-23 15:00:53 +09:00
Paul Pacheco
876da8bbcd
refactor: Simplify spawning
2019-11-23 14:54:37 +09:00
MrGadget
1e96cb7a8a
Replaces SpawnWithClientAuthority with Spawn Overloads ( #1233 )
...
* Replaces SpawnWithClientAuthority with Spawn Overloads
* Cleaned up comments and log messages
2019-11-23 14:26:27 +09:00
vis2k
e847344bde
syntax
2019-11-23 11:59:04 +09:00
vis2k
f0cf4e7e14
Replace 'local client' naming with 'host' to be less confusing. This breaks NetworkProximityChecker.OnSetLocalVisibility because it needs to be renamed to OnSetHostVisibility
...
* rename parameter
* obsolete
* rename parameter
2019-11-23 11:34:47 +09:00
Paul Pacheco
1d4b1faac2
docs: fix link to spawn custom player
2019-11-23 11:03:27 +09:00
Paul Pacheco
0bc151bb27
Obsolete built in messages
2019-11-23 11:03:18 +09:00
Paul Pacheco
c669ff155d
perf: avoid allocation for error messages
2019-11-23 11:03:08 +09:00
vis2k
1c7c54305d
add missing meta file
2019-11-23 11:00:49 +09:00
Chris Langsenkamp
638b445744
Update Prefabs After LocalPlayerAuthority Removed
2019-11-23 10:59:52 +09:00
MrGadget
8cf6a0707e
feat: Script Templates ( #1217 )
...
* Add Script Templates
* Moved serialization section down
* Added comments to Awake & Start
* Capitalization
* meta files
* Added doc links and XML comments
2019-11-23 10:59:38 +09:00
Chris Langsenkamp
477028913a
Update Prefabs After LocalPlayerAuthority Removed
2019-11-23 10:59:21 +09:00
Chris Langsenkamp
1699335aaa
fixed comment
2019-11-23 10:59:12 +09:00
Paul Pacheco
d741baed78
feat: Pass all information to spawn handler ( #1215 )
2019-11-23 10:57:52 +09:00
ZacNorthBigBox
701f4f4183
fix: Pass the name of the invoking class and desired command when an object has no authority. ( #1216 )
2019-11-23 10:57:45 +09:00
Paul Pacheco
2c58902357
Code style
2019-11-23 10:57:40 +09:00
Paul Pacheco
2081a757ea
Remove unused connection id cache
...
Good find by MrGadget
2019-11-23 10:57:32 +09:00
Paul Pacheco
2d4d4109bb
Make list cache readonly
2019-11-23 10:57:25 +09:00
Paul Pacheco
c2096d0fb7
Available transport is determined at connection time ( #1213 )
...
* Available transport is determined at connection time
* Update MultiplexTransport.cs
2019-11-23 10:57:11 +09:00
Paul Pacheco
ce305d95fc
Removed unused code
2019-11-23 10:57:09 +09:00
Paul Pacheco
15e03d9bbf
Removed unused code
2019-11-23 10:57:06 +09:00
Paul Pacheco
7ba4bc3590
use C# formatter
2019-11-23 10:56:53 +09:00
Paul Pacheco
09f6892c55
feat: An authenticator that times out other authenticators ( #1211 )
...
* feat: An authenticator that times out other authenticators
* Clean up some spaces
* Add tooltip for timeout
Disable timeout with 0
* Update Assets/Mirror/Authenticators/TimeoutAuthenticator.cs
Co-Authored-By: MrGadget <chris@clevertech.net>
* Update Assets/Mirror/Authenticators/TimeoutAuthenticator.cs
Co-Authored-By: MrGadget <chris@clevertech.net>
* Remove space
* Update Assets/Mirror/Authenticators/TimeoutAuthenticator.cs
Co-Authored-By: MrGadget <chris@clevertech.net>
* Update Assets/Mirror/Authenticators/TimeoutAuthenticator.cs
Co-Authored-By: MrGadget <chris@clevertech.net>
* Update Assets/Mirror/Authenticators/TimeoutAuthenticator.cs
Co-Authored-By: MrGadget <chris@clevertech.net>
* Update Assets/Mirror/Authenticators/TimeoutAuthenticator.cs
Co-Authored-By: MrGadget <chris@clevertech.net>
* Update Assets/Mirror/Authenticators/TimeoutAuthenticator.cs
Co-Authored-By: MrGadget <chris@clevertech.net>
* Update Assets/Mirror/Authenticators/TimeoutAuthenticator.cs
Co-Authored-By: MrGadget <chris@clevertech.net>
* Update Assets/Mirror/Authenticators/TimeoutAuthenticator.cs
Co-Authored-By: MrGadget <chris@clevertech.net>
* Update Assets/Mirror/Authenticators/TimeoutAuthenticator.cs
Co-Authored-By: MrGadget <chris@clevertech.net>
* use float for time
* Update Assets/Mirror/Authenticators/TimeoutAuthenticator.cs
* Update Assets/Mirror/Authenticators/TimeoutAuthenticator.cs
* Update Assets/Mirror/Authenticators/TimeoutAuthenticator.cs
2019-11-23 10:56:51 +09:00
Chris Langsenkamp
d821013deb
Added HelpURL to NetworkBehaviour
2019-11-23 10:56:22 +09:00
Chris Langsenkamp
e33f2e84cb
Updated summary comments
2019-11-23 10:56:04 +09:00
Paul Pacheco
bf9eb610dc
feat: NetworkConnection is optional for handlers ( #1202 )
...
* feat: NetworkConnection is optional for handlers
* make NetworkConnction optional in handlers
2019-11-23 10:52:24 +09:00
Paul Pacheco
12fd2ae6fc
Remove redundant namespace
2019-11-23 10:52:12 +09:00
Paul Pacheco
236dcb6734
remove redundant type parameter
2019-11-23 10:52:02 +09:00
Paul Pacheco
1531281516
Enforce proper type for connectionToClient
2019-11-23 10:51:50 +09:00
vis2k
db99dd7b3d
fix: when modifying a prefab, Unity calls OnValidate for all scene objects based on that prefab, which caused Mirror to reset the sceneId because we only checked if a prefab is currently edited, not if THIS prefab is currently edited
2019-11-03 14:33:59 +01:00
vis2k
188b74edd6
Fallback Transport ( #1198 )
...
* Fallback Transport
* doc
* doc
* help URL
* exception
* fixed help url
2019-11-03 00:04:59 +01:00
Paul Pacheco
f70a2ac702
refactor: Simplify spawn message ( #1195 )
...
* refactor: Simplify spawn message
* Update Assets/Mirror/Runtime/Messages.cs
* fix brainfart
* consolidate spawning logic
* simpler find
* remove unnecesary private keyword
* Remove redundant else
2019-10-31 10:07:37 +01:00
vis2k
6765da2387
Make Transport.Available() abstract ( #1194 )
...
* Make Transport.Available() abstract
* better
2019-10-30 13:02:07 -07:00
vis2k
7fe8888df5
perf: MultiplexTransport: avoid Linq allocations that would happen on every packet send because Send calls .ServerActive() each time
2019-10-30 20:18:02 +01:00
Paul Pacheco
40f50ac908
breaking: Remove localPlayerAuthority ( #1192 )
...
* breaking: Remove localPlayerAuthority (#1188 )
* breaking: Remove localPlayerAuthority
This flag does not do anything useful in anything but NetworkAnimator
so NetworkAnimator can keep it's own flag.
* Add tooltip with explanation
* Editor should no longer access localPlayerAuthority property
2019-10-30 18:13:25 +01:00
